From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.10432.1584518977929105418 for ; Wed, 18 Mar 2020 01:09:38 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) IronPort-SDR: BGngDOqf03zGgjnzG7FnsDWwDWYwOqcr+0RU/tRvws7bV/oGARDankoE/UHn1/kgZZlwPNsmVz a9XqCQoS8Zng== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 01:09:36 -0700 IronPort-SDR: iV6/uygguY3c8ZlRhylvBetVrbWIT2s0n5Rnqwlc3cjz+7y0GHJghZuIt6IBw6p1K6hQ2L7Fma LtfKjmmimFiw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,566,1574150400"; d="scan'208";a="444084352" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 18 Mar 2020 01:09:37 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Mar 2020 01:09:37 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Mar 2020 01:09:36 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.206]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0439.000; Wed, 18 Mar 2020 16:09:34 +0800 From: "Ni, Ray" To: "Jiang, Guomin" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Thread-Topic: [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Thread-Index: AQHV/PxqW6BfNGc9KkuZ0u0ACS/KYKhN/xiA Date: Wed, 18 Mar 2020 08:09:33 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C49EFDA@SHSMSX104.ccr.corp.intel.com> References: <20200318080824.1160-1-guomin.jiang@intel.com> In-Reply-To: <20200318080824.1160-1-guomin.jiang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Jiang, Guomin > Sent: Wednesday, March 18, 2020 4:08 PM > To: devel@edk2.groups.io > Cc: Jiang, Guomin ; Ni, Ray ; C= haganty, Rangasai V > > Subject: [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe= : Replace ASSERT_EFI_ERROR >=20 > From: Guomin Jiang >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2589 >=20 > According to code logic, it just judge the condition rather than the > status, it should use the ASSERT rather than ASSERT_EFI_ERROR. >=20 > Cc: Ray Ni > Cc: Rangasai V Chaganty > Signed-off-by: Guomin Jiang > --- > .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciD= eviceSecurityDxe/IntelPciDeviceSecurityDxe.c > b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecuri= tyDxe/IntelPciDeviceSecurityDxe.c > index 29b6916f61..aa2bf14fa8 100644 > --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSe= curityDxe/IntelPciDeviceSecurityDxe.c > +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSe= curityDxe/IntelPciDeviceSecurityDxe.c > @@ -69,7 +69,7 @@ RecordPciDeviceInList( > ASSERT_EFI_ERROR(Status); >=20 >=20 >=20 > NewPciDevice =3D AllocateZeroPool(sizeof(*NewPciDevice)); >=20 > - ASSERT_EFI_ERROR(NewPciDevice !=3D NULL); >=20 > + ASSERT(NewPciDevice !=3D NULL); >=20 >=20 >=20 > NewPciDevice->Signature =3D PCI_DEVICE_INSTANCE_SIGNATURE; >=20 > NewPciDevice->PciSegment =3D PciSegment; >=20 > -- > 2.25.1.windows.1