From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by mx.groups.io with SMTP id smtpd.web12.5070.1585107361768978873
 for <devel@edk2.groups.io>;
 Tue, 24 Mar 2020 20:36:01 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com)
IronPort-SDR: 1yB+uoZizIzJWEhbGmgAQD2oVzXZzdbPEVRpWALjDyHGRhpvRGvfsS4ooRL5bk9V4UWhJjWO43
 q8yeNZTwvRfw==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
  by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2020 20:36:01 -0700
IronPort-SDR: Mne8eJ04L6zxfg+GpObemgSQl/aznAs3f4pb+N1PJc5FIxR2ERvAUkurXCU2NZaUIHu5ghg4y4
 qoXh7hFezTDA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.72,302,1580803200"; 
   d="scan'208";a="265399476"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by orsmga002.jf.intel.com with ESMTP; 24 Mar 2020 20:36:00 -0700
Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 24 Mar 2020 20:36:00 -0700
Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by
 fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 24 Mar 2020 20:35:59 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.206]) by
 SHSMSX105.ccr.corp.intel.com ([169.254.11.144]) with mapi id 14.03.0439.000;
 Wed, 25 Mar 2020 11:35:57 +0800
From: "Ni, Ray" <ray.ni@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Dong, Eric" <eric.dong@intel.com>, Laszlo Ersek <lersek@redhat.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>, "Zeng, Star"
	<star.zeng@intel.com>, "Brian J . Johnson" <brian.johnson@hpe.com>
Subject: Re: [PATCH v3] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval
Thread-Topic: [PATCH v3] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP
 status check interval
Thread-Index: AQHWAlNHWMeFL9yMcUu2TmxF38CHHqhYp/sg
Date: Wed, 25 Mar 2020 03:35:57 +0000
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C4AFB97@SHSMSX104.ccr.corp.intel.com>
References: <20200325031244.8092-1-hao.a.wu@intel.com>
In-Reply-To: <20200325031244.8092-1-hao.a.wu@intel.com>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: ray.ni@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

> +  TriggerTime =3D EFI_TIMER_PERIOD_MICROSECONDS (
> +                  PcdGet32 (PcdCpuApStatusCheckIntervalInMicroSeconds)
> +                  );
>    Status =3D gBS->SetTimer (
>                    mCheckAllApsEvent,
>                    TimerPeriodic,
> -                  AP_CHECK_INTERVAL
> +                  TriggerTime
>                    );
>    ASSERT_EFI_ERROR (Status);
>=20
I guess you introduced TriggerTime for debugging purpose.
But in the final patch, how about removing this local variable TriggerTime?

Thanks,
Ray