From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.7829.1585300778695935487 for ; Fri, 27 Mar 2020 02:19:38 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ray.ni@intel.com) IronPort-SDR: 57cn6tpiu5xHSgs5FmxDT5QytCBlbAd1bJxql6P4emZi/9LzUhodiDIDqgW5G2qNf2g8hRqqUE ABxSe1RUNriQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2020 02:19:38 -0700 IronPort-SDR: /Gt1+kzHNsvv9NZ+3Qzumgv/D5LXIE3TBfQTAzCz012LUrWMcuXtjJgVChar2RsGN9rE7mhmo8 T6PrOqF4RRoA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,311,1580803200"; d="scan'208";a="236580003" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 27 Mar 2020 02:19:37 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 27 Mar 2020 02:19:37 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 27 Mar 2020 02:19:37 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.206]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.96]) with mapi id 14.03.0439.000; Fri, 27 Mar 2020 17:19:34 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Yao, Jiewen" , "Fu, Siyuan" , "Gao, Zhichao" CC: "Wang, Jian J" , "Lu, XiaoyuX" , Maciej Rabeda , "Wu, Jiaxin" Subject: Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function Thread-Topic: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function Thread-Index: AQHWA9r7tmdNqEM5z0qxVg7oxiimwKhbNjmAgAAC+gCAAAKGAIAAH1sAgAAMYQCAAAH3AIAAA6qAgAADboCAALeAQA== Date: Fri, 27 Mar 2020 09:19:33 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C4B8A18@SHSMSX104.ccr.corp.intel.com> References: <20200327015629.2588-1-zhichao.gao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F9A0490@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F9A08EF@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F9A0BBF@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F9A0CFC@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F9A0CFC@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, comments below. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewe= n > Sent: Friday, March 27, 2020 2:16 PM > To: Fu, Siyuan ; devel@edk2.groups.io; Gao, Zhichao = > Cc: Wang, Jian J ; Lu, XiaoyuX ; Maciej Rabeda > ; Wu, Jiaxin > Subject: Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate fun= ction >=20 > Library is static interface. Protocol is dynamic interface. That is key d= ifference. >=20 > My understanding for a *private protocol* is that: one module in the pack= age to produce. The other module in the same > packet to consume. Both are at runtime. That brings zero impact to other = module. If a module produces public Protocol_A and internally consumes private Prot= ocol_B, do you think that Protocol_B is private? I still think it's private= . The module is responsible to make sure Protocol_A behavior is not impacte= d by a internal change of Protocol_B. I didn't investigate the specific issue in detail. But in general, any change needs to consider the backward compatibility. An interface is ok to change when all modules that consume this interface a= re updated, no matter it's private or public. In this case, I think the library that calls the private protocol needs to = change. Through this way, each layer owns it's promise to its consumers. Thanks, Ray