From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.46025.1585558838359801513 for ; Mon, 30 Mar 2020 02:00:38 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) IronPort-SDR: YvrWvqufqFYU6ZrTdHWESwuWMp0E82r8BGwULQi3eXZRzo5eZTCIBqs15LJynV+FD//Nrj+u/t akkqEYEGdCCQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2020 02:00:37 -0700 IronPort-SDR: 8Hnj4lTYi5nImpmyeRSval62ho5eD3CJEOxpo3XNbei79ABaNLKnuPvVFTaiUiWOEM35mO/NUw /sLaGgLFtjfw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,323,1580803200"; d="scan'208";a="395061030" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 30 Mar 2020 02:00:37 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 30 Mar 2020 02:00:37 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 30 Mar 2020 02:00:36 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 30 Mar 2020 02:00:36 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.213]) with mapi id 14.03.0439.000; Mon, 30 Mar 2020 17:00:34 +0800 From: "Ni, Ray" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" , "Dong, Eric" Subject: Re: [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path Thread-Topic: [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path Thread-Index: AQHWBljpwmxq0IH8REOyFfJAZKMvr6hg1aoQ Date: Mon, 30 Mar 2020 09:00:34 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C4CA684@SHSMSX104.ccr.corp.intel.com> References: <20200330060306.1695-1-heng.luo@intel.com> <20200330060306.1695-2-heng.luo@intel.com> In-Reply-To: <20200330060306.1695-2-heng.luo@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > + # add all feature domains in WORKSPACE_FEATURES to package path > + for filename in os.listdir(config["WORKSPACE_FEATURES"]): > + filepath =3D os.path.join(config["WORKSPACE_FEATURES"], filename= ) > + if os.path.isdir(filepath): > + config["PACKAGES_PATH"] +=3D os.pathsep + filepath Will this change include "AdvancedFeaturePkg" and "TemplateFeaturePkg" fold= er as well? Can you please revise the patch to skip adding folders that contains packag= e contents to the PACKAGES_PATH? Liming, What's the criteria of a package? Can we treat a folder that contains ".dec= " and "dsc" files as a package directory? Thanks, Ray