From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Luo, Heng" <heng.luo@intel.com>
Cc: "Bi, Dandan" <dandan.bi@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Dong, Eric" <eric.dong@intel.com>
Subject: Re: [edk2-devel] [PATCH 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes
Date: Tue, 31 Mar 2020 01:28:41 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C4CD42B@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20200330060306.1695-4-heng.luo@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng Luo
> Sent: Monday, March 30, 2020 2:03 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray
> <ray.ni@intel.com>
> Subject: [edk2-devel] [PATCH 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644
>
> Correct wrong codes and remove unnecessary codes in LogoFeaturePkg.
>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Heng Luo <heng.luo@intel.com>
> ---
> Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 9 ---------
> Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf | 2 +-
> 2 files changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc
> b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc
> index fca0bfd540..d2dcdeb36a 100644
> --- a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc
> +++ b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc
> @@ -25,15 +25,6 @@
> !error "DXE_ARCH must be specified to build this feature!"
>
> !endif
>
>
>
> -################################################################################
>
> -#
>
> -# Packages Section - Make sure PCD can be directly used in a conditional statement
>
> -# in a DSC which includes this DSC file.
>
> -#
>
> -################################################################################
>
> -[Packages]
>
> - LogoFeaturePkg/LogoFeaturePkg.dec
>
> -
>
> ################################################################################
>
> #
>
> # Library Class section - list of all Library Classes needed by this feature.
>
> diff --git a/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf
> b/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf
> index 080c87223c..fead9f3b02 100644
> --- a/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf
> +++ b/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf
> @@ -6,7 +6,7 @@
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> -!if gSmbiosFeaturePkgTokenSpaceGuid.PcdJpgEnable == TRUE
>
> +!if gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable == TRUE
>
> INF LogoFeaturePkg/LogoDxe/JpegLogoDxe.inf
>
> !else
>
> INF LogoFeaturePkg/LogoDxe/LogoDxe.inf
>
> --
> 2.24.0.windows.2
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#56600): https://edk2.groups.io/g/devel/message/56600
> Mute This Topic: https://groups.io/mt/72646659/1712937
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com]
> -=-=-=-=-=-=
prev parent reply other threads:[~2020-03-31 1:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 6:03 [PATCH 0/3] Fix build error of OpenBoard Heng Luo
2020-03-30 6:03 ` [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path Heng Luo
2020-03-30 9:00 ` Ni, Ray
2020-03-31 1:25 ` Heng Luo
2020-03-31 2:48 ` Dong, Eric
2020-03-31 2:52 ` Liming Gao
2020-03-31 3:04 ` Heng Luo
2020-03-31 5:03 ` Ni, Ray
2020-03-31 5:38 ` Liming Gao
2020-03-30 6:03 ` [PATCH 2/3] Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround Heng Luo
2020-03-31 1:28 ` [edk2-devel] " Ni, Ray
2020-03-30 6:03 ` [PATCH 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes Heng Luo
2020-03-31 1:28 ` Ni, Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C4CD42B@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox