From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.668.1585618125063411395 for ; Mon, 30 Mar 2020 18:28:45 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) IronPort-SDR: qVBvb784PGwwxCnpHp+pKX8fdXAJpFmqQEdCt56kZnhBvTC4X1ZFxOsgcrpfqCFQgLrA3dZdxi UNOMeuQY853g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2020 18:28:44 -0700 IronPort-SDR: C0XEupPEKQe5Zf0//FgHVylKZKqj1zhQjHl0nwkEb801E/b5yCV8cH5rJMIv3jzCp5cll/GhAA qkj+MXS4mj/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,326,1580803200"; d="scan'208";a="272572120" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 30 Mar 2020 18:28:44 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 30 Mar 2020 18:28:44 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 30 Mar 2020 18:28:44 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.146]) with mapi id 14.03.0439.000; Tue, 31 Mar 2020 09:28:42 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Luo, Heng" CC: "Bi, Dandan" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes Thread-Topic: [edk2-devel] [PATCH 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes Thread-Index: AQHWBljxp05SB81h5Uy33LOKXW0x8qhh6oCg Date: Tue, 31 Mar 2020 01:28:41 +0000 Deferred-Delivery: Tue, 31 Mar 2020 01:28:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C4CD42B@SHSMSX104.ccr.corp.intel.com> References: <20200330060306.1695-1-heng.luo@intel.com> <20200330060306.1695-4-heng.luo@intel.com> In-Reply-To: <20200330060306.1695-4-heng.luo@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Heng Luo > Sent: Monday, March 30, 2020 2:03 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ;= Dong, Eric ; Ni, Ray > > Subject: [edk2-devel] [PATCH 3/3] Features/Intel: Correct wrong codes and= remove unnecessary codes >=20 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2644 >=20 > Correct wrong codes and remove unnecessary codes in LogoFeaturePkg. >=20 > Cc: Dandan Bi > Cc: Liming Gao > Cc: Eric Dong > Cc: Ray Ni > Signed-off-by: Heng Luo > --- > Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 9 = --------- > Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf | 2 = +- > 2 files changed, 1 insertion(+), 10 deletions(-) >=20 > diff --git a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeat= ure.dsc > b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc > index fca0bfd540..d2dcdeb36a 100644 > --- a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc > +++ b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc > @@ -25,15 +25,6 @@ > !error "DXE_ARCH must be specified to build this feature!" >=20 > !endif >=20 >=20 >=20 > -########################################################################= ######## >=20 > -# >=20 > -# Packages Section - Make sure PCD can be directly used in a conditional= statement >=20 > -# in a DSC which includes this DSC file. >=20 > -# >=20 > -########################################################################= ######## >=20 > -[Packages] >=20 > - LogoFeaturePkg/LogoFeaturePkg.dec >=20 > - >=20 > ########################################################################= ######## >=20 > # >=20 > # Library Class section - list of all Library Classes needed by this fea= ture. >=20 > diff --git a/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemo= ry.fdf > b/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf > index 080c87223c..fead9f3b02 100644 > --- a/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf > +++ b/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf > @@ -6,7 +6,7 @@ > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > -!if gSmbiosFeaturePkgTokenSpaceGuid.PcdJpgEnable =3D=3D TRUE >=20 > +!if gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable =3D=3D TRUE >=20 > INF LogoFeaturePkg/LogoDxe/JpegLogoDxe.inf >=20 > !else >=20 > INF LogoFeaturePkg/LogoDxe/LogoDxe.inf >=20 > -- > 2.24.0.windows.2 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#56600): https://edk2.groups.io/g/devel/message/56600 > Mute This Topic: https://groups.io/mt/72646659/1712937 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D