From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.839.1585721073157590049 for ; Tue, 31 Mar 2020 23:04:33 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com) IronPort-SDR: Pku/DhVwNYCFP1vTHeGXYbFS7B3wBqHyXwUfc8yvfeOaz4j3oh8hg18FTAe0qyi7MDoLFbmlC+ fRj2iA2/zMAw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2020 23:04:32 -0700 IronPort-SDR: viBYVdxIrJEOZhaPNu9ABzleeNpiMFNgVxOZ4AQus2ZR/19rPhYGrFyRFNaiVmzViJaNI0/n8G 4kKJhmyLe7LA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,330,1580803200"; d="scan'208";a="242132591" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 31 Mar 2020 23:04:32 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 31 Mar 2020 23:04:32 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 31 Mar 2020 23:04:32 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.214]) with mapi id 14.03.0439.000; Wed, 1 Apr 2020 14:04:29 +0800 From: "Ni, Ray" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" , "Dong, Eric" Subject: Re: [Patch V2 1/3] Platform/Intel: Add all pathes of feature domains to package path Thread-Topic: [Patch V2 1/3] Platform/Intel: Add all pathes of feature domains to package path Thread-Index: AQHWBw9nzIMVnw29ckiOzDF6zIaewKhjyHMQ Date: Wed, 1 Apr 2020 06:04:28 +0000 Deferred-Delivery: Wed, 1 Apr 2020 06:04:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C4D40AE@SHSMSX104.ccr.corp.intel.com> References: <20200331034913.1986-1-heng.luo@intel.com> <20200331034913.1986-2-heng.luo@intel.com> In-Reply-To: <20200331034913.1986-2-heng.luo@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Luo, Heng > Sent: Tuesday, March 31, 2020 11:49 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ;= Dong, Eric ; Ni, Ray > > Subject: [Patch V2 1/3] Platform/Intel: Add all pathes of feature domains= to package path >=20 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2644 >=20 > Add all pathes of feature domains to package path in build_bios.py. >=20 > Cc: Dandan Bi > Cc: Liming Gao > Cc: Eric Dong > Cc: Ray Ni > Signed-off-by: Heng Luo > --- >=20 > Notes: > v2: > - Skip adding folders that contains package contents to the PACKAGE= S_PATH. [Ray Ni] >=20 > Platform/Intel/build_bios.py | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py > index 1ef35aca0a..8f855f63eb 100644 > --- a/Platform/Intel/build_bios.py > +++ b/Platform/Intel/build_bios.py > @@ -3,7 +3,7 @@ > # Builds BIOS using configuration files and dynamically > # imported functions from board directory > # > -# Copyright (c) 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent > # >=20 > @@ -16,6 +16,7 @@ imported functions from board directory > import os > import re > import sys > +import glob > import signal > import shutil > import argparse > @@ -120,6 +121,13 @@ def pre_build(build_config, build_type=3D"DEBUG", si= lent=3DFalse, toolchain=3DNone): > config["PACKAGES_PATH"] +=3D os.pathsep + config["WORKSPACE_SILICON"= ] > config["PACKAGES_PATH"] +=3D os.pathsep + config["WORKSPACE_SILICON_= BIN"] > config["PACKAGES_PATH"] +=3D os.pathsep + config["WORKSPACE_FEATURES= "] > + # add all feature domains in WORKSPACE_FEATURES to package path > + for filename in os.listdir(config["WORKSPACE_FEATURES"]): > + filepath =3D os.path.join(config["WORKSPACE_FEATURES"], filename= ) > + # feature domains folder does not contain dec file > + if os.path.isdir(filepath) and \ > + not glob.glob(os.path.join(filepath, "*.dec")): > + config["PACKAGES_PATH"] +=3D os.pathsep + filepath > config["PACKAGES_PATH"] +=3D os.pathsep + config["WORKSPACE_DRIVERS"= ] > config["PACKAGES_PATH"] +=3D os.pathsep + \ > os.path.join(config["WORKSPACE"], "FSP") > -- > 2.24.0.windows.2