From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Dong, Eric" <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>,
"Kumar, Chandana C" <chandana.c.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/MpInitLib: Avoid ApInitReconfig in PEI.
Date: Wed, 22 Apr 2020 08:00:15 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C508172@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20200422013456.1053-3-eric.dong@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com> with a bit comments update:
"Current been used wake up buffer is allocated in PEI phase and no long valid at this time."
->
"Wakeup buffer allocated in PEI phase is no longer valid in DXE."
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dong,
> Eric
> Sent: Wednesday, April 22, 2020 9:35 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kumar,
> Chandana C <chandana.c.kumar@intel.com>
> Subject: [edk2-devel] [PATCH 2/2] UefiCpuPkg/MpInitLib: Avoid
> ApInitReconfig in PEI.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683
>
>
> In PEI phase, AP already been waked up through ApInitConfig,
> so it can directly wake up it through change wakup buffer
> instead of use ApInitReconfig flag. It can save some time.
>
> Change code to only use ApInitReconfig flag in DXE phase
> which must need to update the wake up buffer.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Chandana Kumar <chandana.c.kumar@intel.com>
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> index ac7f92fd48..644971b68f 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> @@ -1819,7 +1819,14 @@ MpInitLibInitialize (
> // Wakeup APs to do some AP initialize sync (Microcode & MTRR)
>
> //
>
> if (CpuMpData->CpuCount > 1) {
>
> - CpuMpData->InitFlag = ApInitReconfig;
>
> + if (OldCpuMpData != NULL) {
>
> + //
>
> + // Only needs to use this flag for DXE phase to update the wake up
>
> + // buffer. Current been used wake up buffer is allocated in PEI phase
>
> + // and no long valid at this time.
>
> + //
>
> + CpuMpData->InitFlag = ApInitReconfig;
>
> + }
>
> WakeUpAP (CpuMpData, TRUE, 0, ApInitializeSync, CpuMpData, TRUE);
>
> //
>
> // Wait for all APs finished initialization
>
> @@ -1827,7 +1834,9 @@ MpInitLibInitialize (
> while (CpuMpData->FinishedCount < (CpuMpData->CpuCount - 1)) {
>
> CpuPause ();
>
> }
>
> - CpuMpData->InitFlag = ApInitDone;
>
> + if (OldCpuMpData != NULL) {
>
> + CpuMpData->InitFlag = ApInitDone;
>
> + }
>
> for (Index = 0; Index < CpuMpData->CpuCount; Index++) {
>
> SetApState (&CpuMpData->CpuData[Index], CpuStateIdle);
>
> }
>
> --
> 2.23.0.windows.1
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#57774): https://edk2.groups.io/g/devel/message/57774
> Mute This Topic: https://groups.io/mt/73187417/1712937
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com]
> -=-=-=-=-=-=
prev parent reply other threads:[~2020-04-22 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 1:34 [PATCH 0/2] UefiCpuPkg/MpInitLib: Fix ASSERT in AP procedure Dong, Eric
2020-04-22 1:34 ` [PATCH 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs Dong, Eric
2020-04-22 7:54 ` Ni, Ray
2020-04-22 8:22 ` Dong, Eric
2020-04-22 11:26 ` Ni, Ray
[not found] ` <160816A4F32AAED9.20374@groups.io>
2020-04-22 9:00 ` [edk2-devel] " Dong, Eric
2020-04-22 1:34 ` [PATCH 2/2] UefiCpuPkg/MpInitLib: Avoid ApInitReconfig in PEI Dong, Eric
2020-04-22 8:00 ` Ni, Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C508172@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox