From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.2414.1587543026543290723 for ; Wed, 22 Apr 2020 01:10:26 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) IronPort-SDR: iu9MARA7zXJzaoJjp+pgh80bEdtHOjrhE4zJRzJs75r0f+ynTGODZKvNGT7UiugUnE9jWIs+73 wYmkoRecsX3Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2020 01:10:26 -0700 IronPort-SDR: nZ9Y903EFcmsxSAfx1SaddoVuXl8ULAzrQFj5AIUG9KZKMSxKEUeEX1h+3UBcR9er0WzbGwWzL aTmT9EFwvt6A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,412,1580803200"; d="scan'208";a="365609830" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 22 Apr 2020 01:10:26 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Apr 2020 01:10:25 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 22 Apr 2020 01:10:25 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 22 Apr 2020 01:10:25 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.89]) with mapi id 14.03.0439.000; Wed, 22 Apr 2020 16:10:23 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Wu, Hao A" CC: "Dong, Eric" , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency Thread-Topic: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency Thread-Index: AQHWGHMVYsug8HiaD0uRvwHgnVZ+4KiEyZPw Date: Wed, 22 Apr 2020 08:10:22 +0000 Deferred-Delivery: Wed, 22 Apr 2020 08:09:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C5081FA@SHSMSX104.ccr.corp.intel.com> References: <20200422065549.10880-1-hao.a.wu@intel.com> In-Reply-To: <20200422065549.10880-1-hao.a.wu@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Wednesday, April 22, 2020 2:56 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Dong, Eric ; Ni= , > Ray ; Laszlo Ersek > Subject: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add missing expli= cit > PcdLib dependency >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2632 >=20 > Both PEI and DXE instances of the MpInitLib are using PcdLib APIs, but > none of them list the dependency of the PcdLib in INF & header files. >=20 > This commit will explicitly add such dependency in .H and .INF files. >=20 > Test done: > Library level build pass for VS2015x86 tool chain >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Hao A Wu > --- > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 1 + > UefiCpuPkg/Library/MpInitLib/MpLib.h | 1 + > 3 files changed, 3 insertions(+) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > index a51a9ec1d2..9907f4157b 100644 > --- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > @@ -51,6 +51,7 @@ [LibraryClasses] > UefiBootServicesTableLib > DebugAgentLib > SynchronizationLib > + PcdLib >=20 > [Protocols] > gEfiTimerArchProtocolGuid ## SOMETIMES_CONSUMES > diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > index d78d328b42..89ee9a79d8 100644 > --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > @@ -50,6 +50,7 @@ [LibraryClasses] > UefiCpuLib > SynchronizationLib > PeiServicesLib > + PcdLib >=20 > [Pcd] > gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ## > CONSUMES > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h > b/UefiCpuPkg/Library/MpInitLib/MpLib.h > index 74e919dae0..a8ca03efb8 100755 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include >=20 > #include >=20 > -- > 2.12.0.windows.1 >=20 >=20 >=20