public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: Wasim Khan <wasim.khan@nxp.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
	Varun Sethi <V.Sethi@nxp.com>, "Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks
Date: Thu, 23 Apr 2020 15:17:23 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C50B156@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <VE1PR04MB6702FCADCF1E1317BA3D576D90D30@VE1PR04MB6702.eurprd04.prod.outlook.com>



> -----Original Message-----
> From: Wasim Khan <wasim.khan@nxp.com>
> Sent: Thursday, April 23, 2020 10:54 PM
> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
> Cc: ard.biesheuvel@linaro.org; Varun Sethi <V.Sethi@nxp.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks
> > > >
> > > > Thanks for fixing the check.
> > > >
> > > > PCI_ROOT_BRIDGE_APERTURE.Base/Limit are device address while the
> > > > memory space in GCD belongs to host domain.
> > > > So, host address for Mem/Pmem should be below 4GB while device
> > > > address can across 4GB.
> > > >
> > >
> > >
> > > Hi Ray,
> > > Thank you for the review.
> > > There are cases when we don't have PCIe host address below 4GB, and
> > > the PCIe HOST Address space is only available above 4GB.
> > > For Example, Mem: 40000000 - FFFFFFFF Translation=FFFFFF6000000000
> > > will result in HOST Address = 0xA0FFFFFFFF . This is a valid use case, but below
> > check will report ASSERT for this HOST ADDRESS.
> >
> > OK. Now I remember that "Mem" reports the 32bit memory space (device
> > address) and "MemAbove4GB" reports the 64bit memory space (device address).
> >
> > Then if "Mem" reports memory range that across 4GB, it means the range above
> > 4GB should be reported through "MemAbove4GB".
> >
> Yes this is true, but some devices needs MMIO 32bit space only as per their BAR property, including E1000 EP.

I understand some devices contain only 32bit MMIO BAR so only 32bit memory space (device address) can be assigned to them.
Can you tell me the value of Mem/MemAbove4GB/Pmem/PmemAbove4GB in your real case?
Can you also tell me the PCI(e) device BAR information you want to initialize through the EDKII PCI stack?


  reply	other threads:[~2020-04-23 15:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 10:43 [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks Wasim Khan
2020-04-23 11:36 ` Ni, Ray
2020-04-23 13:52   ` Wasim Khan
2020-04-23 14:28     ` [edk2-devel] " Ni, Ray
2020-04-23 14:53       ` Wasim Khan
2020-04-23 15:17         ` Ni, Ray [this message]
2020-04-23 16:04           ` Wasim Khan
2020-04-23 18:56 ` Ard Biesheuvel
2020-04-24  4:35   ` Wasim Khan
2020-04-24  6:07     ` [edk2-devel] " Ard Biesheuvel
2020-04-24  7:32       ` Wasim Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C50B156@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox