From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.6382.1587876792336093276 for ; Sat, 25 Apr 2020 21:53:12 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) IronPort-SDR: 4SJSL4Bl5j7glDgeQ4fHy9FE9h0DJw7oYVcgdToAXKzY1Q/mBXQTd2iCk1bGMUc9AEocmp5O1y oPqz0EWvy3DA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2020 21:53:11 -0700 IronPort-SDR: 4c5+P9BpIjbz8gkccxqU6ofccE0pyfLUTnlZs5DvUCYpZeN7duDfFHHTL0EJHf3Q1nN1BEJuEd RCz3bLcNq7jg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,318,1583222400"; d="scan'208";a="260305253" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 25 Apr 2020 21:53:11 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 25 Apr 2020 21:53:11 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sat, 25 Apr 2020 21:53:10 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sat, 25 Apr 2020 21:53:10 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.191]) with mapi id 14.03.0439.000; Sun, 26 Apr 2020 12:53:08 +0800 From: "Ni, Ray" To: "Dong, Eric" , "devel@edk2.groups.io" CC: 'Laszlo Ersek' , "Kumar, Chandana C" Subject: Re: [PATCH v3 0/2] UefiCpuPkg/MpInitLib: Fix ASSERT in AP procedure Thread-Topic: [PATCH v3 0/2] UefiCpuPkg/MpInitLib: Fix ASSERT in AP procedure Thread-Index: AQHWGhT9bKaUtbdRMUWwowzqUwqaiqiKxcLQgAATHPA= Date: Sun, 26 Apr 2020 04:53:08 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C510413@SHSMSX104.ccr.corp.intel.com> References: <20200424084716.877-1-eric.dong@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C510262@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C510262@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Send to correct mail address: devel@edk2.groups.io > -----Original Message----- > From: Ni, Ray > Sent: Sunday, April 26, 2020 11:46 AM > To: Dong, Eric ; =16devel@edk2.groups.io > Cc: Laszlo Ersek ; Kumar, Chandana C > Subject: RE: [PATCH v3 0/2] UefiCpuPkg/MpInitLib: Fix ASSERT in AP proced= ure >=20 > Reviewed-by: Ray Ni >=20 > > -----Original Message----- > > From: Dong, Eric > > Sent: Friday, April 24, 2020 4:47 PM > > To: =16devel@edk2.groups.io > > Cc: Ni, Ray ; Laszlo Ersek ; Kumar= , > > Chandana C > > Subject: [PATCH v3 0/2] UefiCpuPkg/MpInitLib: Fix ASSERT in AP procedur= e > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2683 > > > > > > > > This patch serial used to fix an ASSERT issue. Because AP can't find > > > > the CpuMpData through IDT, it raised the ASSERT. > > > > > > > > V3: > > > > 1. Remove invalid save Volatile Registers process. Refine restore > > > > Volatile Registers process. > > > > > > > > V2: > > > > 1. Enhance code comments. > > > > 2. Enhance code to remove CpuMpData->ApLoopMode =3D=3D ApInHltLoop > > check. > > > > > > > > Cc: Ray Ni > > > > Cc: Laszlo Ersek > > > > Cc: Chandana Kumar > > > > > > > > Eric Dong (2): > > UefiCpuPkg/MpInitLib: Restore IDT context for APs. > > UefiCpuPkg/MpInitLib: Avoid ApInitReconfig in PEI. > > > > UefiCpuPkg/Library/MpInitLib/MpLib.c | 47 ++++++++++++++++++++-------- > > 1 file changed, 34 insertions(+), 13 deletions(-) > > > > -- > > 2.23.0.windows.1