From: "Ni, Ray" <ray.ni@intel.com>
To: "Shindo, Miki" <miki.shindo@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
"Chiu, Chasel" <chasel.chiu@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [edk2-platforms:PATCH v4 0/7] IntelSiliconPkg DxeAslUpdateLib support
Date: Thu, 30 Apr 2020 08:14:42 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C515C67@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20200429023203.37544-1-miki.shindo@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Shindo, Miki <miki.shindo@intel.com>
> Sent: Wednesday, April 29, 2020 10:32 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Agyeman, Prince <prince.agyeman@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-platforms:PATCH v4 0/7] IntelSiliconPkg DxeAslUpdateLib support
>
> Patch 7/7 of this series adds DxeAslUpdateLib support in IntelSiliconPkg
> so each project can consume it.
> As the existing DxeAslUpdateLib in SiliconPkg have different header files,
> this series of patches resolve the inconsistency and avoid build failure.
> Also some of unreferenced contents are cleaned up.
>
>
> Signed-off-by: Miki Shindo <miki.shindo@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Acked-by: Chasel Chiu <chasel.chiu@intel.com>
> Acked-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
>
>
> Miki Shindo (7):
> WhiskeylakeOpenBoardPkg/TbtDxe: Removes redundant
> InitializeAslUpdateLib
> KabylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib
> CometlakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib
> MinPlatformPkg/DxeAslUpdateLib: Cleans up APIs
> KabylakeSiliconPkg/DxeAslUpdateLib: Cleans up APIs
> CoffeelakeSiliconPkg/DxeAslUpdateLib: Cleans up APIs
> IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support
>
> Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c | 3 ---
> Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c | 5 +----
> Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.c | 209
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++------------------------------------------------------------------------------------------------------
> Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c | 5 +----
> Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c | 190
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------
> -----------------------------------------------------------------------------
> Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c | 94
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------
> Silicon/Intel/CoffeelakeSiliconPkg/Pch/PchInit/Dxe/PchAcpi.c | 3 ---
> Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c | 518
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++
> Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c | 207
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++------------------------------------------------------------------------------------------------------
> Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c | 94
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------
> Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Dxe/PchAcpi.c | 5 +----
> Platform/Intel/MinPlatformPkg/Include/Library/AslUpdateLib.h | 131
> ++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------
> Silicon/Intel/CoffeelakeSiliconPkg/Include/Library/AslUpdateLib.h | 114
> +++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------
> Silicon/Intel/IntelSiliconPkg/Include/Library/AslUpdateLib.h | 116
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++
> Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 4 ++++
> Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf | 42
> ++++++++++++++++++++++++++++++++++++++++++
> Silicon/Intel/KabylakeSiliconPkg/Include/Library/AslUpdateLib.h | 130
> ++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------------------------
> 17 files changed, 1238 insertions(+), 632 deletions(-)
> create mode 100644 Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
> create mode 100644 Silicon/Intel/IntelSiliconPkg/Include/Library/AslUpdateLib.h
> create mode 100644 Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf
>
> --
> 2.16.2.windows.1
prev parent reply other threads:[~2020-04-30 8:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 2:31 [edk2-platforms:PATCH v4 0/7] IntelSiliconPkg DxeAslUpdateLib support Miki Shindo
2020-04-29 2:31 ` [edk2-platforms:PATCH v4 1/7] WhiskeylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Miki Shindo
2020-04-30 1:40 ` Chaganty, Rangasai V
2020-04-30 2:54 ` Chiu, Chasel
2020-04-29 2:31 ` [edk2-platforms:PATCH v4 2/7] KabylakeOpenBoardPkg/TbtDxe: " Miki Shindo
2020-04-30 1:47 ` Chaganty, Rangasai V
2020-04-30 2:55 ` Chiu, Chasel
2020-04-29 2:31 ` [edk2-platforms:PATCH v4 3/7] CometlakeOpenBoardPkg/TbtDxe: " Miki Shindo
2020-04-30 1:53 ` Chaganty, Rangasai V
2020-04-30 2:55 ` Chiu, Chasel
2020-04-29 2:32 ` [edk2-platforms:PATCH v4 4/7] MinPlatformPkg/DxeAslUpdateLib: Cleans up APIs Miki Shindo
2020-04-30 2:56 ` Chiu, Chasel
2020-04-30 5:00 ` Chaganty, Rangasai V
2020-04-29 2:32 ` [edk2-platforms:PATCH v4 5/7] KabylakeSiliconPkg/DxeAslUpdateLib: " Miki Shindo
2020-04-30 2:56 ` Chiu, Chasel
2020-04-30 5:02 ` Chaganty, Rangasai V
2020-04-29 2:32 ` [edk2-platforms:PATCH v4 6/7] CoffeelakeSiliconPkg/DxeAslUpdateLib: " Miki Shindo
2020-04-30 2:57 ` Chiu, Chasel
2020-04-30 5:03 ` Chaganty, Rangasai V
2020-04-29 2:32 ` [edk2-platforms:PATCH v4 7/7] IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support Miki Shindo
2020-04-30 2:57 ` Chiu, Chasel
2020-04-30 5:13 ` Chaganty, Rangasai V
2020-04-30 8:14 ` Ni, Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C515C67@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox