From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.3103.1588234488310262742 for ; Thu, 30 Apr 2020 01:14:48 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ray.ni@intel.com) IronPort-SDR: FqGOYRk/jSpLTea5mwXbsx8SbIBMHeI8/6Dx9Bz7LI4KQH+5udVpd2A7EO6hpz2b9/dZownpjm nbGjqxjfgXGQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 01:14:46 -0700 IronPort-SDR: zhiqM60rY2YqSNQmb7FyJrnHaOX7kz8dHnAX+DtwQGJYnN496tfTbFX57VMlm71xOgNL9M1k8y Sg/y6wChAm+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,334,1583222400"; d="scan'208";a="459853304" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 30 Apr 2020 01:14:46 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Apr 2020 01:14:46 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Apr 2020 01:14:46 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.214]) with mapi id 14.03.0439.000; Thu, 30 Apr 2020 16:14:43 +0800 From: "Ni, Ray" To: "Shindo, Miki" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Chiu, Chasel" , "Desimone, Nathaniel L" , "Agyeman, Prince" Subject: Re: [edk2-platforms:PATCH v4 0/7] IntelSiliconPkg DxeAslUpdateLib support Thread-Topic: [edk2-platforms:PATCH v4 0/7] IntelSiliconPkg DxeAslUpdateLib support Thread-Index: AQHWHc5r3mtDWkETsEOhFpj+UpNGEaiRUscg Date: Thu, 30 Apr 2020 08:14:42 +0000 Deferred-Delivery: Thu, 30 Apr 2020 08:14:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C515C67@SHSMSX104.ccr.corp.intel.com> References: <20200429023203.37544-1-miki.shindo@intel.com> In-Reply-To: <20200429023203.37544-1-miki.shindo@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Shindo, Miki > Sent: Wednesday, April 29, 2020 10:32 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L > ; Agyeman, Prince ; Ni, Ray > Subject: [edk2-platforms:PATCH v4 0/7] IntelSiliconPkg DxeAslUpdateLib su= pport >=20 > Patch 7/7 of this series adds DxeAslUpdateLib support in IntelSiliconPkg > so each project can consume it. > As the existing DxeAslUpdateLib in SiliconPkg have different header files= , > this series of patches resolve the inconsistency and avoid build failure. > Also some of unreferenced contents are cleaned up. >=20 >=20 > Signed-off-by: Miki Shindo > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Prince Agyeman > Cc: Ray Ni > Acked-by: Chasel Chiu > Acked-by: Nate DeSimone >=20 >=20 > Miki Shindo (7): > WhiskeylakeOpenBoardPkg/TbtDxe: Removes redundant > InitializeAslUpdateLib > KabylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib > CometlakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib > MinPlatformPkg/DxeAslUpdateLib: Cleans up APIs > KabylakeSiliconPkg/DxeAslUpdateLib: Cleans up APIs > CoffeelakeSiliconPkg/DxeAslUpdateLib: Cleans up APIs > IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support >=20 > Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c = | 3 --- > Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c = | 5 +---- > Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateL= ib.c | 209 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++ > ++++---------------------------------------------------------------------= --------------------------------- > Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c= | 5 +---- > Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateL= ib.c | 190 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++-------------------------- > -------------------------------------------------------------------------= ---- > Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpd= ateLibNull.c | 94 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------= --------------------- > Silicon/Intel/CoffeelakeSiliconPkg/Pch/PchInit/Dxe/PchAcpi.c = | 3 --- > Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c = | 518 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++ > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++ > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++ > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++ > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++ > +++ > Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib= .c | 207 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++ > ++-----------------------------------------------------------------------= ------------------------------- > Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdat= eLibNull.c | 94 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------= --------------------- > Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Dxe/PchAcpi.c = | 5 +---- > Platform/Intel/MinPlatformPkg/Include/Library/AslUpdateLib.h = | 131 > ++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------= ---------------------------------------------------------- > Silicon/Intel/CoffeelakeSiliconPkg/Include/Library/AslUpdateLib.h = | 114 > +++++++++++++++++++++++++++++++++++--------------------------------------= ----------------------------------------- > Silicon/Intel/IntelSiliconPkg/Include/Library/AslUpdateLib.h = | 116 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++ > +++++++++++++ > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec = | 4 ++++ > Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.in= f | 42 > ++++++++++++++++++++++++++++++++++++++++++ > Silicon/Intel/KabylakeSiliconPkg/Include/Library/AslUpdateLib.h = | 130 > ++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------= --------------------------------------------------------- > 17 files changed, 1238 insertions(+), 632 deletions(-) > create mode 100644 Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib= /DxeAslUpdateLib.c > create mode 100644 Silicon/Intel/IntelSiliconPkg/Include/Library/AslUpda= teLib.h > create mode 100644 Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib= /DxeAslUpdateLib.inf >=20 > -- > 2.16.2.windows.1