From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.3167.1588988862058520038 for ; Fri, 08 May 2020 18:47:42 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) IronPort-SDR: B1GqNz5Txj2y8tIp58zz05lS6MBjiZzedNQxoGle7n6JIlXWb/R6PNRR1fmFEVV5wmiXoVfc+5 84EXiumqF2CQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 18:47:43 -0700 IronPort-SDR: finZGOZFkgVpumeVs5btGxFgRTn0XVtrn2BHMFgj4b8gWyVD36YbB8LNvC46yId7Q/oe2OXf3N xXjEydtGWhIw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,369,1583222400"; d="scan'208";a="462493577" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 08 May 2020 18:47:41 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 18:47:41 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 18:47:40 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.210]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.225]) with mapi id 14.03.0439.000; Sat, 9 May 2020 09:47:37 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Jiang, Guomin" CC: GuoMinJ , "Feng, Bob C" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 01/18] BaseTools: Remove All UGA Support Thread-Topic: [edk2-devel] [PATCH 01/18] BaseTools: Remove All UGA Support Thread-Index: AQHWJRQTbkUOczVTvUCT8RhTT+n8z6ie/WHA Date: Sat, 9 May 2020 01:47:37 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C53090A@SHSMSX104.ccr.corp.intel.com> References: <20200508083824.1785-1-guomin.jiang@intel.com> <20200508083824.1785-2-guomin.jiang@intel.com> In-Reply-To: <20200508083824.1785-2-guomin.jiang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Guomin, Can you complete remove HiiFramework.h? > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Guomin Ji= ang > Sent: Friday, May 8, 2020 4:38 PM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Feng, Bob C = ; Gao, Liming > Subject: [edk2-devel] [PATCH 01/18] BaseTools: Remove All UGA Support >=20 > From: GuoMinJ >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2368 >=20 > Remove all UGA support in BaseTools package. >=20 > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Guomin Jiang > --- > .../Source/C/Include/Protocol/HiiFramework.h | 51 ------ > BaseTools/Source/C/Include/Protocol/UgaDraw.h | 161 ------------------ > 2 files changed, 212 deletions(-) > delete mode 100644 BaseTools/Source/C/Include/Protocol/UgaDraw.h >=20 > diff --git a/BaseTools/Source/C/Include/Protocol/HiiFramework.h b/BaseTo= ols/Source/C/Include/Protocol/HiiFramework.h > index 448350967bbf..09cbf23640c1 100644 > --- a/BaseTools/Source/C/Include/Protocol/HiiFramework.h > +++ b/BaseTools/Source/C/Include/Protocol/HiiFramework.h > @@ -28,20 +28,6 @@ > 0xd7ad636e, 0xb997, 0x459b, {0xbf, 0x3f, 0x88, 0x46, 0x89, 0x79, 0x= 80, 0xe1} \ > } >=20 > -// BugBug: > -//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++ > -// If UGA goes away we need to put this some place. I'm not sure where? > -// > -//typedef struct { > -// UINT8 Blue; > -// UINT8 Green; > -// UINT8 Red; > -// UINT8 Reserved; > -//} EFI_UGA_PIXEL; > - > -//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++ > -// > - > typedef struct _EFI_HII_PROTOCOL EFI_HII_PROTOCOL; >=20 > // > @@ -575,39 +561,6 @@ EFI_STATUS > IN OUT UINT32 *InternalStatus > ); >=20 > -/** > - Translates a glyph into the format required for input to the Universa= l > - Graphics Adapter (UGA) Block Transfer (BLT) routines. > - > - @param This A pointer to the EFI_HII_PROTOCOL insta= nce. > - @param GlyphBuffer A pointer to the buffer that contains g= lyph data. > - @param Foreground The foreground setting requested to be = used for the > - generated BltBuffer data. > - @param Background The background setting requested to be = used for the > - generated BltBuffer data. > - @param Count The entry in the BltBuffer upon which t= o act. > - @param Width The width in bits of the glyph being co= nverted. > - @param Height The height in bits of the glyph being c= onverted > - @param BltBuffer A pointer to the buffer that contains t= he data that is > - ready to be used by the UGA BLT routine= s. > - > - @retval EFI_SUCCESS It worked. > - @retval EFI_NOT_FOUND A glyph for a character was not found. > - > -**/ > -typedef > -EFI_STATUS > -(EFIAPI *EFI_HII_GLYPH_TO_BLT) ( > - IN EFI_HII_PROTOCOL *This, > - IN UINT8 *GlyphBuffer, > - IN EFI_GRAPHICS_OUTPUT_BLT_PIXEL Foreground, > - IN EFI_GRAPHICS_OUTPUT_BLT_PIXEL Background, > - IN UINTN Count, > - IN UINTN Width, > - IN UINTN Height, > - IN OUT EFI_GRAPHICS_OUTPUT_BLT_PIXEL *BltBuffer > - ); > - > /** > Allows a new string to be added to an already existing string package= . >=20 > @@ -878,9 +831,6 @@ EFI_STATUS > @param GetGlyph > Translates a Unicode character into the corresponding font glyph. >=20 > - @param GlyphToBlt > - Converts a glyph value into a format that is ready for a UGA BLT comm= and. > - > @param NewString > Allows a new string to be added to an already existing string package= . >=20 > @@ -924,7 +874,6 @@ struct _EFI_HII_PROTOCOL { >=20 > EFI_HII_TEST_STRING TestString; > EFI_HII_GET_GLYPH GetGlyph; > - EFI_HII_GLYPH_TO_BLT GlyphToBlt; >=20 > EFI_HII_NEW_STRING NewString; > EFI_HII_GET_PRI_LANGUAGES GetPrimaryLanguages; > diff --git a/BaseTools/Source/C/Include/Protocol/UgaDraw.h b/BaseTools/S= ource/C/Include/Protocol/UgaDraw.h > deleted file mode 100644 > index 412b000aeb6b..000000000000 > --- a/BaseTools/Source/C/Include/Protocol/UgaDraw.h > +++ /dev/null > @@ -1,161 +0,0 @@ > -/** @file > - UGA Draw protocol from the EFI 1.1 specification. > - > - Abstraction of a very simple graphics device. > - > - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved. > - > - SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef __UGA_DRAW_H__ > -#define __UGA_DRAW_H__ > - > -#define EFI_UGA_DRAW_PROTOCOL_GUID \ > - { \ > - 0x982c298b, 0xf4fa, 0x41cb, {0xb8, 0x38, 0x77, 0xaa, 0x68, 0x8f, 0x= b8, 0x39 } \ > - } > - > -typedef struct _EFI_UGA_DRAW_PROTOCOL EFI_UGA_DRAW_PROTOCOL; > - > -/** > - Return the current video mode information. > - > - @param This Protocol instance pointer. > - @param HorizontalResolution Current video horizontal resolution in = pixels > - @param VerticalResolution Current video vertical resolution in pi= xels > - @param ColorDepth Current video color depth in bits per p= ixel > - @param RefreshRate Current video refresh rate in Hz. > - > - @retval EFI_SUCCESS Mode information returned. > - @retval EFI_NOT_STARTED Video display is not initialized. Call = SetMode () > - @retval EFI_INVALID_PARAMETER One of the input args was NULL. > - > -**/ > -typedef > -EFI_STATUS > -(EFIAPI *EFI_UGA_DRAW_PROTOCOL_GET_MODE) ( > - IN EFI_UGA_DRAW_PROTOCOL *This, > - OUT UINT32 *HorizontalResolution, > - OUT UINT32 *VerticalResolution, > - OUT UINT32 *ColorDepth, > - OUT UINT32 *RefreshRate > - ) > -; > - > -/** > - Return the current video mode information. > - > - @param This Protocol instance pointer. > - @param HorizontalResolution Current video horizontal resolution in p= ixels > - @param VerticalResolution Current video vertical resolution in pix= els > - @param ColorDepth Current video color depth in bits per pi= xel > - @param RefreshRate Current video refresh rate in Hz. > - > - @retval EFI_SUCCESS Mode information returned. > - @retval EFI_NOT_STARTED Video display is not initialized. Call S= etMode () > - > -**/ > -typedef > -EFI_STATUS > -(EFIAPI *EFI_UGA_DRAW_PROTOCOL_SET_MODE) ( > - IN EFI_UGA_DRAW_PROTOCOL *This, > - IN UINT32 HorizontalResolution, > - IN UINT32 VerticalResolution, > - IN UINT32 ColorDepth, > - IN UINT32 RefreshRate > - ) > -; > - > -typedef struct { > - UINT8 Blue; > - UINT8 Green; > - UINT8 Red; > - UINT8 Reserved; > -} EFI_UGA_PIXEL; > - > -typedef union { > - EFI_UGA_PIXEL Pixel; > - UINT32 Raw; > -} EFI_UGA_PIXEL_UNION; > - > -typedef enum { > - EfiUgaVideoFill, > - EfiUgaVideoToBltBuffer, > - EfiUgaBltBufferToVideo, > - EfiUgaVideoToVideo, > - EfiUgaBltMax > -} EFI_UGA_BLT_OPERATION; > - > -/** > - Type specifying a pointer to a function to perform an UGA Blt operati= on. > - > - The following table defines actions for BltOperations: > - > - EfiUgaVideoFill - Write data from the BltBuffer pixel (Sour= ceX, SourceY) > - directly to every pixel of the video display rectangle > - (DestinationX, DestinationY) (DestinationX + Width, DestinationY = + Height). > - Only one pixel will be used from the BltBuffer. Delta is NOT used= . > - > - EfiUgaVideoToBltBuffer - Read data from the video display re= ctangle > - (SourceX, SourceY) (SourceX + Width, SourceY + Height) and place = it in > - the BltBuffer rectangle (DestinationX, DestinationY ) > - (DestinationX + Width, DestinationY + Height). If DestinationX or > - DestinationY is not zero then Delta must be set to the length in = bytes > - of a row in the BltBuffer. > - > - EfiUgaBltBufferToVideo - Write data from the BltBuffer rect= angle > - (SourceX, SourceY) (SourceX + Width, SourceY + Height) directly t= o the > - video display rectangle (DestinationX, DestinationY) > - (DestinationX + Width, DestinationY + Height). If SourceX or Sour= ceY is > - not zero then Delta must be set to the length in bytes of a row i= n the > - BltBuffer. > - > - EfiUgaVideoToVideo - Copy from the video display rectangle (= SourceX, SourceY) > - (SourceX + Width, SourceY + Height) .to the video display rectangl= e > - (DestinationX, DestinationY) (DestinationX + Width, DestinationY += Height). > - The BltBuffer and Delta are not used in this mode. > - > - > - @param[in] This - Protocol instance pointer. > - @param[in] BltBuffer - Buffer containing data to blit into vide= o buffer. This > - buffer has a size of Width*Height*sizeof= (EFI_UGA_PIXEL) > - @param[in] BltOperation - Operation to perform on BlitBuffer and v= ideo memory > - @param[in] SourceX - X coordinate of source for the BltBuffer= . > - @param[in] SourceY - Y coordinate of source for the BltBuffer= . > - @param[in] DestinationX - X coordinate of destination for the BltB= uffer. > - @param[in] DestinationY - Y coordinate of destination for the BltB= uffer. > - @param[in] Width - Width of rectangle in BltBuffer in pixel= s. > - @param[in] Height - Height of rectangle in BltBuffer in pixe= ls. > - @param[in] Delta - OPTIONAL > - > - @retval EFI_SUCCESS - The Blt operation completed. > - @retval EFI_INVALID_PARAMETER - BltOperation is not valid. > - @retval EFI_DEVICE_ERROR - A hardware error occurred writing t= o the video buffer. > - > ---*/ > -typedef > -EFI_STATUS > -(EFIAPI *EFI_UGA_DRAW_PROTOCOL_BLT) ( > - IN EFI_UGA_DRAW_PROTOCOL * This, > - IN EFI_UGA_PIXEL * BltBuffer, OPTIONAL > - IN EFI_UGA_BLT_OPERATION BltOperation, > - IN UINTN SourceX, > - IN UINTN SourceY, > - IN UINTN DestinationX, > - IN UINTN DestinationY, > - IN UINTN Width, > - IN UINTN Height, > - IN UINTN Delta OPTIONAL > - ); > - > -struct _EFI_UGA_DRAW_PROTOCOL { > - EFI_UGA_DRAW_PROTOCOL_GET_MODE GetMode; > - EFI_UGA_DRAW_PROTOCOL_SET_MODE SetMode; > - EFI_UGA_DRAW_PROTOCOL_BLT Blt; > -}; > - > -extern EFI_GUID gEfiUgaDrawProtocolGuid; > - > -#endif > -- > 2.25.1.windows.1 >=20 >=20 >=20