From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.4080.1588993417871324020 for ; Fri, 08 May 2020 20:03:37 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) IronPort-SDR: LTYWuCElTjoYx6P5V1fvXdVS7kqUIsTxcgu5bJ6a1DwGL/USgX4kSum2f3aCjyU7Nb8kEey/6f NcdQIHOsBCYA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 20:03:37 -0700 IronPort-SDR: dJiQGH9Z4LtEtRjKOlDU0faTrFSi8TFWGgsB9wygWcisAgmVXe8pfE1lETbd98tJ6O5xzOc7jC tEJr71pLVDAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,370,1583222400"; d="scan'208";a="339990219" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 08 May 2020 20:03:37 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 20:03:36 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 20:03:36 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.210]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.225]) with mapi id 14.03.0439.000; Sat, 9 May 2020 11:03:33 +0800 From: "Ni, Ray" To: "Jiang, Guomin" , "devel@edk2.groups.io" CC: GuoMinJ , "Gao, Zhichao" Subject: Re: [PATCH 13/18] MdeModulePkg/ConSplitterDxe: Remove All UGA Support Thread-Topic: [PATCH 13/18] MdeModulePkg/ConSplitterDxe: Remove All UGA Support Thread-Index: AQHWJRQe0lvd7t4vPEiPGnH6mVTbV6ifEo1g Date: Sat, 9 May 2020 03:03:33 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C530B00@SHSMSX104.ccr.corp.intel.com> References: <20200508083824.1785-1-guomin.jiang@intel.com> <20200508083824.1785-14-guomin.jiang@intel.com> In-Reply-To: <20200508083824.1785-14-guomin.jiang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The information in commit message is not helpful for me to understand why this change can avoid OVMF hang. > -----Original Message----- > From: Jiang, Guomin > Sent: Friday, May 8, 2020 4:38 PM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Gao, Zhichao ; Ni, Ray > Subject: [PATCH 13/18] MdeModulePkg/ConSplitterDxe: Remove All UGA Suppor= t >=20 > From: GuoMinJ >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2368 >=20 > Avoid OVMF hang when remove UGA support. >=20 > Cc: Zhichao Gao > Cc: Ray Ni > Signed-off-by: Guomin Jiang > --- > .../Universal/Console/ConSplitterDxe/ConSplitter.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > index 3fdeee4b409b..18c25956d0d9 100644 > --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > @@ -3060,12 +3060,14 @@ ConSplitterTextOutAddDevice ( > DeviceStatus =3D ConSplitterAddGraphicsOutputMode (Private, Graphics= Output); > } >=20 > - Status =3D GraphicsOutput->QueryMode (GraphicsOutput, GraphicsOutput->= Mode->Mode, &SizeOfInfo, &Info); > - if (EFI_ERROR (Status)) { > - return Status; > + if (GraphicsOutput !=3D NULL) { > + Status =3D GraphicsOutput->QueryMode (GraphicsOutput, GraphicsOutput= ->Mode->Mode, &SizeOfInfo, &Info); > + if (EFI_ERROR (Status)) { > + return Status; > + } > + ASSERT ( SizeOfInfo <=3D sizeof (EFI_GRAPHICS_OUTPUT_MODE_INFORMATIO= N)); > + FreePool (Info); > } > - ASSERT ( SizeOfInfo <=3D sizeof (EFI_GRAPHICS_OUTPUT_MODE_INFORMATION)= ); > - FreePool (Info); >=20 > if (((!EFI_ERROR (DeviceStatus)) || (!EFI_ERROR (Status))) && > ((Private->CurrentNumberOfGraphicsOutput) =3D=3D 1)) { > -- > 2.25.1.windows.1