public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"oleksiyy@ami.com" <oleksiyy@ami.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Felixp@ami.com" <Felixp@ami.com>,
	"robert@ami.com" <robert@ami.com>
Subject: Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
Date: Mon, 11 May 2020 05:00:30 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C5356E7@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20200507190310.38968-6-oleksiyy@ami.com>

Robert,
I did similar change to MpService.h in 
https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc.

My plan was to move the change to edk2 once the spec is published.
It seems your change doesn't conflict with my change. More comments are added in your change
which I think is better than mine.

A minor comment to the comment in below.

> +
> +/// Location2   The 6-level physical location of the processor, including the
> +///     physical package number that identifies the cartridge, the physical
> +///     module number within package, the physical tile number within the
> module,
> +///     the physical die number within the tile, the physical core number within
> +///     package, and logical thread number within core.

Can you move the above comment to the line before "Location2" field and remove
the "Location2  "? It aligns to existing comments style.

> +typedef union {
> +     EFI_CPU_PHYSICAL_LOCATION2  Location2;
> +} EXTENDED_PROCESSOR_INFORMATION;
> +
> +

With that, Reviewed-by: Ray Ni <ray.ni@intel.com>


  reply	other threads:[~2020-05-11  5:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 19:03 [PATCH 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a Oleksiy Yakovlev
2020-05-07 19:03 ` [PATCH 1/5] MdePkg: New Status Codes Oleksiy Yakovlev
2020-05-11  5:13   ` [edk2-devel] " Zhiguang Liu
2020-05-07 19:03 ` [PATCH 2/5] MdePkg: Updates to PI 1.7 Revision numbers for Oleksiy Yakovlev
2020-05-11  5:20   ` [edk2-devel] " Zhiguang Liu
     [not found]   ` <160DE1B9669AE9D0.7726@groups.io>
2020-05-11  5:22     ` Zhiguang Liu
2020-05-07 19:03 ` [PATCH 3/5] MdePkg: EFI_MM_COMUNICATION2_PROTOCOL Oleksiy Yakovlev
2020-05-11  5:31   ` [edk2-devel] " Zhiguang Liu
2020-05-07 19:03 ` [PATCH 4/5] MdePkg: Added header file for Delayed Dispatch PPI Oleksiy Yakovlev
2020-05-11  5:43   ` [edk2-devel] " Zhiguang Liu
2020-05-07 19:03 ` [PATCH 5/5] MdePkg: Update structures for MpServices Protocol Oleksiy Yakovlev
2020-05-11  5:00   ` Ni, Ray [this message]
2020-05-15  4:56     ` [edk2-devel] " Liming Gao
2020-05-15  5:33       ` Ni, Ray
     [not found]       ` <160F1CC8B9ACB17A.23170@groups.io>
2020-05-15  7:48         ` Ni, Ray
2020-05-15  7:50           ` Liming Gao
2020-05-11  6:05   ` Zhiguang Liu
2020-05-11 14:29 ` [edk2-devel] [PATCH 0/5] Add Definitions introduced in PI 1.7 and PI 1.7a Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C5356E7@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox