From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.6402.1589173241990246855 for ; Sun, 10 May 2020 22:00:42 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) IronPort-SDR: o59Je2pZcp3ZjalZes3FTeLtpfUKT1LajpJIkvBZGrUWzVfXDdSGaAJPFw71d5Z3XgbaTB7D6g 8idR8dqEDtzA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2020 22:00:41 -0700 IronPort-SDR: KZeGWJLG5KjxP+T4Aj5/kjbLhw8kIfvVHUiH25GI/yq8eCkuU2btw2qgSuVtD61nNT1cXsC5qD XShaxtdT9Zqw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,378,1583222400"; d="scan'208";a="296828210" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 10 May 2020 22:00:41 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 22:00:41 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 22:00:40 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.210]) by shsmsx102.ccr.corp.intel.com ([169.254.2.38]) with mapi id 14.03.0439.000; Mon, 11 May 2020 13:00:31 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "Gao, Liming" , "Kinney, Michael D" , "Felixp@ami.com" , "robert@ami.com" Subject: Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol Thread-Topic: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol Thread-Index: AQHWJKJknu+eeo7rQUina0T25ZwTmqiiVWLA Date: Mon, 11 May 2020 05:00:30 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C5356E7@SHSMSX104.ccr.corp.intel.com> References: <20200507190310.38968-1-oleksiyy@ami.com> <20200507190310.38968-6-oleksiyy@ami.com> In-Reply-To: <20200507190310.38968-6-oleksiyy@ami.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Robert, I did similar change to MpService.h in=20 https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2a= d706575f82e2fc. My plan was to move the change to edk2 once the spec is published. It seems your change doesn't conflict with my change. More comments are add= ed in your change which I think is better than mine. A minor comment to the comment in below. > + > +/// Location2 The 6-level physical location of the processor, includin= g the > +/// physical package number that identifies the cartridge, the physi= cal > +/// module number within package, the physical tile number within th= e > module, > +/// the physical die number within the tile, the physical core numbe= r within > +/// package, and logical thread number within core. Can you move the above comment to the line before "Location2" field and rem= ove the "Location2 "? It aligns to existing comments style. > +typedef union { > + EFI_CPU_PHYSICAL_LOCATION2 Location2; > +} EXTENDED_PROCESSOR_INFORMATION; > + > + With that, Reviewed-by: Ray Ni