From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.6521.1589174289524098831 for ; Sun, 10 May 2020 22:18:09 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) IronPort-SDR: 0mcHXbswMwZzCR7l+Q9xdq2yaOy1ejlHhs2c9NaikHHcDWKlxUzDu1AscLcvz4PT1QKKnOl518 W+HjNJI0seqA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2020 22:18:09 -0700 IronPort-SDR: qr+un/3U1j4oVTjgFp8yfJ66x89LnL1YSlOmIDuy+FwGVP/a/M9TP+v2zOZIT0S7HI8rK1ZUsr EjbrBBp7ijRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,378,1583222400"; d="scan'208";a="371108518" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 10 May 2020 22:18:09 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 22:18:09 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 22:18:08 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.210]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.181]) with mapi id 14.03.0439.000; Mon, 11 May 2020 13:18:05 +0800 From: "Ni, Ray" To: Samer El-Haj-Mahmoud , "devel@edk2.groups.io" , "Kinney, Michael D" CC: Leif Lindholm , Ard Biesheuvel Subject: Re: [edk2-platform][PATCH v1 2/4] Drivers/OptionRomPkg: Move ASIX drivers to AsixPkg Thread-Topic: [edk2-platform][PATCH v1 2/4] Drivers/OptionRomPkg: Move ASIX drivers to AsixPkg Thread-Index: AQHWJrxYLwOObEOl9U2rFQ0YXzFtCqiiVsQQ Date: Mon, 11 May 2020 05:18:05 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C535744@SHSMSX104.ccr.corp.intel.com> References: <20200510111530.26225-1-Samer.El-Haj-Mahmoud@arm.com> <20200510111530.26225-3-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20200510111530.26225-3-Samer.El-Haj-Mahmoud@arm.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike, Is there a rule that a package name should end with "Pkg"? I thought we have but it sounds to me many packages in Silicon directory do= n't follow. In this case: 1. "ASIX" folder holds the package content. 2. Pkg dsc and dec file are named as "AsixPkg". 3. PLATFORM_NAME is defined as "AsixPkg" in DSC file . Thanks, Ray > -----Original Message----- > From: Samer El-Haj-Mahmoud > Sent: Sunday, May 10, 2020 7:15 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Leif Lindholm ; Ard > Biesheuvel ; Kinney, Michael D > > Subject: [edk2-platform][PATCH v1 2/4] Drivers/OptionRomPkg: Move ASIX > drivers to AsixPkg >=20 > Move ASIX Ax88772 and Ax88772b USB networking drivers to the newly > created Silicon/AsixPkg/. >=20 > Cc: Ray Ni > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Michael D Kinney >=20 > Signed-off-by: Samer El-Haj-Mahmoud > --- > Drivers/OptionRomPkg/OptionRomPkg.dsc = | > 2 -- > Platform/Hisilicon/HiKey/HiKey.dsc = | 2 +- > Platform/RaspberryPi/RPi3/RPi3.dsc = | 2 +- > Platform/RaspberryPi/RPi4/RPi4.dsc = | 2 +- > Silicon/ASIX/AsixPkg.dsc = | 3 ++- > Platform/Hisilicon/HiKey/HiKey.fdf = | 2 +- > Platform/RaspberryPi/RPi3/RPi3.fdf = | 2 +- > Platform/RaspberryPi/RPi4/RPi4.fdf = | 2 +- > {Drivers/OptionRomPkg =3D> > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf | 0 > {Drivers/OptionRomPkg =3D> > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf | 0 > {Drivers/OptionRomPkg =3D> > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772/Ax88772.h | 0 > {Drivers/OptionRomPkg =3D> > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.h | 0 > {Drivers/OptionRomPkg =3D> > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c | 0 > {Drivers/OptionRomPkg =3D> > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772/ComponentName.c | 0 > {Drivers/OptionRomPkg =3D> > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772/DriverBinding.c | 0 > {Drivers/OptionRomPkg =3D> > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772/SimpleNetwork.c | 0 > {Drivers/OptionRomPkg =3D> > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.c | 0 > {Drivers/OptionRomPkg =3D> > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772b/ComponentName.c | > 0 > {Drivers/OptionRomPkg =3D> > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772b/DriverBinding.c | 0 > {Drivers/OptionRomPkg =3D> > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c | 0 > 20 files changed, 8 insertions(+), 9 deletions(-) >=20 > diff --git a/Drivers/OptionRomPkg/OptionRomPkg.dsc > b/Drivers/OptionRomPkg/OptionRomPkg.dsc > index bea64b585ec6..153f47de5be1 100644 > --- a/Drivers/OptionRomPkg/OptionRomPkg.dsc > +++ b/Drivers/OptionRomPkg/OptionRomPkg.dsc > @@ -106,8 +106,6 @@ [Components] > OptionRomPkg/CirrusLogic5430Dxe/CirrusLogic5430Dxe.inf > OptionRomPkg/UndiRuntimeDxe/UndiRuntimeDxe.inf > OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDxe.inf > - OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf > - OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf >=20 > [Components.IA32, Components.X64] > OptionRomPkg/Application/BltLibSample/BltLibSample.inf > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc > b/Platform/Hisilicon/HiKey/HiKey.dsc > index 600f19a30762..88674d4564d0 100644 > --- a/Platform/Hisilicon/HiKey/HiKey.dsc > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc > @@ -247,7 +247,7 @@ [Components.common] > # > # AX88772 Ethernet Driver > # > - Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > + Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf >=20 > # > # FAT filesystem + GPT/MBR partitioning > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc > b/Platform/RaspberryPi/RPi3/RPi3.dsc > index bf645110eb61..0f736fa80e91 100644 > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc > @@ -648,7 +648,7 @@ [Components.common] > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > - Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > + Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf >=20 > # > # SD/MMC support > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc > b/Platform/RaspberryPi/RPi4/RPi4.dsc > index 0d54fa477ca2..064ca762c650 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -661,7 +661,7 @@ [Components.common] > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > - Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > + Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf >=20 > # > # SD/MMC support > diff --git a/Silicon/ASIX/AsixPkg.dsc b/Silicon/ASIX/AsixPkg.dsc > index d200bb7848c6..0e4ffd0f1743 100644 > --- a/Silicon/ASIX/AsixPkg.dsc > +++ b/Silicon/ASIX/AsixPkg.dsc > @@ -64,4 +64,5 @@ [PcdsFixedAtBuild] > # >=20 > ################################################################ > ################ > [Components] > - > +Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf > +Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > diff --git a/Platform/Hisilicon/HiKey/HiKey.fdf > b/Platform/Hisilicon/HiKey/HiKey.fdf > index 657e6c8ef2ec..10bbe62ef121 100644 > --- a/Platform/Hisilicon/HiKey/HiKey.fdf > +++ b/Platform/Hisilicon/HiKey/HiKey.fdf > @@ -158,7 +158,7 @@ [FV.FvMain] > # > # AX88772 Ethernet Driver for Apple Ethernet Adapter > # > - INF Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > + INF Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf >=20 > # > # FAT filesystem + GPT/MBR partitioning > diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf > b/Platform/RaspberryPi/RPi3/RPi3.fdf > index e854cd214153..c2f60cf93022 100644 > --- a/Platform/RaspberryPi/RPi3/RPi3.fdf > +++ b/Platform/RaspberryPi/RPi3/RPi3.fdf > @@ -289,7 +289,7 @@ [FV.FvMain] > INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > - INF Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > + INF Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf >=20 > # > # SD/MMC support > diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf > b/Platform/RaspberryPi/RPi4/RPi4.fdf > index b1f7aa2387df..e6e039434569 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.fdf > +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf > @@ -293,7 +293,7 @@ [FV.FvMain] > INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > - INF Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > + INF Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf >=20 > # > # SD/MMC support > diff --git > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf > similarity index 100% > rename from > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf > rename to Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf > diff --git > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > similarity index 100% > rename from > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > rename to > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > diff --git > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.h > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.h > similarity index 100% > rename from > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.h > rename to Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.h > diff --git > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.h > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.h > similarity index 100% > rename from > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.h > rename to Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.h > diff --git > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c > similarity index 100% > rename from > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c > rename to Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c > diff --git > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/ComponentName. > c b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/ComponentName.c > similarity index 100% > rename from > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/ComponentName.c > rename to > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/ComponentName.c > diff --git > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/DriverBinding.c > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/DriverBinding.c > similarity index 100% > rename from > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/DriverBinding.c > rename to > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/DriverBinding.c > diff --git > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/SimpleNetwork.c > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/SimpleNetwork.c > similarity index 100% > rename from > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/SimpleNetwork.c > rename to > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/SimpleNetwork.c > diff --git > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.c > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.c > similarity index 100% > rename from > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.c > rename to Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.c > diff --git > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/ComponentName > .c > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/ComponentName.c > similarity index 100% > rename from > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/ComponentName.c > rename to > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/ComponentName.c > diff --git > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/DriverBinding.c > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/DriverBinding.c > similarity index 100% > rename from > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/DriverBinding.c > rename to > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/DriverBinding.c > diff --git > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c > similarity index 100% > rename from > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c > rename to > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c > -- > 2.17.1