From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.1104.1589351954974635454 for ; Tue, 12 May 2020 23:39:15 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) IronPort-SDR: aPZfL2we0XhayC3m6hJNTfOAck8DKS6KOCYItDNdv4jWTYZvKE6cmPDfzSqZzZMGlRLTLv2A0n hMGhXoA7IlcQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 23:39:14 -0700 IronPort-SDR: 2mJ/ese/IzrF/VnNq1/tfJ5IK0CzIDWBJEeAwbLq8+p3YxNf8gGr4XnHV+BVggZnio0F/+NDpP X0TyrpVaAWyg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,386,1583222400"; d="scan'208";a="253106880" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga008.fm.intel.com with ESMTP; 12 May 2020 23:39:14 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 23:39:14 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 23:39:13 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.210]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.248]) with mapi id 14.03.0439.000; Wed, 13 May 2020 14:39:10 +0800 From: "Ni, Ray" To: "Javeed, Ashraf" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 06/15] MdeModulePkg/PciBusDxe: Add the framework to init PCIe features Thread-Topic: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 06/15] MdeModulePkg/PciBusDxe: Add the framework to init PCIe features Thread-Index: AQHWJuYUJe62JSGvi0ytnelqFKTApKig+CKAgASaqbA= Date: Wed, 13 May 2020 06:39:10 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C53ADAB@SHSMSX104.ccr.corp.intel.com> References: <20200510161412.13832-1-ashraf.javeed@intel.com> <20200510161412.13832-7-ashraf.javeed@intel.com> In-Reply-To: <20200510161412.13832-7-ashraf.javeed@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > + // " Device MPS MRRS RO NS CTO LTR\n" 1. Can you update above comments to below? // "Device MPS MRRS RO NS CTO LTR AtomicOp ExtTag= CCC\n" It explains why "%03x" or "%08x" is chosen in below DEBUG output. > + DEBUG (( > + DEBUG_INFO, " %02x|%02x|%02x %03x %04x %02x %02x %03x %03x %08x %06= x %03x\n", > +} > + } > + //DEBUG ((DEBUG_INFO, " PCIe %s feature...\n", mPcieFeatureStr[= Index])); 2. Can you please remove the above commented debug message? With the two comments addressed, Reviewed-by: Ray Ni