public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "Yau, KaiX" <kaix.yau@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"kaiyau@gmail.com" <kaiyau@gmail.com>
Cc: "Jiang, Guomin" <guomin.jiang@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Archield, Ralphal" <ralphal.archield@intel.com>,
	"Zhao, Lijian" <lijian.zhao@intel.com>
Subject: Re: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP
Date: Thu, 14 May 2020 02:54:49 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C54B533@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <f72e97f0eb7c4464b21ae80417f6163c@intel.com>

Kai,
I created the initial design and made the initial change: using the two PCD to help code decide the correct century value.
More comments below.

> -----Original Message-----
> From: Yau, KaiX <kaix.yau@intel.com>
> Sent: Thursday, May 14, 2020 1:14 AM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; kaiyau@gmail.com
> Cc: Jiang, Guomin <guomin.jiang@intel.com>; Gao, Liming <liming.gao@intel.com>; Archield, Ralphal
> <ralphal.archield@intel.com>; Zhao, Lijian <lijian.zhao@intel.com>
> Subject: RE: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP
> 
> Hi,
> 
> The current logic has two limitations:
> 1. it has to be 100 years apart  (already mentioned in DEC file)
I agree it's a limitation. I don't want to solve this limitation with current RTC HW.

> 2. the century numbers have to be same in order to work. (19XX, 20XX will not work) (20xx, 21xx will not work)
> Since now is 2020, the value has to be 2000, 2099. But BIOS developers does not know this limitation.
I don't agree. Let's forget other argue points and just focus on this point.
Can you please explain why with the PCD value (1998,2097) cannot support this year 2020?


  reply	other threads:[~2020-05-14  2:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20  3:42 [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP Yau
2020-03-27  5:15 ` [edk2-devel] " Guomin Jiang
2020-04-27  4:53 ` Ni, Ray
2020-04-27  5:47   ` Yau, KaiX
2020-05-12  1:52     ` Ni, Ray
2020-05-12  2:01       ` Yau, KaiX
2020-05-12  5:41         ` Ni, Ray
2020-05-12  5:51           ` Yau, KaiX
2020-05-13  3:27             ` Ni, Ray
2020-05-13  3:36               ` Yau, KaiX
2020-05-13  4:45                 ` Ni, Ray
2020-05-13  5:45                   ` Yau, KaiX
2020-05-13  9:02                     ` Ni, Ray
2020-05-13 17:13                       ` Yau, KaiX
2020-05-14  2:54                         ` Ni, Ray [this message]
2020-05-14  3:35                           ` Yau, KaiX
2020-05-14  5:38                             ` Ni, Ray
     [not found]                               ` <DM6PR11MB3817DAEAB31E0676CF6E41F6F4BC0@DM6PR11MB3817.namprd11.prod.outlook.com>
2020-05-14  7:09                                 ` Ni, Ray
2020-05-14 15:11                                   ` Yau, KaiX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C54B533@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox