From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.5583.1589424895328630693 for ; Wed, 13 May 2020 19:54:55 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) IronPort-SDR: swbPkbglwmYE/tg8PclkJj0KSj+ha9obg0a+lFiizmKQGK3Xxpj8mYZRUlO95KSRQDi99mqDHx 0gAfz9ua9EOA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 19:54:54 -0700 IronPort-SDR: jVKPooTeXG6TVRcLjtMEwXgHHEFcm2ZciA8Vhvd8Q9OwSFYgvRwle25LZnSzHfoBaAxzoE9PfL te49O9epEGTA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,390,1583222400"; d="scan'208";a="306968387" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 13 May 2020 19:54:54 -0700 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 19:54:54 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 19:54:53 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.181]) by shsmsx102.ccr.corp.intel.com ([169.254.2.245]) with mapi id 14.03.0439.000; Thu, 14 May 2020 10:54:50 +0800 From: "Ni, Ray" To: "Yau, KaiX" , "devel@edk2.groups.io" , "kaiyau@gmail.com" CC: "Jiang, Guomin" , "Gao, Liming" , "Archield, Ralphal" , "Zhao, Lijian" Subject: Re: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP Thread-Topic: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP Thread-Index: AQHWAMIW/k98ZzzV00mjseooVZSurqiMedbQ//+tKwCAF9ZJMP//fbgAgADC61D//31RAAA99D9Q//986gD//2jOkIAAuyuA//9F0lCAAXp9gP/+6+pw Date: Thu, 14 May 2020 02:54:49 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C54B533@SHSMSX104.ccr.corp.intel.com> References: <50102ef8b38c0e5287ab4d1cb8fc636213f67299.1584672719.git.kaix.yau@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C51152B@SHSMSX104.ccr.corp.intel.com> <3f6385f623054e24b44a375765246d2f@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C53809A@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C53887A@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C53A7C4@SHSMSX104.ccr.corp.intel.com> <213de571cb0b4471852cb3b8c616a8da@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C53A9CE@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C53B2D9@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Kai, I created the initial design and made the initial change: using the two PCD= to help code decide the correct century value. More comments below. > -----Original Message----- > From: Yau, KaiX > Sent: Thursday, May 14, 2020 1:14 AM > To: Ni, Ray ; devel@edk2.groups.io; kaiyau@gmail.com > Cc: Jiang, Guomin ; Gao, Liming ; Archield, Ralphal > ; Zhao, Lijian > Subject: RE: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displ= ayed in SETUP >=20 > Hi, >=20 > The current logic has two limitations: > 1. it has to be 100 years apart (already mentioned in DEC file) I agree it's a limitation. I don't want to solve this limitation with curre= nt RTC HW. > 2. the century numbers have to be same in order to work. (19XX, 20XX will= not work) (20xx, 21xx will not work) > Since now is 2020, the value has to be 2000, 2099. But BIOS developers do= es not know this limitation. I don't agree. Let's forget other argue points and just focus on this point= . Can you please explain why with the PCD value (1998,2097) cannot support th= is year 2020?