From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.7990.1589520840332774422 for ; Thu, 14 May 2020 22:34:01 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com) IronPort-SDR: MD8FBuiJkP0xfxN0dEwOObl5wW037PTsgwa9PpvDR8cnLWJfkffgm3fnse8Ptz1oJMYKybcpty kTuF33/5eOJA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 22:33:59 -0700 IronPort-SDR: W0R6uUiSbLdUvptmW6C7bsU8rFidOsLWgnlUimhgAaY2Ele65BtZTrzSA9ehwfKtH2Umhi1Lvu C9SHvgntaJ4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,394,1583222400"; d="scan'208";a="266493592" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 14 May 2020 22:33:59 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 22:33:58 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 22:33:58 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 22:33:58 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.181]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.178]) with mapi id 14.03.0439.000; Fri, 15 May 2020 13:33:55 +0800 From: "Ni, Ray" To: "Gao, Liming" , "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "Kinney, Michael D" , "Felixp@ami.com" , "robert@ami.com" Subject: Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol Thread-Topic: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol Thread-Index: AQHWJKJknu+eeo7rQUina0T25ZwTmqiiVWLAgAXFqwCAAJB+kA== Date: Fri, 15 May 2020 05:33:55 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C55F1B9@SHSMSX104.ccr.corp.intel.com> References: <20200507190310.38968-1-oleksiyy@ami.com> <20200507190310.38968-6-oleksiyy@ami.com> <734D49CCEBEEF84792F5B80ED585239D5C5356E7@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable sure I will. > -----Original Message----- > From: Gao, Liming > Sent: Friday, May 15, 2020 12:57 PM > To: Ni, Ray ; devel@edk2.groups.io; oleksiyy@ami.com > Cc: Kinney, Michael D ; Felixp@ami.com; rober= t@ami.com > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpSer= vices Protocol >=20 > Ray: > I see https://github.com/tianocore/edk2-staging/commit/2409b787fa196780= e0fd101b2ad706575f82e2fc also includes the > code change in UefiCpuPkg/Library/MpInitLib/MpLib.c. The change has passe= d review. >=20 > Can you send the separate patch for the change in UefiCpuPkg? >=20 > Thanks > Liming > > -----Original Message----- > > From: Ni, Ray > > Sent: Monday, May 11, 2020 1:01 PM > > To: devel@edk2.groups.io; oleksiyy@ami.com > > Cc: Gao, Liming ; Kinney, Michael D ; Felixp@ami.com; > robert@ami.com > > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpS= ervices Protocol > > > > Robert, > > I did similar change to MpService.h in > > https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd10= 1b2ad706575f82e2fc. > > > > My plan was to move the change to edk2 once the spec is published. > > It seems your change doesn't conflict with my change. More comments are= added in your change > > which I think is better than mine. > > > > A minor comment to the comment in below. > > > > > + > > > +/// Location2 The 6-level physical location of the processor, incl= uding the > > > +/// physical package number that identifies the cartridge, the p= hysical > > > +/// module number within package, the physical tile number withi= n the > > > module, > > > +/// the physical die number within the tile, the physical core n= umber within > > > +/// package, and logical thread number within core. > > > > Can you move the above comment to the line before "Location2" field and= remove > > the "Location2 "? It aligns to existing comments style. > > > > > +typedef union { > > > + EFI_CPU_PHYSICAL_LOCATION2 Location2; > > > +} EXTENDED_PROCESSOR_INFORMATION; > > > + > > > + > > > > With that, Reviewed-by: Ray Ni > > >=20