From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.8609.1589524998538135405 for ; Thu, 14 May 2020 23:43:18 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) IronPort-SDR: FNor/fYIzip1D2WZEgXcj8PteAvrbGYDAF4jJFA2/6pM9hkNCDW8WV1eJDf8WRor5VeNCWyhM+ tJRTf+ODF4Jw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 23:43:18 -0700 IronPort-SDR: n8IHMtVTdhjGKsN7Q4GYkb1BT1ZW1OPYQHOqLw6fotK366OZu027U09eTR1P/A0P3Kv75vXLO7 uThdFkBCUOrA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,394,1583222400"; d="scan'208";a="341885363" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 14 May 2020 23:43:17 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 23:43:17 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 23:43:17 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.181]) by shsmsx102.ccr.corp.intel.com ([169.254.2.245]) with mapi id 14.03.0439.000; Fri, 15 May 2020 14:43:14 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "samer.el-haj-mahmoud@arm.com" , "Kinney, Michael D" CC: Leif Lindholm , Ard Biesheuvel Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 2/4] Drivers/OptionRomPkg: Move ASIX drivers to AsixPkg Thread-Topic: [edk2-devel] [edk2-platform][PATCH v1 2/4] Drivers/OptionRomPkg: Move ASIX drivers to AsixPkg Thread-Index: AQHWJrxYLwOObEOl9U2rFQ0YXzFtCqiiVsQQgAVraXCAAPh8EA== Date: Fri, 15 May 2020 06:43:13 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C55F31F@SHSMSX104.ccr.corp.intel.com> References: <20200510111530.26225-1-Samer.El-Haj-Mahmoud@arm.com> <20200510111530.26225-3-Samer.El-Haj-Mahmoud@arm.com> <734D49CCEBEEF84792F5B80ED585239D5C535744@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes that looks better. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Samer El-= Haj-Mahmoud > Sent: Thursday, May 14, 2020 11:55 PM > To: Ni, Ray ; devel@edk2.groups.io; Kinney, Michael D = > Cc: Leif Lindholm ; Ard Biesheuvel > Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 2/4] Drivers/OptionRo= mPkg: Move ASIX drivers to AsixPkg >=20 > Any consensus on this? I can just rename AsixPkg.dsc/fdf to Asix.dsc/fdf= (with a matching PLATFORM_NAME ) if that is > more consistent >=20 > > -----Original Message----- > > From: Ni, Ray > > Sent: Monday, May 11, 2020 1:18 AM > > To: Samer El-Haj-Mahmoud ; > > devel@edk2.groups.io; Kinney, Michael D > > Cc: Leif Lindholm ; Ard Biesheuvel > > > > Subject: RE: [edk2-platform][PATCH v1 2/4] Drivers/OptionRomPkg: Move > > ASIX drivers to AsixPkg > > > > Mike, > > Is there a rule that a package name should end with "Pkg"? > > I thought we have but it sounds to me many packages in Silicon directo= ry > > don't follow. > > > > In this case: > > 1. "ASIX" folder holds the package content. > > 2. Pkg dsc and dec file are named as "AsixPkg". > > 3. PLATFORM_NAME is defined as "AsixPkg" in DSC file . > > > > Thanks, > > Ray > > > > > -----Original Message----- > > > From: Samer El-Haj-Mahmoud > > > Sent: Sunday, May 10, 2020 7:15 PM > > > To: devel@edk2.groups.io > > > Cc: Ni, Ray ; Leif Lindholm ; A= rd > > > Biesheuvel ; Kinney, Michael D > > > > > > Subject: [edk2-platform][PATCH v1 2/4] Drivers/OptionRomPkg: Move > > ASIX > > > drivers to AsixPkg > > > > > > Move ASIX Ax88772 and Ax88772b USB networking drivers to the newly > > > created Silicon/AsixPkg/. > > > > > > Cc: Ray Ni > > > Cc: Leif Lindholm > > > Cc: Ard Biesheuvel > > > Cc: Michael D Kinney > > > > > > Signed-off-by: Samer El-Haj-Mahmoud > mahmoud@arm.com> > > > --- > > > Drivers/OptionRomPkg/OptionRomPkg.dsc = | > > > 2 -- > > > Platform/Hisilicon/HiKey/HiKey.dsc = | 2 +- > > > Platform/RaspberryPi/RPi3/RPi3.dsc = | 2 +- > > > Platform/RaspberryPi/RPi4/RPi4.dsc = | 2 +- > > > Silicon/ASIX/AsixPkg.dsc = | 3 ++- > > > Platform/Hisilicon/HiKey/HiKey.fdf = | 2 +- > > > Platform/RaspberryPi/RPi3/RPi3.fdf = | 2 +- > > > Platform/RaspberryPi/RPi4/RPi4.fdf = | 2 +- > > > {Drivers/OptionRomPkg =3D> > > > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf = | 0 > > > {Drivers/OptionRomPkg =3D> > > > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf = | > > 0 > > > {Drivers/OptionRomPkg =3D> > > > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772/Ax88772.h = | 0 > > > {Drivers/OptionRomPkg =3D> > > > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.h = | 0 > > > {Drivers/OptionRomPkg =3D> > > > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c = | 0 > > > {Drivers/OptionRomPkg =3D> > > > > > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772/ComponentName.c > > | > > > 0 {Drivers/OptionRomPkg =3D> > > > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772/DriverBinding.c = | > > > 0 {Drivers/OptionRomPkg =3D> > > > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772/SimpleNetwork.c > > | > > > 0 {Drivers/OptionRomPkg =3D> > > > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.c = | 0 > > > {Drivers/OptionRomPkg =3D> > > > > > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772b/ComponentName > > .c | > > > 0 > > > {Drivers/OptionRomPkg =3D> > > > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772b/DriverBinding.c= | > > > 0 {Drivers/OptionRomPkg =3D> > > > > > Silicon/ASIX/Drivers}/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c > > | > > > 0 > > > 20 files changed, 8 insertions(+), 9 deletions(-) > > > > > > diff --git a/Drivers/OptionRomPkg/OptionRomPkg.dsc > > > b/Drivers/OptionRomPkg/OptionRomPkg.dsc > > > index bea64b585ec6..153f47de5be1 100644 > > > --- a/Drivers/OptionRomPkg/OptionRomPkg.dsc > > > +++ b/Drivers/OptionRomPkg/OptionRomPkg.dsc > > > @@ -106,8 +106,6 @@ [Components] > > > OptionRomPkg/CirrusLogic5430Dxe/CirrusLogic5430Dxe.inf > > > OptionRomPkg/UndiRuntimeDxe/UndiRuntimeDxe.inf > > > OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDxe.inf > > > - OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf > > > - OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > > > > [Components.IA32, Components.X64] > > > OptionRomPkg/Application/BltLibSample/BltLibSample.inf > > > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc > > > b/Platform/Hisilicon/HiKey/HiKey.dsc > > > index 600f19a30762..88674d4564d0 100644 > > > --- a/Platform/Hisilicon/HiKey/HiKey.dsc > > > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc > > > @@ -247,7 +247,7 @@ [Components.common] > > > # > > > # AX88772 Ethernet Driver > > > # > > > - > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > + Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > > > > # > > > # FAT filesystem + GPT/MBR partitioning diff --git > > > a/Platform/RaspberryPi/RPi3/RPi3.dsc > > > b/Platform/RaspberryPi/RPi3/RPi3.dsc > > > index bf645110eb61..0f736fa80e91 100644 > > > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc > > > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc > > > @@ -648,7 +648,7 @@ [Components.common] > > > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > > > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > > > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > > > - > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > + Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > > > > # > > > # SD/MMC support > > > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc > > > b/Platform/RaspberryPi/RPi4/RPi4.dsc > > > index 0d54fa477ca2..064ca762c650 100644 > > > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > > > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > > > @@ -661,7 +661,7 @@ [Components.common] > > > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > > > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > > > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > > > - > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > + Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > > > > # > > > # SD/MMC support > > > diff --git a/Silicon/ASIX/AsixPkg.dsc b/Silicon/ASIX/AsixPkg.dsc ind= ex > > > d200bb7848c6..0e4ffd0f1743 100644 > > > --- a/Silicon/ASIX/AsixPkg.dsc > > > +++ b/Silicon/ASIX/AsixPkg.dsc > > > @@ -64,4 +64,5 @@ [PcdsFixedAtBuild] > > > # > > > > > > > > ########################################################## > > ###### > > > ################ > > > [Components] > > > - > > > +Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf > > > +Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > diff --git a/Platform/Hisilicon/HiKey/HiKey.fdf > > > b/Platform/Hisilicon/HiKey/HiKey.fdf > > > index 657e6c8ef2ec..10bbe62ef121 100644 > > > --- a/Platform/Hisilicon/HiKey/HiKey.fdf > > > +++ b/Platform/Hisilicon/HiKey/HiKey.fdf > > > @@ -158,7 +158,7 @@ [FV.FvMain] > > > # > > > # AX88772 Ethernet Driver for Apple Ethernet Adapter > > > # > > > - INF > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > + INF > > > + Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > > > > # > > > # FAT filesystem + GPT/MBR partitioning diff --git > > > a/Platform/RaspberryPi/RPi3/RPi3.fdf > > > b/Platform/RaspberryPi/RPi3/RPi3.fdf > > > index e854cd214153..c2f60cf93022 100644 > > > --- a/Platform/RaspberryPi/RPi3/RPi3.fdf > > > +++ b/Platform/RaspberryPi/RPi3/RPi3.fdf > > > @@ -289,7 +289,7 @@ [FV.FvMain] > > > INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > > > INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > > > INF > > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > > > - INF > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > + INF > > > + Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > > > > # > > > # SD/MMC support > > > diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf > > > b/Platform/RaspberryPi/RPi4/RPi4.fdf > > > index b1f7aa2387df..e6e039434569 100644 > > > --- a/Platform/RaspberryPi/RPi4/RPi4.fdf > > > +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf > > > @@ -293,7 +293,7 @@ [FV.FvMain] > > > INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > > > INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > > > INF > > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > > > - INF > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > + INF > > > + Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > > > > # > > > # SD/MMC support > > > diff --git > > > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf > > > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf > > > similarity index 100% > > > rename from > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf > > > rename to > > > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf > > > diff --git > > > > > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > similarity index 100% > > > rename from > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > rename to > > > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf > > > diff --git > > > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.h > > > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.h > > > similarity index 100% > > > rename from > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.h > > > rename to > > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.h > > > diff --git > > > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.h > > > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.h > > > similarity index 100% > > > rename from > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.h > > > rename to > > > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.h > > > diff --git > > > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c > > > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c > > > similarity index 100% > > > rename from > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c > > > rename to > > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c > > > diff --git > > > > > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/ComponentNa > > me. > > > c > > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/ComponentName > > .c > > > similarity index 100% > > > rename from > > > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/ComponentNam > > e.c > > > rename to > > > > > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/ComponentName.c > > > diff --git > > > > > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/DriverBinding.c > > > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/DriverBinding.c > > > similarity index 100% > > > rename from > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/DriverBinding.c > > > rename to > > > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/DriverBinding.c > > > diff --git > > > > > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/SimpleNetwor > > k.c > > > > > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/SimpleNetwork.c > > > similarity index 100% > > > rename from > > > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/SimpleNetwork.c > > > rename to > > > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772/SimpleNetwork.c > > > diff --git > > > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.c > > > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.c > > > similarity index 100% > > > rename from > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.c > > > rename to > > > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.c > > > diff --git > > > > > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/ComponentN > > ame > > > .c > > > > > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/ComponentNam > > e.c > > > similarity index 100% > > > rename from > > > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/ComponentNa > > me.c > > > rename to > > > > > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/ComponentName. > > c > > > diff --git > > > > > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/DriverBinding > > .c > > > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/DriverBinding.= c > > > similarity index 100% > > > rename from > > > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/DriverBinding.c > > > rename to > > > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/DriverBinding.c > > > diff --git > > > > > a/Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwo > > rk.c > > > > > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork. > > c > > > similarity index 100% > > > rename from > > > > > Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork > > .c > > > rename to > > > Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c > > > -- > > > 2.17.1 >=20 > IMPORTANT NOTICE: The contents of this email and any attachments are con= fidential and may also be privileged. If you > are not the intended recipient, please notify the sender immediately and= do not disclose the contents to any other person, > use it for any purpose, or store or copy the information in any medium. = Thank you. >=20 >=20