From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.8983.1589528945970865447 for ; Fri, 15 May 2020 00:49:06 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) IronPort-SDR: FYyvokUZGb6BvuBt1flk54FCMHOz28tl+gm0TWo29KQgXn/m/+rpewti5Va6FpZRvIOj19MJkB zY6e6d1h8qxw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 00:49:05 -0700 IronPort-SDR: JxMNpOvzM9CqogeQ6qGc5erncdHXP2QWmtmC9wID+hSdIYCBHn/CpzmgvMV8JizxkHn5znxxxv 97Svy8lTlS6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,394,1583222400"; d="scan'208";a="438222782" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 15 May 2020 00:49:04 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 May 2020 00:49:04 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 May 2020 00:49:03 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.181]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.80]) with mapi id 14.03.0439.000; Fri, 15 May 2020 15:48:54 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Ni, Ray" , "Gao, Liming" , "oleksiyy@ami.com" CC: "Kinney, Michael D" , "Felixp@ami.com" , "robert@ami.com" Subject: Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol Thread-Topic: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol Thread-Index: AQHWJKJknu+eeo7rQUina0T25ZwTmqiiVWLAgAXFqwCAAJB+kIAAJR3A Date: Fri, 15 May 2020 07:48:54 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C55F3F8@SHSMSX104.ccr.corp.intel.com> References: <20200507190310.38968-1-oleksiyy@ami.com> <20200507190310.38968-6-oleksiyy@ami.com> <734D49CCEBEEF84792F5B80ED585239D5C5356E7@SHSMSX104.ccr.corp.intel.com> <160F1CC8B9ACB17A.23170@groups.io> In-Reply-To: <160F1CC8B9ACB17A.23170@groups.io> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I just sent out the change to update GetProcessorInfo() to return 6-level t= opology info. The patch has been reviewed by Eric before pushing to edk2-staging repo. Please tell me when the MdePkg/MpServices.h is merged. I will trigger the merge after that. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Friday, May 15, 2020 1:34 PM > To: Gao, Liming ; devel@edk2.groups.io; oleksiyy@a= mi.com > Cc: Kinney, Michael D ; Felixp@ami.com; robe= rt@ami.com > Subject: Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpSe= rvices Protocol >=20 > sure I will. >=20 > > -----Original Message----- > > From: Gao, Liming > > Sent: Friday, May 15, 2020 12:57 PM > > To: Ni, Ray ; devel@edk2.groups.io; oleksiyy@ami.com > > Cc: Kinney, Michael D ; Felixp@ami.com; ro= bert@ami.com > > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for Mp= Services Protocol > > > > Ray: > > I see https://github.com/tianocore/edk2-staging/commit/2409b787fa196= 780e0fd101b2ad706575f82e2fc also includes > the > > code change in UefiCpuPkg/Library/MpInitLib/MpLib.c. The change has pa= ssed review. > > > > Can you send the separate patch for the change in UefiCpuPkg? > > > > Thanks > > Liming > > > -----Original Message----- > > > From: Ni, Ray > > > Sent: Monday, May 11, 2020 1:01 PM > > > To: devel@edk2.groups.io; oleksiyy@ami.com > > > Cc: Gao, Liming ; Kinney, Michael D ; Felixp@ami.com; > > robert@ami.com > > > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for = MpServices Protocol > > > > > > Robert, > > > I did similar change to MpService.h in > > > https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0f= d101b2ad706575f82e2fc. > > > > > > My plan was to move the change to edk2 once the spec is published. > > > It seems your change doesn't conflict with my change. More comments = are added in your change > > > which I think is better than mine. > > > > > > A minor comment to the comment in below. > > > > > > > + > > > > +/// Location2 The 6-level physical location of the processor, i= ncluding the > > > > +/// physical package number that identifies the cartridge, th= e physical > > > > +/// module number within package, the physical tile number wi= thin the > > > > module, > > > > +/// the physical die number within the tile, the physical cor= e number within > > > > +/// package, and logical thread number within core. > > > > > > Can you move the above comment to the line before "Location2" field = and remove > > > the "Location2 "? It aligns to existing comments style. > > > > > > > +typedef union { > > > > + EFI_CPU_PHYSICAL_LOCATION2 Location2; > > > > +} EXTENDED_PROCESSOR_INFORMATION; > > > > + > > > > + > > > > > > With that, Reviewed-by: Ray Ni > > > > > >=20 >=20 >=20