From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.3095.1591759043116194893 for ; Tue, 09 Jun 2020 20:17:23 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) IronPort-SDR: B8cvPRd2jguxclVNXSmPdPGYd8vQ2sSWS6DsLthlPB0gD51Rf5bwzH2Ec1KIqFlhWnIuZeDsOr yOFOXbQQvc5w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2020 20:17:21 -0700 IronPort-SDR: uhaKyswce4oYOxnIoEqp+7lPOTOmcxFQtXILSWz6zGJ7Mx6CHdv3SpixiqhQ7Oqg7c7tRPPeU/ 3BgCCZtZ9kxQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,494,1583222400"; d="scan'208";a="473190181" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 09 Jun 2020 20:17:21 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 20:17:21 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 20:17:21 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.161]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.90]) with mapi id 14.03.0439.000; Wed, 10 Jun 2020 11:17:17 +0800 From: "Ni, Ray" To: "Tan, Ming" , "devel@edk2.groups.io" CC: "Justen, Jordan L" , Andrew Fish Subject: Re: [PATCH v4 2/4] EmulatorPkg/EmulatorPkg.dsc: Change PCDs type about status code Thread-Topic: [PATCH v4 2/4] EmulatorPkg/EmulatorPkg.dsc: Change PCDs type about status code Thread-Index: AQHWPtLWjcnQQXQ1S0uEZrpjBFx9VKjRLYGQ Date: Wed, 10 Jun 2020 03:17:16 +0000 Deferred-Delivery: Wed, 10 Jun 2020 03:17:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C5A8A80@SHSMSX104.ccr.corp.intel.com> References: <20200610025634.21833-1-ming.tan@intel.com> <20200610025634.21833-2-ming.tan@intel.com> In-Reply-To: <20200610025634.21833-2-ming.tan@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Tan, Ming > Sent: Wednesday, June 10, 2020 10:57 AM > To: devel@edk2.groups.io > Cc: Justen, Jordan L ; Andrew Fish ; Ni, Ray > Subject: [PATCH v4 2/4] EmulatorPkg/EmulatorPkg.dsc: Change PCDs type abo= ut status code >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2786 >=20 > Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory > in MdeModulePkg.dec are changed, so change them from > PcdsFeatureFlag to PcdsFixedAtBuild in dsc file. >=20 > Cc: Jordan Justen > Cc: Andrew Fish > Cc: Ray Ni > Signed-off-by: Ming Tan > --- > V4: Adjust the location of PCDs, put them in the last of same TokenSpaceG= uid > instead of last of section. > V3: Split one patch to several patchs, each Pkg has one patch. > EmulatorPkg/EmulatorPkg.dsc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc > index 1fc924ae5a16..86a62717353b 100644 > --- a/EmulatorPkg/EmulatorPkg.dsc > +++ b/EmulatorPkg/EmulatorPkg.dsc > @@ -4,7 +4,7 @@ > # The Emulation Platform can be used to debug individual modules, prior = to creating > # a real platform. This also provides an example for how an DSC is creat= ed. > # > -# Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.
> # Portions copyright (c) 2010 - 2011, Apple Inc. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -174,7 +174,6 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER, LibraryCla= sses.common.UEFI_DRIVER, Li >=20 > [PcdsFeatureFlag] > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreImageLoaderSearchTeSectionFir= st|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplBuildPageTables|FALSE >=20 > @@ -186,6 +185,7 @@ [PcdsFixedAtBuild] > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x1f > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxSizeNonPopulateCapsule|0x0 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxSizePopulateCapsule|0x0 > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE >=20 > gEmulatorPkgTokenSpaceGuid.PcdEmuFirmwareFdSize|0x002a0000 > gEmulatorPkgTokenSpaceGuid.PcdEmuFirmwareBlockSize|0x10000 > -- > 2.24.0.windows.2