From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.2165.1591837908690127927 for ; Wed, 10 Jun 2020 18:11:48 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) IronPort-SDR: 2DEC+u73xHZAa4AkbHmgjqfI3MXmvYjxUrKORBlW01U5/oLRNn7/1ijQS9YWWM0CnNOd4Vb979 rlHEoP1tUVMA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2020 18:11:48 -0700 IronPort-SDR: jCZyzNNm4nQUmDgGs6g/4ojtYc+Ypj5iY98PiLwsQ0dLfd3/IDFvHWzPceEPIL4oRZ22RGrvmY vFlxD0WmN0LQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,498,1583222400"; d="scan'208";a="289381973" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 10 Jun 2020 18:11:47 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 18:11:47 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jun 2020 18:11:47 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.161]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.90]) with mapi id 14.03.0439.000; Thu, 11 Jun 2020 09:11:44 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "garrett.kirkendall@amd.com" CC: "Dong, Eric" , Laszlo Ersek Subject: Re: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib Thread-Topic: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib Thread-Index: AdY/LxrU4UeZwuEKT3qg1oH+0DYgTwAXZggw Date: Thu, 11 Jun 2020 01:11:43 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C5AB095@SHSMSX104.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-06-10T13:48:24Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=a0aba147-89af-413a-9a26-cb37e91c8949; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Since all platform DSCs have already listed UefiCpuLib.inf so this change d= oesn't impact platform DSC. I don't see an issue with this change. Eric, What's your opinion? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Kirkendal= l, Garrett > Sent: Wednesday, June 10, 2020 10:18 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo= Ersek > Subject: [edk2-devel] UefiCpuPkg: Discuss: Move StandardSignatureIsAuthe= nticAMD function to BaseUefiCpuLib >=20 > [AMD Public Use] >=20 > There are currently three instances of StandardSignatureIsAuthenticAMD F= unction in the below locations. I need to > propose another change that will require the same function in PiSmmCpuDx= eSmm. I would like to see this function move > to a single "LibraryClass" location. I think no one knew where to propo= se the function, so we ended up with three > instances so far. The best place I can find would be UefiCpuPkg/BaseUef= iCpuLib/. Thoughts? Is there a better function > name such that a similar Intel identifier function could be created when= needed in the future? >=20 > I'm thinking this will be 3 patches > 1. Add StandardSignatureIsAuthenticAMD to BaseUefiCpuLib > 2. Move current instances to Library function > 3. Propose code change in PiSmmCpuDxeSmm >=20 > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c: StandardSignatureIsAuthe= nticAMD ( > UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c: StandardSign= atureIsAuthenticAMD ( > UefiCpuPkg/Library/MpInitLib/MpLib.c: StandardSignatureIsAuthenticAMD ( >=20 > GARRETT KIRKENDALL > SMTS Firmware Engineer | CTE > 7171 Southwest Parkway, Austin, TX 78735 USA > AMD=A0=A0 facebook=A0 |=A0 amd.com >=20 >=20