From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.416.1593044928541996371 for ; Wed, 24 Jun 2020 17:28:48 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) IronPort-SDR: saqmQ3ZZpcY+abhrTPqN1unfhmsLNs1mqLkV7oH1n6VexILCemKhn9lBJi2X+8+tQOHJIesAC5 rE+heHEK95Sw== X-IronPort-AV: E=McAfee;i="6000,8403,9662"; a="133116438" X-IronPort-AV: E=Sophos;i="5.75,277,1589266800"; d="scan'208";a="133116438" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2020 17:28:48 -0700 IronPort-SDR: h65jfN2HhHzPm1JyE+wdJshcLCQDPNEmmGJQuP630Ey0PjSvPbPTWCCpjY4BWUHGtIqtjT5NJw o0wdcBZRf6dQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,277,1589266800"; d="scan'208";a="301816775" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 24 Jun 2020 17:28:47 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 17:28:08 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 17:28:08 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.161]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.221]) with mapi id 14.03.0439.000; Thu, 25 Jun 2020 08:28:05 +0800 From: "Ni, Ray" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Dong, Eric" Subject: Re: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API Thread-Topic: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API Thread-Index: AQHWSjLHbeoDAilYEkyKLitk1PbXRajoekwA Date: Thu, 25 Jun 2020 00:28:04 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C5D2697@SHSMSX104.ccr.corp.intel.com> References: <20200624142131.2035-1-liming.gao@intel.com> In-Reply-To: <20200624142131.2035-1-liming.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, Thank you! I didn't realize MinPlatformPkg contain an implementation of PciSegmentInfo= Lib when adding missing EFIAPI to the API prototype. Reviewed-by: Ray Ni > -----Original Message----- > From: Gao, Liming > Sent: Wednesday, June 24, 2020 10:22 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chiu, Chasel ; Des= imone, Nathaniel L > ; Dong, Eric > Subject: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSeg= mentInfo() API >=20 > Update GetPciSegmentInfo() API to match its library class definition >=20 > Signed-off-by: Liming Gao > Cc: Ray Ni > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Eric Dong > --- > .../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c = | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibS= imple/PciSegmentInfoLibSimple.c > b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSe= gmentInfoLibSimple.c > index 6a6218d906..398f4d4b78 100644 > --- a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/P= ciSegmentInfoLibSimple.c > +++ b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/P= ciSegmentInfoLibSimple.c > @@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO mPciSegmentInfo; > @retval A callee owned array holding the segment information. > **/ > PCI_SEGMENT_INFO * > +EFIAPI > GetPciSegmentInfo ( > OUT UINTN *Count > ) > -- > 2.13.0.windows.1