From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.14140.1594622681358542188 for ; Sun, 12 Jul 2020 23:44:41 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) IronPort-SDR: nUXXguM7W3NKuM/agbpZlgw3y3mPjYN8kWmcEkQaGpS+AQ5kHNpl1aXoFNB9PjeH+MTwZ6CMY/ tUR6eIYvozdw== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="136037468" X-IronPort-AV: E=Sophos;i="5.75,346,1589266800"; d="scan'208";a="136037468" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2020 23:44:40 -0700 IronPort-SDR: kgB1jQk92ZA/4B2Rd2aDcU2jXaEpHkw9lIv/jZe8YsWXtD6vnHtOBRzmUeaHVaNqrWZb18/PLo exjknj11wn4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,346,1589266800"; d="scan'208";a="429265609" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 12 Jul 2020 23:44:40 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 12 Jul 2020 23:44:39 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 12 Jul 2020 23:44:39 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.135]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.8]) with mapi id 14.03.0439.000; Mon, 13 Jul 2020 14:44:36 +0800 From: "Ni, Ray" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Wu, Hao A" , Laszlo Ersek Subject: Re: [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM Thread-Topic: [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM Thread-Index: AQHWVM9XSINU2oIp/U6zZobkQzBNrqkFDAXQ Date: Mon, 13 Jul 2020 06:44:36 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C611527@SHSMSX104.ccr.corp.intel.com> References: <20200708022722.27024-1-zhichao.gao@intel.com> <20200708022722.27024-3-zhichao.gao@intel.com> In-Reply-To: <20200708022722.27024-3-zhichao.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > + // > + // If the MBR with partition entry contains itself, i.e. start with = LBA0, > + // and have the same size with the media, we treat it as a El Torito= partition. > + // > + if ((StartingLBA =3D=3D 0) && > + (SizeInLBA !=3D 0) && 1. Can this check "SizeInLBA !=3D 0" be removed? > + DEBUG ((DEBUG_INFO, "PartitionValidMbr: The MBR table has partitio= n > entry start at sector 0.\n")); 2. Can the debug message be refined as below? " PartitionValidMbr: MBR table has partition entry covering the ENTIRE disk= . Don't treat it as a valid MBR."