From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.11621.1594692265771689830 for ; Mon, 13 Jul 2020 19:04:25 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) IronPort-SDR: 9+chQB4PfeSpa7bp7FXklR6/cxvtrd1T0Ne1e7Jtp1TSGNmAbngmCnVAeo6llh/8gIRiQpXz+i tZdbqYhu6eBw== X-IronPort-AV: E=McAfee;i="6000,8403,9681"; a="146798126" X-IronPort-AV: E=Sophos;i="5.75,349,1589266800"; d="scan'208";a="146798126" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 19:04:24 -0700 IronPort-SDR: FgrNstnn6rHIlHvtLJW9eAnl517a+jBuuky1R+7sb13aYee7JsVaXjOW/2Eed6JCgbkVRJj31P SfRZvP6wfcRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,349,1589266800"; d="scan'208";a="285598950" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 13 Jul 2020 19:04:24 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 19:04:23 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 19:04:23 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.135]) by shsmsx102.ccr.corp.intel.com ([169.254.2.43]) with mapi id 14.03.0439.000; Tue, 14 Jul 2020 10:04:20 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes Thread-Topic: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes Thread-Index: AQHWWX1doU6KgGamtU608Om+vfYZiqkGUriA Date: Tue, 14 Jul 2020 02:04:20 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C612C31@SHSMSX104.ccr.corp.intel.com> References: <20200714012259.30504-1-zhichao.gao@intel.com> <20200714012259.30504-4-zhichao.gao@intel.com> In-Reply-To: <20200714012259.30504-4-zhichao.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhichao, Can you add more information in the commit message on what bug the patch c= an fix? With that, Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Tuesday, July 14, 2020 9:23 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray > Subject: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add > already start check for child hanldes >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 >=20 > Treat the EFI_ALREADY_STARTED as EFI_SUCCESS to avoid the partition driv= er > continuely check next routine function. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Signed-off-by: Zhichao Gao > Reviewed-by: Hao A Wu > --- > MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > index d1c878ad2e..6a43c3cafb 100644 > --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > @@ -1276,6 +1276,15 @@ PartitionInstallChildHandle ( > } else { > FreePool (Private->DevicePath); > FreePool (Private); > + > + // > + // if the Status =3D=3D EFI_ALREADY_STARTED, it means the child han= dles > + // are already installed. So return EFI_SUCCESS to avoid do the nex= t > + // partition type check. > + // > + if (Status =3D=3D EFI_ALREADY_STARTED) { > + Status =3D EFI_SUCCESS; > + } > } >=20 > return Status; > -- > 2.21.0.windows.1 >=20 >=20 >=20