From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.14199.1594706496551067345 for ; Mon, 13 Jul 2020 23:01:36 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) IronPort-SDR: z9HcbxGRbxJ1sgOk2/gdhzGiaxl8JklL64iYPyB5IUknU6uyT0Pp4fht8i+1tyjk5sv4fJHCRe lkwbfAAAL6+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9681"; a="128906407" X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="128906407" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 23:01:35 -0700 IronPort-SDR: ovDGEExBKWC880ITB4McgXjUqHbpaQWcs8+adUrq4STuc/u+3ZnPhdsYyhIJKRe9M5MHHJUv2i Pe+JGYtZ4Nrg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="324450121" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 13 Jul 2020 23:01:35 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 23:01:35 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 23:01:35 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.135]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.32]) with mapi id 14.03.0439.000; Tue, 14 Jul 2020 14:01:32 +0800 From: "Ni, Ray" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes Thread-Topic: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes Thread-Index: AQHWWX1doU6KgGamtU608Om+vfYZiqkGUriA//+7JICAAIdTMA== Date: Tue, 14 Jul 2020 06:01:31 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C613085@SHSMSX104.ccr.corp.intel.com> References: <20200714012259.30504-1-zhichao.gao@intel.com> <20200714012259.30504-4-zhichao.gao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C612C31@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good to me! Thanks!! > -----Original Message----- > From: Gao, Zhichao > Sent: Tuesday, July 14, 2020 1:56 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Wu, Hao A > Subject: RE: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add > already start check for child hanldes >=20 > Sure. >=20 > Update the commit message here: >=20 > The partition binding driver would run serval times during BDS. If the p= artition > supports MBR, it would pass the first connect in the MBR routine functio= n. The > second connect would return already started which would be treated as no= t > found and continue to run next routine. That is incorrect behavior. The = device > should only support one partition format. Treat the already started as s= uccess > to avoid incorrect next partition routine check. >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Ni, Ray > > Sent: Tuesday, July 14, 2020 10:04 AM > > To: devel@edk2.groups.io; Gao, Zhichao > > Cc: Wu, Hao A > > Subject: RE: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Ad= d > > already start check for child hanldes > > > > Zhichao, > > Can you add more information in the commit message on what bug the pat= ch > > can fix? > > With that, Reviewed-by: Ray Ni > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of Gao, > > > Zhichao > > > Sent: Tuesday, July 14, 2020 9:23 AM > > > To: devel@edk2.groups.io > > > Cc: Wu, Hao A ; Ni, Ray > > > Subject: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add > > > already start check for child hanldes > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 > > > > > > Treat the EFI_ALREADY_STARTED as EFI_SUCCESS to avoid the partition > > > driver continuely check next routine function. > > > > > > Cc: Hao A Wu > > > Cc: Ray Ni > > > Signed-off-by: Zhichao Gao > > > Reviewed-by: Hao A Wu > > > --- > > > MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > > b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > > index d1c878ad2e..6a43c3cafb 100644 > > > --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > > +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > > @@ -1276,6 +1276,15 @@ PartitionInstallChildHandle ( > > > } else { > > > FreePool (Private->DevicePath); > > > FreePool (Private); > > > + > > > + // > > > + // if the Status =3D=3D EFI_ALREADY_STARTED, it means the child= handles > > > + // are already installed. So return EFI_SUCCESS to avoid do the= next > > > + // partition type check. > > > + // > > > + if (Status =3D=3D EFI_ALREADY_STARTED) { > > > + Status =3D EFI_SUCCESS; > > > + } > > > } > > > > > > return Status; > > > -- > > > 2.21.0.windows.1 > > > > > > > > >=20 > > >=20