Re: [edk2-devel] [PATCH v4 03/35] OvmfPkg: Introduce XenResetVector

["Laszlo Ersek" <lersek@redhat.com>]

On 07/29/19 17:39, Anthony PERARD wrote:
> Introduce XenResetVector, a copy of OvmfPkg/ResetVector, with one
> changes:
>   - SEC_DEFAULT_CR0: enable cache (bit 30 or CD set to 0)
> 
> Xen copies the OVMF code to RAM, there is no need to disable cache.
> 
> This new module will later be modified to add a new entry point, more
> detail in a following commit "OvmfPkg/XenResetVector: Add new entry point
> for Xen PVH"
> 
> Value FILE_GUID of XenResetVector have not changed compare to ResetVector
> because it is a special value (gEfiFirmwareVolumeTopFileGuid).
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     v4:
>     - Update Maintainers.txt
>     
>     v3:
>       - Added gEfiFirmwareVolumeTopFileGuid to the commit message.
>       - rebased: SPDX
> 
>  OvmfPkg/OvmfXen.dsc                           |   2 +-
>  OvmfPkg/OvmfXen.fdf                           |   2 +-
>  OvmfPkg/XenResetVector/XenResetVector.inf     |  38 +++++
>  Maintainers.txt                               |   1 +
>  .../XenResetVector/Ia16/Real16ToFlat32.asm    | 134 ++++++++++++++++
>  OvmfPkg/XenResetVector/Ia32/PageTables64.asm  | 149 ++++++++++++++++++
>  OvmfPkg/XenResetVector/XenResetVector.nasmb   |  68 ++++++++
>  7 files changed, 392 insertions(+), 2 deletions(-)
>  create mode 100644 OvmfPkg/XenResetVector/XenResetVector.inf
>  create mode 100644 OvmfPkg/XenResetVector/Ia16/Real16ToFlat32.asm
>  create mode 100644 OvmfPkg/XenResetVector/Ia32/PageTables64.asm
>  create mode 100644 OvmfPkg/XenResetVector/XenResetVector.nasmb

[...]

> diff --git a/Maintainers.txt b/Maintainers.txt
> index 98f6d828eb..34bdb275b4 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -380,6 +380,7 @@ F: OvmfPkg/SmbiosPlatformDxe/*Xen.c
>  F: OvmfPkg/XenBusDxe/
>  F: OvmfPkg/XenIoPciDxe/
>  F: OvmfPkg/XenPvBlkDxe/
> +F: OvmfPkg/XenResetVector/
>  R: Anthony Perard <anthony.perard@citrix.com>
>  R: Julien Grall <julien.grall@arm.com>
>  

Reviewed-by: Laszlo Ersek <lersek@redhat.com>