From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 30 Jul 2019 02:16:23 -0700 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 196E1B0CCB; Tue, 30 Jul 2019 09:16:23 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3DC460922; Tue, 30 Jul 2019 09:16:21 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v4 03/35] OvmfPkg: Introduce XenResetVector To: devel@edk2.groups.io, anthony.perard@citrix.com Cc: Julien Grall , xen-devel@lists.xenproject.org, Jordan Justen , Ard Biesheuvel References: <20190729153944.24239-1-anthony.perard@citrix.com> <20190729153944.24239-4-anthony.perard@citrix.com> From: "Laszlo Ersek" Message-ID: <735a50d9-feaa-9270-71e6-fb89f672d4fb@redhat.com> Date: Tue, 30 Jul 2019 11:16:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190729153944.24239-4-anthony.perard@citrix.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 30 Jul 2019 09:16:23 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/29/19 17:39, Anthony PERARD wrote: > Introduce XenResetVector, a copy of OvmfPkg/ResetVector, with one > changes: > - SEC_DEFAULT_CR0: enable cache (bit 30 or CD set to 0) > > Xen copies the OVMF code to RAM, there is no need to disable cache. > > This new module will later be modified to add a new entry point, more > detail in a following commit "OvmfPkg/XenResetVector: Add new entry point > for Xen PVH" > > Value FILE_GUID of XenResetVector have not changed compare to ResetVector > because it is a special value (gEfiFirmwareVolumeTopFileGuid). > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Reviewed-by: Laszlo Ersek > --- > > Notes: > v4: > - Update Maintainers.txt > > v3: > - Added gEfiFirmwareVolumeTopFileGuid to the commit message. > - rebased: SPDX > > OvmfPkg/OvmfXen.dsc | 2 +- > OvmfPkg/OvmfXen.fdf | 2 +- > OvmfPkg/XenResetVector/XenResetVector.inf | 38 +++++ > Maintainers.txt | 1 + > .../XenResetVector/Ia16/Real16ToFlat32.asm | 134 ++++++++++++++++ > OvmfPkg/XenResetVector/Ia32/PageTables64.asm | 149 ++++++++++++++++++ > OvmfPkg/XenResetVector/XenResetVector.nasmb | 68 ++++++++ > 7 files changed, 392 insertions(+), 2 deletions(-) > create mode 100644 OvmfPkg/XenResetVector/XenResetVector.inf > create mode 100644 OvmfPkg/XenResetVector/Ia16/Real16ToFlat32.asm > create mode 100644 OvmfPkg/XenResetVector/Ia32/PageTables64.asm > create mode 100644 OvmfPkg/XenResetVector/XenResetVector.nasmb [...] > diff --git a/Maintainers.txt b/Maintainers.txt > index 98f6d828eb..34bdb275b4 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -380,6 +380,7 @@ F: OvmfPkg/SmbiosPlatformDxe/*Xen.c > F: OvmfPkg/XenBusDxe/ > F: OvmfPkg/XenIoPciDxe/ > F: OvmfPkg/XenPvBlkDxe/ > +F: OvmfPkg/XenResetVector/ > R: Anthony Perard > R: Julien Grall > Reviewed-by: Laszlo Ersek