From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D180694185A for ; Fri, 1 Mar 2024 16:34:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=R1PJdH3oJOsVJQBtW1/X/fPDeApquqjqEIl4VD8ydxc=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709310851; v=1; b=AX6TJTEiSqrlJUNqM7SDw+YXztD/YgHwZWj+5m9VUxXGpUZXAsPEBO6VAc2bfRZsER2bLDUy GG9C/gy9b/k0kaGJVsRNMXXwdIaO54O+BhRW3YXH+O+wITdTA3CgW7HZC6DyZAc/C+9UpBcLwZ2 jwm7uXOFWpy9nIgsgKwfQCsw= X-Received: by 127.0.0.2 with SMTP id 5SLAYY7687511xCk5cdWBv3V; Fri, 01 Mar 2024 08:34:11 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.28038.1709310850968663382 for ; Fri, 01 Mar 2024 08:34:11 -0800 X-Received: from [100.65.0.75] (unknown [172.171.236.24]) by linux.microsoft.com (Postfix) with ESMTPSA id 4377420B74C0; Fri, 1 Mar 2024 08:34:10 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4377420B74C0 Message-ID: <737ac314-ecde-4c53-a155-9b17fddcac34@linux.microsoft.com> Date: Fri, 1 Mar 2024 11:34:09 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IFtlZGsyLWRldmVsXSDlm57lpI06IFtQQVRDSCB2MV0gTWRlTW9kdWxlUGtnL0NvcmUvUGVpOiBJbXByb3ZlIHRoZSBjb3B5IHBlcmZvcm1hbmNl?= To: gaoliming , 'Zhihao Li' , devel@edk2.groups.io References: <20240301071147.519-1-zhihao.li@intel.com> <02d901da6bd8$34e51fb0$9eaf5f10$@byosoft.com.cn> From: "Michael Kubacki" In-Reply-To: <02d901da6bd8$34e51fb0$9eaf5f10$@byosoft.com.cn> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AtJ5oo6qrcdmWQelTetjF8z9x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=AX6TJTEi; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io This looks fine. Reviewed-by: Michael Kubacki On 3/1/2024 7:58 AM, gaoliming wrote: > I agree this change. It should have no negative impact. Reviewed-by: Limi= ng > Gao >=20 > Michael: > Have you any comments for this change? >=20 > Thanks > Liming >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: Zhihao Li >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B43=E6=9C=881=E6=97=A5 = 15:12 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io >> =E6=8A=84=E9=80=81: Liming Gao >> =E4=B8=BB=E9=A2=98: [PATCH v1] MdeModulePkg/Core/Pei: Improve the copy p= erformance >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4697 >> >> EvacuateTempRam function will copy the temporary memory context to the >> rebased >> pages and the raw pages. Migrations of rebased PEIMs is from cache to >> memory, >> while raw PEIMs is from memory to memory. So the migrations of raw PEIMs >> is slower than rebased PEIMs. Experimental data indicates that changing > the >> source >> address of raw PEIMs migration will improve performance by 35%. >> >> Cc: Liming Gao >> Signed-off-by: Zhihao Li >> --- >> MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c >> b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c >> index 4cd8c843cd..ca37bde482 100644 >> --- a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c >> +++ b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c >> @@ -1,7 +1,7 @@ >> /** @file >> EFI PEI Core dispatch services >> >> -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
>> +Copyright (c) 2006 - 2024, Intel Corporation. All rights reserved.
>> (C) Copyright 2016 Hewlett Packard Enterprise Development LP
>> SPDX-License-Identifier: BSD-2-Clause-Patent >> >> @@ -1305,7 +1305,7 @@ EvacuateTempRam ( >> ); >> ASSERT_EFI_ERROR (Status); >> RawDataFvHeader =3D (EFI_FIRMWARE_VOLUME_HEADER >> *)(UINTN)FvHeaderAddress; >> - CopyMem (RawDataFvHeader, MigratedFvHeader, >> (UINTN)FvHeader->FvLength); >> + CopyMem (RawDataFvHeader, FvHeader, >> (UINTN)FvHeader->FvLength); >> MigratedFvInfo.FvDataBase =3D >> (UINT32)(UINTN)RawDataFvHeader; >> } >> >> -- >> 2.26.2.windows.1 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116278): https://edk2.groups.io/g/devel/message/116278 Mute This Topic: https://groups.io/mt/104662794/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-