From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.1876.1593792118339672377 for ; Fri, 03 Jul 2020 09:01:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KV9tY5jq; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593792117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KPK+EvuXonujE5k9sPZZBMUVzED7VoOmclog8sfMWGE=; b=KV9tY5jqvAL9Qs2f3pdpGX6HZIKDtQckX4c6tM5yt/wbm8hZ5CQBwkxYKXX9bn4X3ul6xZ OpKybRPbdA4FryobYLqzF2zd0RKK581mEJDG9xdC+t865T93wG/10H6JGbCBCewA3oEDYz VpgYD+Zj8imHyIqqRorPhIkROJG8t3Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-329-TP2FXU4MMIuO2HhLyQY49Q-1; Fri, 03 Jul 2020 12:01:40 -0400 X-MC-Unique: TP2FXU4MMIuO2HhLyQY49Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 56BE21005510; Fri, 3 Jul 2020 16:01:38 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-238.ams2.redhat.com [10.36.114.238]) by smtp.corp.redhat.com (Postfix) with ESMTP id 69A5D5BAD3; Fri, 3 Jul 2020 16:01:35 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci To: "Gao, Liming" , "devel@edk2.groups.io" , "Zhang, Shenglei" , Leif Lindholm , "afish@apple.com" Cc: "Feng, Bob C" , Bret Barkelew , "Kinney, Michael D" , Sean Brogan References: <20200701015516.17108-1-shenglei.zhang@intel.com> From: "Laszlo Ersek" Message-ID: <737e5880-aadb-5f08-cd91-9f13dcbf9bf0@redhat.com> Date: Fri, 3 Jul 2020 18:01:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi Liming, On 07/03/20 17:13, Gao, Liming wrote: > Include more people and collect the comments. > > ECC is the source file coding style checker. Here is its wiki page https://github.com/tianocore/tianocore.github.io/wiki/ECC-tool. > If the changed code doesn't follow edk2 coding style, ECC will report the error. > > This patch set enables ECC checker in open CI for each patch coming into edk2 repo. That means new changes need to follow edk2 coding style. > Otherwise, new changes can't be merged. > > If you have some comments for ECC checker in open CI, please reply this mail. (1) The ArmVirtPkg (v6 04/16) and OvmfPkg (v6 11/16) patches already carry my ACKs; from here: https://edk2.groups.io/g/devel/message/61154 https://edk2.groups.io/g/devel/message/61155 (2) The UefiCpuPkg patch (v6 15/16) *should* also carry my ACK, from here: https://edk2.groups.io/g/devel/message/61156 Shenglei picked up my ACK for v4 and v5: https://edk2.groups.io/g/devel/message/61283 https://edk2.groups.io/g/devel/message/61852 but then dropped it for v6: https://edk2.groups.io/g/devel/message/61894 Shenglei, can you please explain why you dropped my ACK from the UefiCpuPkg patch, in v6? (3) The initial discussion between Shenglei and myself are under the v2 posting: https://edk2.groups.io/g/devel/message/60665 https://edk2.groups.io/g/devel/message/60711 https://edk2.groups.io/g/devel/message/60961 I'm happy with this work because it lets package maintainers tailor ECC as they see appropriate. Thanks, Laszlo