From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mx.groups.io with SMTP id smtpd.web09.841.1624496081647853026 for ; Wed, 23 Jun 2021 17:54:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fJcsWRQd; spf=pass (domain: gmail.com, ip: 209.85.210.170, mailfrom: kuqin12@gmail.com) Received: by mail-pf1-f170.google.com with SMTP id y4so3720180pfi.9 for ; Wed, 23 Jun 2021 17:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=I2a8HyM/rFTMgVHltvzn0FllvCf1PWXbB2jod4SWO/c=; b=fJcsWRQdAelgwZ7OEwuhIWi2IR1DeK0Ca0Yc5ODU20nmlbYG3XTMA1ZuhY7teloyAM ukZoPS/5uC9fJURNYIi1W8WPkCdd0NAlHu+Oee5Ak7Selt57H7FmMJm21PST5he6Zw65 wXPikhv2oykaMuG0YW9gn3THaw4UG9oqd19TSVhAYbQlcHdBMZgn5EP1Q9irGCIYv2LL 7ALWVDMc4Bsy3T1KlQJat/wm+d45ijCoq5CX+yYMk+hRY3d0OnvMcouhlwpWJpF2Dahh GBIzwLJbTYBc6WuH/nq6oIQ6PRrNw0D12667RRuhXszTT93FX0bBys+5uZwE4gomeDxa rTjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I2a8HyM/rFTMgVHltvzn0FllvCf1PWXbB2jod4SWO/c=; b=WUWqvNgcaW1guoSC9MzCSvAxCmp2JY07/PjKSN6glv4MkjtwWI9fWIRiyXgzmA5oE3 eLYMpJe2Fm1Es3WdbTwZ5HyCUCm8dtO0JrvV5w38enLrfa1B+7B3fRJ4Mb1BzCJlOM67 w2oR2clP2zEtM5SiZcQDDmFKxMBl32uiDXxuIEa464FWjVKcohYY+Yd8rYLB4vwkRGam pgNTuUJ6XKWhvguRkoG2TNdBM2i2hsAYs6SrFBsGXxOSvGl9GZxz7T4gN/lWy2A/DXXP QHrwwaCw4mOa5n+xowrT67dZryivP3TaZawHzmLiKODSdtPLwhwGyiCxIc0MkfeM24H5 Nqug== X-Gm-Message-State: AOAM53251x3jLyjYKMVQ4491mln0uiW+OS3McY+Bfsg5FNFQLWdu2jO/ DYKonWQ/g2PwFOJq4xMRmEw= X-Google-Smtp-Source: ABdhPJxbHAs1wuSvVk8o3K6IHefIQwhVxItVr1J4EoVwNlp3NVUZ7nXF+Ha+2Rc5jvguJAIgLEg/9w== X-Received: by 2002:a63:d0d:: with SMTP id c13mr2206135pgl.384.1624496081314; Wed, 23 Jun 2021 17:54:41 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id 20sm881391pfi.170.2021.06.23.17.54.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 17:54:40 -0700 (PDT) Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCB2MSAxLzJdIE1kZVBrZzogTW1Db25maWd1cmF0aW9uOiBNb3ZlZCBFRklfTU1fUkVTRVJWRURfTU1SQU1fUkVHSU9OIHRvIFBpTW1DaXMuaA==?= To: gaoliming , devel@edk2.groups.io Cc: 'Michael D Kinney' , 'Zhiguang Liu' , 'Michael Kubacki' References: <20210618094829.2651-1-kuqin12@gmail.com> <20210618094829.2651-2-kuqin12@gmail.com> <007501d7663b$f03110d0$d0933270$@byosoft.com.cn> From: "Kun Qin" Message-ID: <73cf51e4-e973-4fc2-74f3-ba399c32501d@gmail.com> Date: Wed, 23 Jun 2021 17:54:40 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <007501d7663b$f03110d0$d0933270$@byosoft.com.cn> Content-Type: text/plain; charset=gbk; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Liming, Thanks for pointing it out. I will updated the patches shortly. Regards, Kun On 06/20/2021 18:22, gaoliming wrote: > Kun: > There is one header file edk2\MdePkg\Include\PiMultiPhase.h for this > purpose. Can you place the common definition to it? > > Thanks > Liming >> -----邮件原件----- >> 发件人: devel@edk2.groups.io 代表 Kun Qin >> 发送时间: 2021年6月18日 17:48 >> 收件人: devel@edk2.groups.io >> 抄送: Michael D Kinney ; Liming Gao >> ; Zhiguang Liu ; >> Michael Kubacki >> 主题: [edk2-devel] [PATCH v1 1/2] MdePkg: MmConfiguration: Moved >> EFI_MM_RESERVED_MMRAM_REGION to PiMmCis.h >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3440 >> >> The definition of EFI_MM_RESERVED_MMRAM_REGION, according to PI Spec >> 1.5 >> is also referenced in EFI_PEI_MM_CONFIGURATION_PPI. Defining this >> structure as is will enforce any potential usage of MM Configuration PPI >> interface to include . >> >> This change moves EFI_MM_RESERVED_MMRAM_REGION definition into >> PiMmCis.h, >> which is already included in Protocol/MmConfiguration.h. It also paves >> way for introducing Ppi/MmConfiguration.h with proper dependency. >> >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Zhiguang Liu >> Cc: Michael Kubacki >> >> Signed-off-by: Kun Qin >> --- >> MdePkg/Include/Pi/PiMmCis.h | 16 ++++++++++++++++ >> MdePkg/Include/Protocol/MmConfiguration.h | 16 ---------------- >> 2 files changed, 16 insertions(+), 16 deletions(-) >> >> diff --git a/MdePkg/Include/Pi/PiMmCis.h b/MdePkg/Include/Pi/PiMmCis.h >> index fdf0591a03d6..422a3ea6c2bb 100644 >> --- a/MdePkg/Include/Pi/PiMmCis.h >> +++ b/MdePkg/Include/Pi/PiMmCis.h >> @@ -242,6 +242,22 @@ VOID >> IN CONST EFI_MM_ENTRY_CONTEXT *MmEntryContext >> ); >> >> +/// >> +/// Structure describing a MMRAM region which cannot be used for the >> MMRAM heap. >> +/// >> +typedef struct _EFI_MM_RESERVED_MMRAM_REGION { >> + /// >> + /// Starting address of the reserved MMRAM area, as it appears while >> MMRAM is open. >> + /// Ignored if MmramReservedSize is 0. >> + /// >> + EFI_PHYSICAL_ADDRESS MmramReservedStart; >> + /// >> + /// Number of bytes occupied by the reserved MMRAM area. A size of >> zero indicates the >> + /// last MMRAM area. >> + /// >> + UINT64 MmramReservedSize; >> +} EFI_MM_RESERVED_MMRAM_REGION; >> + >> /// >> /// Management Mode System Table (MMST) >> /// >> diff --git a/MdePkg/Include/Protocol/MmConfiguration.h >> b/MdePkg/Include/Protocol/MmConfiguration.h >> index eeb94f64bdf7..d2fb6a13d4af 100644 >> --- a/MdePkg/Include/Protocol/MmConfiguration.h >> +++ b/MdePkg/Include/Protocol/MmConfiguration.h >> @@ -21,22 +21,6 @@ >> 0x26eeb3de, 0xb689, 0x492e, {0x80, 0xf0, 0xbe, 0x8b, 0xd7, 0xda, > 0x4b, >> 0xa7 } \ >> } >> >> -/// >> -/// Structure describing a MMRAM region which cannot be used for the >> MMRAM heap. >> -/// >> -typedef struct _EFI_MM_RESERVED_MMRAM_REGION { >> - /// >> - /// Starting address of the reserved MMRAM area, as it appears while >> MMRAM is open. >> - /// Ignored if MmramReservedSize is 0. >> - /// >> - EFI_PHYSICAL_ADDRESS MmramReservedStart; >> - /// >> - /// Number of bytes occupied by the reserved MMRAM area. A size of >> zero indicates the >> - /// last MMRAM area. >> - /// >> - UINT64 MmramReservedSize; >> -} EFI_MM_RESERVED_MMRAM_REGION; >> - >> typedef struct _EFI_MM_CONFIGURATION_PROTOCOL >> EFI_MM_CONFIGURATION_PROTOCOL; >> >> /** >> -- >> 2.31.1.windows.1 >> >> >> >> >> > > >