Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

Hi Liming, Rebecca.

On 4/11/19 3:52 PM, Liming Gao wrote:
> Phil:
>   I use Outlook to receive the patch mail, and save as mail file. This file shows From: Rebecca Cran via Groups.Io <rebecca=bluestop.org@groups.io>. So, I use it as patch author. I also check my patch with the same way. It shows From: Liming Gao <liming.gao@intel.com>. This is correct. So, I don't know this is user setting issue or group.io issue. 

On https://edk2.groups.io/g/devel/editprofile

So on Groups.Io I went to
- Your groups
  -> EDK2
     -> devel
        -> Suscription
           -> Group Profile
              -> Edit Group Profile

I see 2 fields:

- User Name
- Display Name

The latter field is described as:

  The name listed with your posts. Note: When you post,
  your email address is also shown to group members who
  receive messages via email.

My guess is Groups.Io rewrites the sender From if an user change one of
these fields.

Rebecca: do you remember if you modified something in your profile?
How are you sending your patches to the list?

Sorry you became our 'patches via groups.io' guinea pig ;)

Thanks,

Phil.

> Thanks
> Liming
>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Philippe Mathieu-Daudé
>> Sent: Thursday, April 11, 2019 6:59 PM
>> To: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>
>> Cc: devel@edk2.groups.io; rebecca@bluestop.org; Stephano Cetola <stephano.cetola@linux.intel.com>
>> Subject: Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output
>>
>> Hi Liming,
>>
>> On 4/11/19 2:32 AM, Liming Gao wrote:
>>> Push on commit ddb8cedce7e07b87c0ac6b84cd750a6d3dac47c8
>>
>> I see in the git history the authorship passed
>> from: rebecca@bluestop.org <rebecca@bluestop.org>
>> to: Rebecca Cran via Groups.Io <rebecca=bluestop.org@groups.io>
>>
>> I wonder if we shouldn't block pushes until the
>> BaseTools/Scripts/PatchCheck.py tool get fixed to avoid such mistakes
>> which are likely to get reproduced now that we switched to Groups.Io.
>>
>> Thoughts?
>>
>> Regards,
>>
>> Phil.
>>
>>>> -----Original Message-----
>>>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>>>> Liming Gao
>>>> Sent: Monday, April 08, 2019 9:16 PM
>>>> To: Philippe Mathieu-Daudé <philmd@redhat.com>; rebecca@bluestop.org
>>>> Cc: devel@edk2.groups.io
>>>> Subject: Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments
>>>> and improve E820 debug output
>>>>
>>>> Reviewed-by: Liming Gao <liming.gao@intel.com>
>>>>
>>>>> -----Original Message-----
>>>>> From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com]
>>>>> Sent: Friday, April 5, 2019 5:05 PM
>>>>> To: rebecca@bluestop.org; Gao, Liming <liming.gao@intel.com>
>>>>> Cc: devel@edk2.groups.io
>>>>> Subject: Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix
>>>> comments and improve E820 debug output
>>>>>
>>>>> On 4/4/19 7:56 PM, Rebecca Cran via Groups.Io wrote:
>>>>>> Fix a few typos in LegacyBiosBuildE820, and improve the debug output of
>>>>>> the E820 table to pad with zeros instead of spaces, remove extra hyphens
>>>>>> and display the memory type in decimal.
>>>>>>
>>>>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>>>>> Signed-off-by: Rebecca Cran <rebecca@bluestop.org>
>>>>>
>>>>> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>>>>>
>>>>>> ---
[...]