From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 37EDBAC0D62 for ; Tue, 27 Feb 2024 09:46:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=cM99zmfqb5oo171+qw9LTwLVdrFGAN7wE0Zz5m6OmgQ=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1709027215; v=1; b=lhMaHj/PV0qNkztg8OO/iGUyPysfg3+LiSVBHwh4PYLtZK0c5JvjXtCI1MO3Da04xv/Pn8dA 7XAUVUGencWNiu3TtcIdAe78jDXXJZajEzhMtGDTh7Qa5bTN9xfba3zVZjCEy16Q8tv+JDNqWLC O/TXpCxb1Wj3jCeCRJdcyhoo= X-Received: by 127.0.0.2 with SMTP id GhtyYY7687511x0K2guyQ0Nc; Tue, 27 Feb 2024 01:46:55 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.9009.1709027214974820563 for ; Tue, 27 Feb 2024 01:46:55 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-oVplrF-JMaWV34buzeSJqw-1; Tue, 27 Feb 2024 04:46:49 -0500 X-MC-Unique: oVplrF-JMaWV34buzeSJqw-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6A1E2892D05; Tue, 27 Feb 2024 09:46:48 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D0039492BD7; Tue, 27 Feb 2024 09:46:47 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id CE66018009BA; Tue, 27 Feb 2024 10:46:46 +0100 (CET) Date: Tue, 27 Feb 2024 10:46:46 +0100 From: "Gerd Hoffmann" To: Tom Lendacky Cc: devel@edk2.groups.io, Ard Biesheuvel , Erdem Aktas , Jiewen Yao , Laszlo Ersek , Liming Gao , Michael D Kinney , Min Xu , Zhiguang Liu , Rahul Kumar , Ray Ni , Michael Roth Subject: Re: [edk2-devel] [PATCH v2 01/23] OvmfPkg/BaseMemEncryptLib: Fix error check from AsmRmpAdjust() Message-ID: <73escwvohzhs7bubyzpo6gafv4giz7jq3x34kkhq4rtcjgvs4f@vs6h3w3okk46> References: <9c849da1a38577043c512eca4ed9c9e15d0c0941.1708623001.git.thomas.lendacky@amd.com> MIME-Version: 1.0 In-Reply-To: <9c849da1a38577043c512eca4ed9c9e15d0c0941.1708623001.git.thomas.lendacky@amd.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: shkCaj08PIf68Ezb7gIOCnRax7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="lhMaHj/P"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, Feb 22, 2024 at 11:29:40AM -0600, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 > > The AsmRmpAdjust() function returns a UINT32, however in SevSnpIsVmpl0() > the return value is checked with EFI_ERROR() when it should just be > compared to 0. Fix the error check. > > Signed-off-by: Tom Lendacky Reviewed-by: Gerd Hoffmann -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116014): https://edk2.groups.io/g/devel/message/116014 Mute This Topic: https://groups.io/mt/104512928/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-