public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: ray.ni@intel.com
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 0/5] restrict memory access per PcdCpuSmmRestrictedMemoryAccess
Date: Fri, 20 Sep 2019 10:44:43 +0200	[thread overview]
Message-ID: <7401f1d9-53e5-109d-90ea-6bd3f9741c72@redhat.com> (raw)
In-Reply-To: <20190825224513.171572-1-ray.ni@intel.com>

Hi Ray,

On 08/26/19 00:45, Ni, Ray wrote:
> NOTE: #5/5 will be pushed in 2nd phase after known close-source code in another
> repo is updated to use the new PCD PcdCpuSmmRestrictedMemoryAccess.

you've now pushed patch 5/5 as commit 136dad095660, but you forgot to
update the UNI file, which is what I requested here:

  https://edk2.groups.io/g/devel/message/46364

Right now we have:

$ git grep -l PcdCpuSmmStaticPageTable
UefiCpuPkg/UefiCpuPkg.uni

Please send a follow-up patch for the UNI file.

Thanks,
Laszlo

> Ray Ni (5):
>   UefiCpuPkg: Add PcdCpuSmmRestrictedMemoryAccess
>   UefiCpuPkg/PiSmmCpu: Use new PCD PcdCpuSmmRestrictedMemoryAccess
>   UefiCpuPkg/PiSmmCpu: Restrict access per
>     PcdCpuSmmRestrictedMemoryAccess
>   UefiCpuPkg: Explain relationship between several SMM PCDs
>   UefiCpuPkg: Remove PcdCpuSmmStaticPageTable
> 
>  UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c     | 14 +++++
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c   | 18 +++---
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h   | 11 ++++
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf |  4 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c      | 66 +++++++++++++-------
>  UefiCpuPkg/UefiCpuPkg.dec                    | 31 +++++----
>  6 files changed, 102 insertions(+), 42 deletions(-)
> 


  parent reply	other threads:[~2019-09-20  8:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-25 22:45 [PATCH 0/5] restrict memory access per PcdCpuSmmRestrictedMemoryAccess Ni, Ray
2019-08-25 22:45 ` [PATCH 1/5] UefiCpuPkg: Add PcdCpuSmmRestrictedMemoryAccess Ni, Ray
2019-08-26 17:09   ` [edk2-devel] " Laszlo Ersek
2019-08-27  1:43   ` Dong, Eric
2019-08-25 22:45 ` [PATCH 2/5] UefiCpuPkg/PiSmmCpu: Use new PCD PcdCpuSmmRestrictedMemoryAccess Ni, Ray
2019-08-26 17:12   ` [edk2-devel] " Laszlo Ersek
2019-08-27  1:43   ` Dong, Eric
2019-08-25 22:45 ` [PATCH 3/5] UefiCpuPkg/PiSmmCpu: Restrict access per PcdCpuSmmRestrictedMemoryAccess Ni, Ray
2019-08-26 17:16   ` [edk2-devel] " Laszlo Ersek
2019-08-27  1:43   ` Dong, Eric
2019-08-25 22:45 ` [PATCH 4/5] UefiCpuPkg: Explain relationship between several SMM PCDs Ni, Ray
2019-08-26 17:38   ` [edk2-devel] " Laszlo Ersek
2019-08-27  1:47   ` Dong, Eric
2019-08-25 22:45 ` [PATCH 5/5] UefiCpuPkg: Remove PcdCpuSmmStaticPageTable Ni, Ray
2019-08-26 17:39   ` [edk2-devel] " Laszlo Ersek
2019-08-27  1:47   ` Dong, Eric
2019-09-20  8:44 ` Laszlo Ersek [this message]
2019-09-21  2:53   ` [edk2-devel] [PATCH 0/5] restrict memory access per PcdCpuSmmRestrictedMemoryAccess Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7401f1d9-53e5-109d-90ea-6bd3f9741c72@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox