From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Fri, 20 Sep 2019 01:44:45 -0700
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 85D6C3099F9F;
	Fri, 20 Sep 2019 08:44:44 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-165.rdu2.redhat.com [10.10.120.165])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 0830C60920;
	Fri, 20 Sep 2019 08:44:43 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 0/5] restrict memory access per PcdCpuSmmRestrictedMemoryAccess
To: ray.ni@intel.com
References: <20190825224513.171572-1-ray.ni@intel.com>
Cc: devel@edk2.groups.io
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <7401f1d9-53e5-109d-90ea-6bd3f9741c72@redhat.com>
Date: Fri, 20 Sep 2019 10:44:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190825224513.171572-1-ray.ni@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 20 Sep 2019 08:44:44 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Ray,

On 08/26/19 00:45, Ni, Ray wrote:
> NOTE: #5/5 will be pushed in 2nd phase after known close-source code in another
> repo is updated to use the new PCD PcdCpuSmmRestrictedMemoryAccess.

you've now pushed patch 5/5 as commit 136dad095660, but you forgot to
update the UNI file, which is what I requested here:

  https://edk2.groups.io/g/devel/message/46364

Right now we have:

$ git grep -l PcdCpuSmmStaticPageTable
UefiCpuPkg/UefiCpuPkg.uni

Please send a follow-up patch for the UNI file.

Thanks,
Laszlo

> Ray Ni (5):
>   UefiCpuPkg: Add PcdCpuSmmRestrictedMemoryAccess
>   UefiCpuPkg/PiSmmCpu: Use new PCD PcdCpuSmmRestrictedMemoryAccess
>   UefiCpuPkg/PiSmmCpu: Restrict access per
>     PcdCpuSmmRestrictedMemoryAccess
>   UefiCpuPkg: Explain relationship between several SMM PCDs
>   UefiCpuPkg: Remove PcdCpuSmmStaticPageTable
> 
>  UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c     | 14 +++++
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c   | 18 +++---
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h   | 11 ++++
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf |  4 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c      | 66 +++++++++++++-------
>  UefiCpuPkg/UefiCpuPkg.dec                    | 31 +++++----
>  6 files changed, 102 insertions(+), 42 deletions(-)
>