From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C049E821B6 for ; Wed, 1 Mar 2017 11:05:15 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5525F80467; Wed, 1 Mar 2017 19:05:16 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-249.phx2.redhat.com [10.3.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id 54CBC2D655; Wed, 1 Mar 2017 19:05:15 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@ml01.01.org, leif.lindholm@linaro.org References: <1488379344-16273-1-git-send-email-ard.biesheuvel@linaro.org> <1488379344-16273-5-git-send-email-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <740ae2e5-d435-eb08-1732-d00af95ea844@redhat.com> Date: Wed, 1 Mar 2017 20:05:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1488379344-16273-5-git-send-email-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 01 Mar 2017 19:05:16 +0000 (UTC) Subject: Re: [PATCH 4/4] ArmVirtPkg: enable PE/COFF image and memory protection for ARM platforms X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 19:05:15 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/01/17 15:42, Ard Biesheuvel wrote: > Like for AARCH64, enable PE/COFF image and NX memory protection for all > 32-bit ARM virt platforms. > > Note that this does not [yet] protect EfiLoaderData regions, due to > compatibility issues with GRUB. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirt.dsc.inc | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index a91b27f13cf2..acfb71d3ff6c 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -18,7 +18,7 @@ [Defines] > DEFINE TTY_TERMINAL = FALSE > > [BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI_APPLICATION] > - GCC:*_*_AARCH64_DLINK_FLAGS = -z common-page-size=0x1000 > + GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > > [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > GCC:*_*_ARM_DLINK_FLAGS = -z common-page-size=0x1000 > @@ -373,10 +373,6 @@ [PcdsFixedAtBuild.common] > gArmVirtTokenSpaceGuid.PcdTerminalTypeGuidBuffer|{0x80, 0x6d, 0x91, 0x7d, 0xb1, 0x5b, 0x8c, 0x45, 0xa4, 0x8f, 0xe2, 0x5f, 0xdd, 0x51, 0xef, 0x94} > !endif > > -[PcdsFixedAtBuild.ARM] > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40 > - > -[PcdsFixedAtBuild.AARCH64] > # > # Enable strict image permissions for all images. (This applies > # only to images that were built with >= 4 KB section alignment.) > @@ -390,6 +386,9 @@ [PcdsFixedAtBuild.AARCH64] > # > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeNxMemoryProtectionPolicy|0xC000000000007FD1 > > +[PcdsFixedAtBuild.ARM] > + gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40 > + > [Components.common] > # > # Networking stack > Reviewed-by: Laszlo Ersek