From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.56709.1669927423448997964 for ; Thu, 01 Dec 2022 12:43:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=SmSDSVKI; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id E4EB020B83C2; Thu, 1 Dec 2022 12:43:40 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E4EB020B83C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1669927423; bh=zo1ifcgLWyH2XTUXV0NQSuAkBwHZ/cSf3CX+5txICKU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SmSDSVKIsLpOSG+9vF03YHGnj2WjH0Z0qqdsWBqGXPDRMcPJYpJJbbCcUfgxzXmjQ CpF2TfFFQ9cFYRRCssu4TiFXgJiMaIweR1S88vahYGhkH1ABU700bqV6tociWuxns2 nqS0t5xEBH10fY4XtQ1LALXudOCHufvZNHcEuG6w= Message-ID: <74121c44-84fe-e53e-c447-ad15d926c1d7@linux.microsoft.com> Date: Thu, 1 Dec 2022 15:43:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [edk2-devel] [PATCH v10 10/17] OvmfPkg: CI: Use Fedora 35 container (Linux only) To: devel@edk2.groups.io, osteffen@redhat.com Cc: Andrew Fish , Ard Biesheuvel , Bob Feng , Daniel Schaefer , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Leif Lindholm , Liming Gao , Michael D Kinney , Ray Ni , Sami Mujawar , Sean Brogan , Sunil V L , Yuwei Chen , Zhiguang Liu , Pawel Polawski , Chris Fernald References: <20221201202810.109662-1-osteffen@redhat.com> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Michael Kubacki On 12/1/2022 3:28 PM, Oliver Steffen wrote: > Run all Linux based jobs in a container, using a custom Fedora 35 image > (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are > here: https://github.com/tianocore/containers > The version numbers of gcc, iasl, and nasm are pinned to avoid > unintended upgrades during image rebuild. > > Do not run apt-get in CI jobs to install qemu and gcc dependencies. > Assume the container image provides these. > > Use Python from the container image, do not download at runtime. > > Signed-off-by: Oliver Steffen > --- > OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > index 6dd90711ac70..984782aa7d19 100644 > --- a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > +++ b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > @@ -15,9 +15,6 @@ pr: > - master > - stable/* > > -variables: > - - template: ../../../.azurepipelines/templates/defaults.yml > - > jobs: > - job: Platform_CI > variables: > @@ -180,6 +177,8 @@ jobs: > pool: > vmImage: $(vm_image) > > + container: 'ghcr.io/tianocore/containers/fedora-35-test:2113a0e' > + > steps: > - template: ../../../.azurepipelines/templates/platform-build-run-steps.yml > parameters: > @@ -190,8 +189,4 @@ jobs: > build_file: $(Build.File) > build_flags: $(Build.Flags) > run_flags: $(Run.Flags) > - usePythonVersion: ${{ variables.default_python_version }} > - extra_install_step: > - - bash: sudo apt-get install qemu > - displayName: Install qemu > - condition: and(gt(variables.pkg_count, 0), succeeded()) > + usePythonVersion: '' # use Python from the container image