From: "Tinh Nguyen" <tinhnguyen@os.amperecomputing.com>
To: Minh Nguyen <minhnguyen1@os.amperecomputing.com>, devel@edk2.groups.io
Cc: patches@amperecomputing.com, quic_llindhol@quicinc.com,
ardb+tianocore@kernel.org, nhi@os.amperecomputing.com,
tinhnguyen@os.amperecomputing.com
Subject: Re: [edk2-platforms][PATCH 1/3] AmpereAltraPkg: Remove PCIe "DevMapModeAuto" case in retrieving Devmap mode
Date: Mon, 22 May 2023 15:01:57 +0700 [thread overview]
Message-ID: <74206894-f0a7-2f8d-d88e-93987e558a64@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <20230511075143.2690207-2-minhnguyen1@os.amperecomputing.com>
Reviewed-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
On 11/05/2023 14:51, Minh Nguyen wrote:
> Because PCIe Auto bifurcation feature doesn't depend on the default
> Devmap mode so that "DevMapModeAuto" is unnecessary in retrieving
> the PCIe Devmap default mode.
>
> Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
> ---
> Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c b/Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c
> index a8e23015b605..199929bfdb24 100644
> --- a/Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c
> +++ b/Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c
> @@ -160,7 +160,7 @@ GetDefaultDevMap (
> UINT8 StartIndex;
> DEV_MAP_MODE DevMapMode;
>
> - DevMapMode = MaxDevMapMode;
> + DevMapMode = DevMapMode4;
> StartIndex = IsGetDevMapLow ? PcieController0 : PcieController4;
>
> while (DevMapMode >= DevMapMode1)
next prev parent reply other threads:[~2023-05-22 8:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 7:51 [edk2-platforms][PATCH 0/3] Add necessary changes for PCIe core and remove unnecessary checks for PCIe Devmap mode Minh Nguyen
2023-05-11 7:51 ` [edk2-platforms][PATCH 1/3] AmpereAltraPkg: Remove PCIe "DevMapModeAuto" case in retrieving " Minh Nguyen
2023-05-22 8:01 ` Tinh Nguyen [this message]
2023-05-11 7:51 ` [edk2-platforms][PATCH 2/3] AmpereAltraPkg: Fix PCIe link training sequence Minh Nguyen
2023-05-22 8:03 ` Tinh Nguyen
2023-05-11 7:51 ` [edk2-platforms][PATCH 3/3] AmpereAltraPkg: Add retry logic when PCIe card is present Minh Nguyen
2023-05-12 2:51 ` [edk2-platforms][PATCH 0/3] Add necessary changes for PCIe core and remove unnecessary checks for PCIe Devmap mode Nhi Pham
2023-05-24 0:45 ` Minh Nguyen
2023-06-02 12:34 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74206894-f0a7-2f8d-d88e-93987e558a64@amperemail.onmicrosoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox