From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.99]) by mx.groups.io with SMTP id smtpd.web11.16937.1684742533769312297 for ; Mon, 22 May 2023 01:02:14 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=voZdeo6w; spf=pass (domain: os.amperecomputing.com, ip: 40.107.92.99, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JJ+cbv56zgcizL6aIiEjkLDi0LBct0Cl5pdrp8axN1cpngygr9KJCxF2fGXjfHCqvlCum1I1GccdeU1h7RHYS6p6/lMJkkG8LxDkvqF1nG8Uwxe2CliINxOwVyqEnzjPz199rP5/Rx0cI1XoRugWxJZQImLkNdnh9tePAzrZhmmbpcykQic37wwXsJ5SMg1hajm95l1jj8H2A3uCWa26ewXezvEoRGBoOSX9a5qE6QyVcj6GZEFBWDW6Fz8gdupp6oLZ1x8wAW7IB3xooriVWS65qldk+LntqbblM2Mihk8e7CTQ+s4SuAfWNHWZ+NWnh5vamoQeMNK8eZLwrmJFLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WnV9Z6Rcnuojc0/fmbU9jTAM4t7Maf1iQg6O095jTNk=; b=B8kf0zAG6XsKbOehjeOw4xoS8XgCMbQBniafcDoU02esnRz+Rr4gnm/fZvZCfixvG/Zv24nMcHP9JNjlDUlioLUboulTOVWT71Nz240eUEx25FOCqnB3ZnNeIiOhm2nx1Ow/QU7vzTWfNYNigxmZ8dWsu+9g1VjA/MOT2f1PBnViAIUoBuIQPqolCRXwMhWnDoyRXpZNqXsbSuvjgIuX13QWYh4iUWXlujywr3u2D1Q6HEPV1lMh7DvBQRafhyK8p5wB6qB+nnOqAa/VmM9FWDqjpW050iecyntXU6sUNI8N2AbR2daV2ypq0HNBjgs0fkLjomz5yIKhfnuTfCZc2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WnV9Z6Rcnuojc0/fmbU9jTAM4t7Maf1iQg6O095jTNk=; b=voZdeo6w84QIH9WmyPbxQ5MJqCpKwtChVWfeeOTZFFKe8t/0T4uQXF2sYRZIf8CmrctkOhMz+FYljPtWQhCYXDQdAARFxWXmnhjPGvzIaeYwaPf84wBiIrJECO+O//hv4C8iOiXwEcDWEaZmhnMg1Rkp2AJ7DisCdeOKiwvEuVQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) by BYAPR01MB3863.prod.exchangelabs.com (2603:10b6:a02:84::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Mon, 22 May 2023 08:02:08 +0000 Received: from DM5PR0102MB3336.prod.exchangelabs.com ([fe80::fefc:e2a9:e823:fe42]) by DM5PR0102MB3336.prod.exchangelabs.com ([fe80::fefc:e2a9:e823:fe42%7]) with mapi id 15.20.6411.027; Mon, 22 May 2023 08:02:08 +0000 Message-ID: <74206894-f0a7-2f8d-d88e-93987e558a64@amperemail.onmicrosoft.com> Date: Mon, 22 May 2023 15:01:57 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [edk2-platforms][PATCH 1/3] AmpereAltraPkg: Remove PCIe "DevMapModeAuto" case in retrieving Devmap mode To: Minh Nguyen , devel@edk2.groups.io Cc: patches@amperecomputing.com, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com References: <20230511075143.2690207-1-minhnguyen1@os.amperecomputing.com> <20230511075143.2690207-2-minhnguyen1@os.amperecomputing.com> From: "Tinh Nguyen" In-Reply-To: <20230511075143.2690207-2-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2PR06CA0204.apcprd06.prod.outlook.com (2603:1096:4:1::36) To DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR0102MB3336:EE_|BYAPR01MB3863:EE_ X-MS-Office365-Filtering-Correlation-Id: ab6b34f8-8bc2-462a-ed9c-08db5a9ad678 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ODzedf8DWIEZE35YpZNV49vAk7tUjBfCKmYkMxwSK0JlUX/4T4tC4hKW6X11bIAMQlZetfdbR2pHC3+3VNJ+OkxonBUpCsTgfKBYka55C4qq4YrlTgCUzZUERS9vEZQzRPKsflRhdYRjVTFJIyX/GHWPqpQPjn8iKOW68FsBVzN9Ku8BBfbJB8SNoHdcsDw1QKWq0B9iiv+7IUp7GJ8FAdLnakwAO8RgejCq0lGcGdbapEaagtFlJXMgjeWIZOlozkRBbSJBdpVLGO5JNdSnQPoyTEXl6DznjXgsbaqpCtlR9x1WrRn4I++jiRA6177SlBuP+qvJmJlMD30hfH8jaQtNwtFMaS9elhXmV1UUXQcfyDAvIZzTfCttK90eQiMeONylyBCZCI0I/4AFkSl+KdHIB2D0TMvH+9Cy+OeYcnettBacfahP68J4s0jFArCi//oMX6eAcFVIM99JDCV+ik9q/IionGuFEpLT+kbh0dBnUHz4CX0iOFoM93tpblRkSofklzFz8nLdbvEV1Q5xDekhbCcq4P9RHbE0KXw7hJ+AF9BwaK7y6yNfLlU9vtQLD3bpP+a37O5J8qViv0N64FAVUUDPPWYRdSbfApLV92rePj2g6cc9pNpr60BZzt8Pe8UxjCg9lkjAo+k50xrcug== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR0102MB3336.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39850400004)(396003)(136003)(346002)(376002)(451199021)(8676002)(8936002)(5660300002)(186003)(26005)(53546011)(6512007)(6506007)(42882007)(83380400001)(2616005)(31696002)(38100700002)(38350700002)(83170400001)(107886003)(41300700001)(6666004)(6486002)(52116002)(66476007)(66556008)(66946007)(316002)(4326008)(478600001)(2906002)(31686004)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVhNN3VDVkJNT3AyVXBBWTZjQm4yclQwZUhMdlkyVE44UVRWb1RsOGhBSW1Q?= =?utf-8?B?azVFdmFBWmVubjA0ZWNONk9od3FrV1FncWN6ZmV5eG53TEhieFBsTXYycTYy?= =?utf-8?B?dHdpUGRheFJoMDJLejc5aldIdlRLOTRleXFSMFdOUVpKdUpFK2YyZ2ZzTkRL?= =?utf-8?B?QVgxK3dXbjU2d3UyU3JMWlFTWTlneEpGYmNIRlZVeklZTHdUcDV2L3l2WXBs?= =?utf-8?B?MUR3Slo3ZUNYenhCTEs3SFVtZVBGZVRSb2ZFZ24rem0vMWFMUkJBVzdBcnFn?= =?utf-8?B?NlNmamNrNklmT21UaEZLb1I4U2YxZXFLN2Z4eSt5VHBVQmpyVG56eDBFMi9B?= =?utf-8?B?QzJ6M3FUS0liRE5NTU11RnJUZDVPcllRcXZ3akFQcVk1Z2ZxN1Q0eTJsR1NJ?= =?utf-8?B?cnZDYnordEZRWU9zc1pUUjJrVUNVOXRBNGtSQ3F6TEhIZ0JTRWhVMjNEbUY3?= =?utf-8?B?bXJsYytpQXp3UkpnT1dKNVBKRm1ueWt1ZHhBY0pDdFhWZGhzYWtVYkdkRm5a?= =?utf-8?B?Zk54U3hjZWhxTWE5WXB3bUlTaW9CdDhCRys0cWk0Yldsd1BmZk5BUmlGSm5T?= =?utf-8?B?bEVGbGlRNnNlMmVrRTZVc1JTc3EzKzJ5Z0RLbjc0a1VYcVdpOXN4MnpWc0V3?= =?utf-8?B?My9naENiMWplUCtDcEpoeUljSFlsSU5NcGNhMjUvYVdGdXc0aW02UHZRdTI5?= =?utf-8?B?Uy9HdHNxTzk1bi8rM2JscStPazdZWXRpaGtpQUp1RXo3b3I2OGVNZE5NSmYw?= =?utf-8?B?TmI0YW13TTJoNkV1NDYvZGsrTU1PNmF0dThCTjJzSE9paURFd0dLRWJFa1BH?= =?utf-8?B?RUFLU3RiQVozeVFycFVuWFk5YnAxU0pyVFdYbVd5VkdVUk5ZTVhkUUthcmlW?= =?utf-8?B?NWZtQVlSSzdES0xyRFFlRm9kTXhyUVNwVzlrMzZ1Z1l6Z1pWaXNKcVVXRXlk?= =?utf-8?B?QllJS3lhQktOT2Q5T3JJdHRCeUZUTWVoVGcwdEQxYlpENWJlQVk0ejU2SHZa?= =?utf-8?B?THk3V2FWSENFUXF3V3ZSSHhKVGtWQnpkVUdjM21MTWMxQ1gwK3QvQVBUNjYx?= =?utf-8?B?WXZMdDNyMGh6UjBLRXRYK0EwdTVMa0tydDlGb1B2RHpJTi9YeWxNQVFoeUo1?= =?utf-8?B?d0JTSXJyTVZLbVMwMk9yeTJoKzFBY1RtNnRnUkpSdFhqTlFkeklHaDlpTm12?= =?utf-8?B?VWNSTlBSVkwyTFhRNGtGR3k0aWlhNm5zcmovdzZ2bEFWVWx4ZmZ6eVpLNG5Z?= =?utf-8?B?SXhXYkFrMjcrLys4T05vR2NTbnE3dlp2d1ppRit4a3JrbXZYb2NsTFZ5azVp?= =?utf-8?B?TlB3TlExTEhGajVRS3ppN0xvR0t1czdaZnR0S2MxRGE3RjU4bXJJa3JSUmVH?= =?utf-8?B?R25VZ0prYnJIV3g5ZVI0NHhwVUgvOG5jRjZmNFozbkdBd0x5WHgzNmJ4UHho?= =?utf-8?B?d2JJV2RWNTRReWRTOUd2RG0ydndpMXg1YlUrU1ZUQUhIay9DSnNlMHpWb3cw?= =?utf-8?B?Uy8rVkJEc0FsZjhONEVidnRhL3BJRXM5NDB3U0pJQTN1R1FxVGZ6enBNU2M2?= =?utf-8?B?aURSNUx0eHBWenlta1RqNEdMQzVaRVhteFN0cm9MS1F3Vk9tNnFiSWJSMERh?= =?utf-8?B?bTN1RUdtVG9UYjVpSktSN3FLTGYxZEZQcFAxb2xXU3M1cHFlUXVPdFNUK3ZN?= =?utf-8?B?eTN1TDJqWlkxSW1kVUd2NEY1YzRXTFhKVHlUU2FKRHl0dkVqM2pqdk1McGx2?= =?utf-8?B?elJ1U0hoRloyaGFwdWtxTDFCTW9wNUdSUjYrUVU0aitpblZsTVd2QmY1RkJU?= =?utf-8?B?UWdHc291RHN6NnNqaHB4Yy9EMnpUaVBzOW1vdVZ1Qk9iVU1ITlJubDh1Nm9Y?= =?utf-8?B?ZFdOUUpXT3RZSkYvVnU0TlFSSHh6dlozQUFXbXJhNGQvY2twTU9UNmUwYVhn?= =?utf-8?B?OUN5QTEwZE5zRU10ZGYwYnIzTGRNQzJNbllYd1ZLQjEwdFd5b2R0OFg5U2dW?= =?utf-8?B?NzdicDNQVzRUYit0amFiQWhQcnFjNGZEQmpNaTh6WmVZaWxyUzkrbjRhejRv?= =?utf-8?B?Tzdva0J4VTNRWUNVN1JZSms0STlzYXlONlh4RWhnbHRkM1ZLNUZZM2xxWTda?= =?utf-8?B?MkFQdVJIR3pUTkxYUGpPRjM3T1FxN25Bc2k5YWpyRFRQV3loQUNzc0J2Zng3?= =?utf-8?Q?yiz+7T8h662xdWDYxzrPB2I=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab6b34f8-8bc2-462a-ed9c-08db5a9ad678 X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3336.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 08:02:08.0573 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xiAypX+F87FJJrnEjSrzdK9jhzGnFz5UoD8FaJ/dczOQzKamtCFNFWnKElnvxhOUlimY+eyFvZ+A5dASct3JBkRw2ttCfejRmN4cJn8UiEIeRlmM4KAsqbVR5LgyfKVX X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR01MB3863 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Tinh Nguyen On 11/05/2023 14:51, Minh Nguyen wrote: > Because PCIe Auto bifurcation feature doesn't depend on the default > Devmap mode so that "DevMapModeAuto" is unnecessary in retrieving > the PCIe Devmap default mode. > > Signed-off-by: Minh Nguyen > --- > Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c b/Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c > index a8e23015b605..199929bfdb24 100644 > --- a/Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c > +++ b/Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam.c > @@ -160,7 +160,7 @@ GetDefaultDevMap ( > UINT8 StartIndex; > DEV_MAP_MODE DevMapMode; > > - DevMapMode = MaxDevMapMode; > + DevMapMode = DevMapMode4; > StartIndex = IsGetDevMapLow ? PcieController0 : PcieController4; > > while (DevMapMode >= DevMapMode1)