From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, Jian J Wang <jian.j.wang@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file
Date: Thu, 15 Sep 2022 15:36:07 -0400 [thread overview]
Message-ID: <742e1908-50f7-1042-e8c6-2baab289034c@linux.microsoft.com> (raw)
In-Reply-To: <20220907050530.512-2-mikuback@linux.microsoft.com>
Hi Jian,
Can you please provide a review for this patch?
Mike Kinney has already given an R-b for [PATCH v1 2/2] so the series
will be ready once this patch is reviewed.
Thanks,
Michael
On 9/7/2022 1:05 AM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4050
>
> Adds the package as a supported package to .pytool/CISettings.py
> and adds a CI YAML for the package so it can be run in CI.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> .pytool/CISettings.py | 1 +
> SignedCapsulePkg/SignedCapsulePkg.ci.yaml | 90 ++++++++++++++++++++
> 2 files changed, 91 insertions(+)
>
> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
> index cf9e0d77b19b..306e27893e58 100644
> --- a/.pytool/CISettings.py
> +++ b/.pytool/CISettings.py
> @@ -62,6 +62,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
> "UefiCpuPkg",
> "FmpDevicePkg",
> "ShellPkg",
> + "SignedCapsulePkg",
> "StandaloneMmPkg",
> "FatPkg",
> "CryptoPkg",
> diff --git a/SignedCapsulePkg/SignedCapsulePkg.ci.yaml b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
> new file mode 100644
> index 000000000000..5f48613bd79f
> --- /dev/null
> +++ b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
> @@ -0,0 +1,90 @@
> +## @file
> +# Core CI configuration for SignedCapsulePkg
> +#
> +# Copyright (c) Microsoft Corporation
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +{
> + ## options defined .pytool/Plugin/LicenseCheck
> + "LicenseCheck": {
> + "IgnoreFiles": []
> + },
> +
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + ],
> + ## Both file path and directory path are accepted.
> + "IgnoreFiles": []
> + },
> +
> + ## options defined .pytool/Plugin/CompilerPlugin
> + "CompilerPlugin": {
> + "DscPath": "SignedCapsulePkg.dsc"
> + },
> +
> + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
> + "HostUnitTestCompilerPlugin": {
> + "DscPath": "" # Don't support this test
> + },
> +
> + ## options defined .pytool/Plugin/CharEncodingCheck
> + "CharEncodingCheck": {
> + "IgnoreFiles": []
> + },
> +
> + ## options defined .pytool/Plugin/DependencyCheck
> + "DependencyCheck": {
> + "AcceptableDependencies": [
> + "MdeModulePkg/MdeModulePkg.dec",
> + "MdePkg/MdePkg.dec",
> + "SecurityPkg/SecurityPkg.dec",
> + "SignedCapsulePkg/SignedCapsulePkg.dec"
> + ],
> + # For host based unit tests
> + "AcceptableDependencies-HOST_APPLICATION":[
> + "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
> + ],
> + # For UEFI shell based apps
> + "AcceptableDependencies-UEFI_APPLICATION":[],
> + "IgnoreInf": []
> + },
> +
> + ## options defined .pytool/Plugin/DscCompleteCheck
> + "DscCompleteCheck": {
> + "IgnoreInf": [""],
> + "DscPath": "SignedCapsulePkg.dsc"
> + },
> +
> + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
> + "HostUnitTestDscCompleteCheck": {
> + "IgnoreInf": [""],
> + "DscPath": "" # Don't support this test
> + },
> +
> + ## options defined .pytool/Plugin/GuidCheck
> + "GuidCheck": {
> + "IgnoreGuidName": [],
> + "IgnoreGuidValue": [],
> + "IgnoreFoldersAndFiles": [],
> + "IgnoreDuplicates": [],
> + },
> +
> + ## options defined .pytool/Plugin/LibraryClassCheck
> + "LibraryClassCheck": {
> + "IgnoreHeaderFile": []
> + },
> +
> + ## options defined .pytool/Plugin/SpellCheck
> + "SpellCheck": {
> + "AuditOnly": True, # Failures need to be reviewed and resolved in the future
> + "IgnoreFiles": [], # use gitignore syntax to ignore errors in matching files
> + "ExtendWords": [], # words to extend to the dictionary for this package
> + "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore
> + "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
> + }
> +}
next prev parent reply other threads:[~2022-09-15 19:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 5:05 [PATCH v1 0/2] SignedCapsulePkg: Enable CI Michael Kubacki
2022-09-07 5:05 ` [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file Michael Kubacki
2022-09-15 19:36 ` Michael Kubacki [this message]
2022-09-23 1:06 ` [edk2-devel] " Michael Kubacki
2022-10-03 14:45 ` Michael Kubacki
2022-09-07 5:05 ` [PATCH v1 2/2] .azurepipelines: Add SignedCapsulePkg to CI Michael Kubacki
2022-09-09 1:36 ` Michael D Kinney
2022-10-04 15:51 ` [PATCH v1 0/2] SignedCapsulePkg: Enable CI Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=742e1908-50f7-1042-e8c6-2baab289034c@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox