From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.14859.1663270568961305857 for ; Thu, 15 Sep 2022 12:36:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=G3068HH2; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 2714420B929C; Thu, 15 Sep 2022 12:36:08 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2714420B929C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1663270568; bh=sxIcmBJyuV6vJASfy6LZLVwjK+agGxjU8DTxDnbsBkk=; h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From; b=G3068HH2YH+nB9Bifh/v2fmtETlXzv1FCQ4QisSRD4K13OLn4MjSO2dyGeVV7VKah anoaxO8MXwIGP3Z37AjtT1aNnGwXJJ8HhKrEU4l9vemczYjgW753oJSxdnggjhLt8O e3wtyqcPpXe3vaQ0fwdeKdRnr8ScO3rqQ4Y9ebRw= Message-ID: <742e1908-50f7-1042-e8c6-2baab289034c@linux.microsoft.com> Date: Thu, 15 Sep 2022 15:36:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [edk2-devel] [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file From: "Michael Kubacki" To: devel@edk2.groups.io, Jian J Wang Cc: Michael D Kinney Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <20220907050530.512-1-mikuback@linux.microsoft.com> <20220907050530.512-2-mikuback@linux.microsoft.com> In-Reply-To: <20220907050530.512-2-mikuback@linux.microsoft.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jian, Can you please provide a review for this patch? Mike Kinney has already given an R-b for [PATCH v1 2/2] so the series will be ready once this patch is reviewed. Thanks, Michael On 9/7/2022 1:05 AM, Michael Kubacki wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4050 > > Adds the package as a supported package to .pytool/CISettings.py > and adds a CI YAML for the package so it can be run in CI. > > Cc: Jian J Wang > Signed-off-by: Michael Kubacki > --- > .pytool/CISettings.py | 1 + > SignedCapsulePkg/SignedCapsulePkg.ci.yaml | 90 ++++++++++++++++++++ > 2 files changed, 91 insertions(+) > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py > index cf9e0d77b19b..306e27893e58 100644 > --- a/.pytool/CISettings.py > +++ b/.pytool/CISettings.py > @@ -62,6 +62,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag > "UefiCpuPkg", > "FmpDevicePkg", > "ShellPkg", > + "SignedCapsulePkg", > "StandaloneMmPkg", > "FatPkg", > "CryptoPkg", > diff --git a/SignedCapsulePkg/SignedCapsulePkg.ci.yaml b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml > new file mode 100644 > index 000000000000..5f48613bd79f > --- /dev/null > +++ b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml > @@ -0,0 +1,90 @@ > +## @file > +# Core CI configuration for SignedCapsulePkg > +# > +# Copyright (c) Microsoft Corporation > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > +{ > + ## options defined .pytool/Plugin/LicenseCheck > + "LicenseCheck": { > + "IgnoreFiles": [] > + }, > + > + "EccCheck": { > + ## Exception sample looks like below: > + ## "ExceptionList": [ > + ## "", "" > + ## ] > + "ExceptionList": [ > + ], > + ## Both file path and directory path are accepted. > + "IgnoreFiles": [] > + }, > + > + ## options defined .pytool/Plugin/CompilerPlugin > + "CompilerPlugin": { > + "DscPath": "SignedCapsulePkg.dsc" > + }, > + > + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin > + "HostUnitTestCompilerPlugin": { > + "DscPath": "" # Don't support this test > + }, > + > + ## options defined .pytool/Plugin/CharEncodingCheck > + "CharEncodingCheck": { > + "IgnoreFiles": [] > + }, > + > + ## options defined .pytool/Plugin/DependencyCheck > + "DependencyCheck": { > + "AcceptableDependencies": [ > + "MdeModulePkg/MdeModulePkg.dec", > + "MdePkg/MdePkg.dec", > + "SecurityPkg/SecurityPkg.dec", > + "SignedCapsulePkg/SignedCapsulePkg.dec" > + ], > + # For host based unit tests > + "AcceptableDependencies-HOST_APPLICATION":[ > + "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec" > + ], > + # For UEFI shell based apps > + "AcceptableDependencies-UEFI_APPLICATION":[], > + "IgnoreInf": [] > + }, > + > + ## options defined .pytool/Plugin/DscCompleteCheck > + "DscCompleteCheck": { > + "IgnoreInf": [""], > + "DscPath": "SignedCapsulePkg.dsc" > + }, > + > + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck > + "HostUnitTestDscCompleteCheck": { > + "IgnoreInf": [""], > + "DscPath": "" # Don't support this test > + }, > + > + ## options defined .pytool/Plugin/GuidCheck > + "GuidCheck": { > + "IgnoreGuidName": [], > + "IgnoreGuidValue": [], > + "IgnoreFoldersAndFiles": [], > + "IgnoreDuplicates": [], > + }, > + > + ## options defined .pytool/Plugin/LibraryClassCheck > + "LibraryClassCheck": { > + "IgnoreHeaderFile": [] > + }, > + > + ## options defined .pytool/Plugin/SpellCheck > + "SpellCheck": { > + "AuditOnly": True, # Failures need to be reviewed and resolved in the future > + "IgnoreFiles": [], # use gitignore syntax to ignore errors in matching files > + "ExtendWords": [], # words to extend to the dictionary for this package > + "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore > + "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported) > + } > +}