Re: [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Jeff,

Apologies for the delay and thank you for this fix.

This change looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 15/11/2022 06:01 pm, Jeff Brasen wrote:
> _LPI Revision should be 0 per the ACPI 6.5 specification.
> "The revision number of the _LPI object. Current revision is 0."
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
>   .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c    | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> index d06c7615fb..91199c4af2 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> @@ -482,7 +482,7 @@ GenerateLpiStates (
>       }
>   
>       // We do not support the LevelId field for now, let it to 0.
> -    Status = AmlCreateLpiNode (AslName, 1, 0, ScopeNode, &LpiNode);
> +    Status = AmlCreateLpiNode (AslName, 0, 0, ScopeNode, &LpiNode);
>       if (EFI_ERROR (Status)) {
>         ASSERT (0);
>         return Status;