From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (EUR03-AM7-obe.outbound.protection.outlook.com [40.107.105.83]) by mx.groups.io with SMTP id smtpd.web10.106426.1671031465802784175 for ; Wed, 14 Dec 2022 07:24:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=i4hhEjwQ; spf=pass (domain: arm.com, ip: 40.107.105.83, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6lHLerd+hBbFbJs+1j/yq4tHsrKfwOrR7/EONM0FnbU=; b=i4hhEjwQ9e9xf+eDag+dBFCjj5I9ai05wwRxG8bZFiigQ6726+KowlAW4CH85/foDsY2uyYujkgWUSp/nPSFMubmZZyNWmbAYs1SG3B7vy4I0gWMT13NkdIebKuj2YA0GGqAFT9svFqVexA6/nkCwmVZb4MHNeAzU/n3j/Tn978= Received: from AM6P194CA0015.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::28) by DU0PR08MB8375.eurprd08.prod.outlook.com (2603:10a6:10:408::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.11; Wed, 14 Dec 2022 15:24:22 +0000 Received: from VI1EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:90:cafe::d2) by AM6P194CA0015.outlook.office365.com (2603:10a6:209:90::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.11 via Frontend Transport; Wed, 14 Dec 2022 15:24:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT010.mail.protection.outlook.com (100.127.144.228) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.11 via Frontend Transport; Wed, 14 Dec 2022 15:24:21 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Wed, 14 Dec 2022 15:24:21 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: db8805e3d0e559e2 X-CR-MTA-TID: 64aa7808 Received: from 086c8b62c96e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7FA75FA7-4AB9-4E7B-9631-B9A454F89F74.1; Wed, 14 Dec 2022 15:24:14 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 086c8b62c96e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 14 Dec 2022 15:24:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I5ufNVcrBOYXMvVyBqARWFA53M9IR3kHmLbMiTCFdrVlinEL0uRlQsYa2V4M9qLgtvnkTXcNPIlBQA7s/WBXGiNp+pbCfY2TcM8beHEFgcj5v9CiDhZar8+JL00wTUnfW2YkI8xBFYjQRObC3v509rY90kN3TD6K8ZzEQ+fZ7iW+sVvas17uHGfMEn/oPiPH2OMbByBqv7gh6nVtu0xPQedUnihRoKwAEYWNbIsziujmqZwd79BYxvR8o2zz+FYYGsuRcS2mBcABdI5o6tqnf1qE5HiPfU/0uMOtpYr2eqwlRTZ1vQhKWHi/5nL7m8qiITVNrz0ZV7bGso/3D2C6xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6lHLerd+hBbFbJs+1j/yq4tHsrKfwOrR7/EONM0FnbU=; b=MQwQ8lPxj4SjL1GKGa6epDauNCgJ+FQHaaqYl/MvxqxCWMzihK1XCmfRWbKw6fKuWqFs25qixsX67ZlEqhqlqh49MWV1MqBQztvF6UusI2fK6SQgGJBx3R7IRj8PN09WV5pSogotUWmdyk9AT71p4ZUlA8iKvaa4R9DMmjihaNGCMoJMQlBBXRRSYh4zLNq13eNcxsEy5Zmx9mh9RgDrcUa3XScN3vbnC8iXeWBNrS/z2PUHzk4OgCmoLgfal7z9DvQygMLU8nkStvNdJ7CJ+mE1pTgdcH7P1uKykVuf9/9cvJmpM5rMtqBtUZps6FsqN0JwUo9pRWU04voHJt5Mqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6lHLerd+hBbFbJs+1j/yq4tHsrKfwOrR7/EONM0FnbU=; b=i4hhEjwQ9e9xf+eDag+dBFCjj5I9ai05wwRxG8bZFiigQ6726+KowlAW4CH85/foDsY2uyYujkgWUSp/nPSFMubmZZyNWmbAYs1SG3B7vy4I0gWMT13NkdIebKuj2YA0GGqAFT9svFqVexA6/nkCwmVZb4MHNeAzU/n3j/Tn978= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAXPR08MB7441.eurprd08.prod.outlook.com (2603:10a6:102:2b9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.9; Wed, 14 Dec 2022 15:24:07 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::eca2:349c:4dbf:7f10]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::eca2:349c:4dbf:7f10%9]) with mapi id 15.20.5924.010; Wed, 14 Dec 2022 15:24:07 +0000 Message-ID: <74339b0d-8faa-328f-663b-182c42145b7d@arm.com> Date: Wed, 14 Dec 2022 15:24:05 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect To: Jeff Brasen , devel@edk2.groups.io Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, Alexei.Fedorov@arm.com, pierre.gondois@arm.com, "nd@arm.com" References: From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO4P123CA0643.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::10) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PAXPR08MB7441:EE_|VI1EUR03FT010:EE_|DU0PR08MB8375:EE_ X-MS-Office365-Filtering-Correlation-Id: 36a59a25-a6b9-4450-8bb6-08dadde746c6 X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: F5GZpsUKL88q6TcrM/birxSAWHSHMClthnKps1RuRT8bV+enDLJSp1h+hwD6MS0huSaN0A429tGm9HvGca4oozNyc5c4OTxA3exLGSBKGU5dUIBmsg3Bi9jiM8WUVR3MHhRdCkfkyr0wscWgA7oe5D3rGtn1kSUR9XPLrI36xffeedLEW/w5EsssSe3Fiz4kGOjwSASV6qPFj2AdVLqCiFgbaOWY+e+Mc+jr044g8QMFUG+XVHQlS3QWjGwzwz7rGXFjmgCV0YmFhVRoNi9y/6xm5WqjuLSoL79ewIP0OL7Mj2U9jsnhTISQoHiw4BTgd7AmAmqlKEYv2K+bsrI8KK0ngWo2ODvXW68qbraieqvxeA+q7FAHoSirxLvhJLc9669/ftdMOZrlwQ4nqPVHUnusU1P2ktqrDkMXuWpMzw97O+E678CjCAzEUXPIv7bFwvqdOsWcTYll5XHhakyQ5Q7A3h2iALh5KQfdg/7bpDUX5iyEITSdunxIcjc5ekg1M3pxdoXlBCEYohiC2kqcJ095Kjr6UeYNCz+EqVctFk4qvDyZG2kusoecdVwybZqFZ3CQMeNTRkX75lvng+pShqiXzDGN6S7AcaBCu1n/4BeumdEoK67N/Gs0pUvajjmSt4fWWtkAM/uLcqzYGjJiRpjNx7ElNF6Z4F01U+yK98hBh+ul2Sw0tA5HcNIT2OiKn82vOJ6nSG0hAGEVZXNaVvoYYfuM0mlNpQUOGo9gBKQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(451199015)(6486002)(36756003)(478600001)(53546011)(2906002)(2616005)(6512007)(83380400001)(6506007)(86362001)(31696002)(31686004)(26005)(41300700001)(38100700002)(66946007)(66476007)(44832011)(186003)(66556008)(4326008)(8676002)(5660300002)(316002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7441 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bccc48ee-24ce-4cbc-42cc-08dadde73dc6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /dFv1TppG3kVE7NqmPDumOhPqgjCg6fxYC/QDCwC2jlcWcsHU0MG8QAq1ZjqKVr/i+1jkG5sbYBbm0zglBNqRth7IvkGMrfC6ApI6p4KtpK0bZJQz1HLiOLgNWQbY3r3Zqzyj4kIwtuB/CqCgORSXujN6yn3ONihDoWBrLrHRQqem3PmMKUsktGPlK1//v79th4MXStnuMYtKqUnEl57vFjNkx1c41xNwlvlpFFceh9CI5z6I7UNS/54hMHC2INF2GxL6xztVwGQxEgD4pIG6xDoGslLQP2DgQBmL+26A9gi5H12R/ovjReGihqIkYUT3qYDC+yK0hA+IPVl73+Pjgl/jDUu0Oem7AnhX4TrsYrB7GGnuaTL4xYDGKxyE8aH43u96ftb/kXdvudczWBl3q5wSHFcFG/W7kDtR2UzTUfudD/b6BMTaleuwA4CKLiWtkNQubMtoKu/Scq/+qEIDunRRUoFDREU9pg2qloYsoELsYOfQ3f0ZniuEA0vCMwK6nyWMKmq8zE7E6xGnfMleh72JZkw78rs5VfMsLi8TGCVHmxdXx/DENf87zPwu+on3Vgk5dXdN0JwtdvgXupebv3PJao4p1/dSu9t36M3s+59kJG3pSdq2xiUKnnmXZ9goPswhoggWK7ZbYjgFJJqfCo54COonEb3VElHI1Uamxqfjas5ujKqiWKDxQBZHtScDqfqOzQ3ac4B2+O1cWxcZliprVXKpHB0Zf8/P94KQ9Y= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199015)(40470700004)(46966006)(36840700001)(70586007)(70206006)(2906002)(8676002)(316002)(44832011)(4326008)(41300700001)(82310400005)(336012)(6506007)(2616005)(31696002)(47076005)(82740400003)(86362001)(5660300002)(31686004)(8936002)(6486002)(6512007)(478600001)(36860700001)(186003)(356005)(26005)(81166007)(40460700003)(53546011)(40480700001)(83380400001)(36756003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 15:24:21.9697 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 36a59a25-a6b9-4450-8bb6-08dadde746c6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8375 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jeff, Apologies for the delay and thank you for this fix. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 15/11/2022 06:01 pm, Jeff Brasen wrote: > _LPI Revision should be 0 per the ACPI 6.5 specification. > "The revision number of the _LPI object. Current revision is 0." > > Signed-off-by: Jeff Brasen > --- > .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c > index d06c7615fb..91199c4af2 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c > @@ -482,7 +482,7 @@ GenerateLpiStates ( > } > > // We do not support the LevelId field for now, let it to 0. > - Status = AmlCreateLpiNode (AslName, 1, 0, ScopeNode, &LpiNode); > + Status = AmlCreateLpiNode (AslName, 0, 0, ScopeNode, &LpiNode); > if (EFI_ERROR (Status)) { > ASSERT (0); > return Status;