From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D50A9740035 for ; Thu, 28 Sep 2023 16:16:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=yFyaQ9K2A7DDOlgtt508jLYGM21oi8MgXQhexQ1vkH4=; c=relaxed/simple; d=groups.io; h=Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695917810; v=1; b=m7e9aW9DUcf2Gpy/BH63TfPvqkmXYMqWeXYPvl0vvNBOu3aYe4+HPfCo4oEF7n8yfcfwTFDh L7FiBWRjfdJjDnrd/j7Ecpn8YRVS3FYhLwO25KvQlMLEvScLTCZ69Ai2PAygS7krbuVPz5HbbHE D86nB6SkYaYkGv4wd9gb+qPA= X-Received: by 127.0.0.2 with SMTP id 1g6XYY7687511xeBcfkJu5Ct; Thu, 28 Sep 2023 09:16:50 -0700 X-Received: from EUR03-AM7-obe.outbound.protection.outlook.com (EUR03-AM7-obe.outbound.protection.outlook.com [40.107.105.57]) by mx.groups.io with SMTP id smtpd.web11.17596.1695917809210080545 for ; Thu, 28 Sep 2023 09:16:50 -0700 X-Received: from AS8PR04CA0020.eurprd04.prod.outlook.com (2603:10a6:20b:310::25) by AM8PR08MB6562.eurprd08.prod.outlook.com (2603:10a6:20b:355::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22; Thu, 28 Sep 2023 16:16:39 +0000 X-Received: from AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:310:cafe::67) by AS8PR04CA0020.outlook.office365.com (2603:10a6:20b:310::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.23 via Frontend Transport; Thu, 28 Sep 2023 16:16:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT028.mail.protection.outlook.com (100.127.140.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.19 via Frontend Transport; Thu, 28 Sep 2023 16:16:38 +0000 X-Received: ("Tessian outbound ee9c7f88acf7:v211"); Thu, 28 Sep 2023 16:16:38 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7b972bd304047fa6 X-CR-MTA-TID: 64aa7808 X-Received: from 4793a5826e69.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1BF23595-0360-42F2-B478-DF3B18047E3A.1; Thu, 28 Sep 2023 16:16:27 +0000 X-Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4793a5826e69.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 28 Sep 2023 16:16:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kqiSRyHWaDXgF0GsOPfqdAK+0sc4bUTSElVqD1cTzuhEjKWsrAXDKtIQZjwQm4FjcjNsrPDe9CQlMho0JjHVrOoSBZaAOlSVg9BHyBx+VkdWYut7VdtyMTpPyMchK23vDS82C6s4pZtJlZ5rulNyslQhRsak3wAX4gtqGbP4u2VWOR2kNRYFazrZN/zHcMYCNJQGGkitjagIIHbGTCM3UJA65SUO/jyERTONPRT5+KxWukcTrKlZ/b8rY2DPP4FieCaR4Gr960xA5p8RFeGwb0QItSR36zxHrywNJsIAbDb3N5l6Ds2/G24WOwoLSPCWGpa8UZRr4rpA04RkzPdkLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FRAospDLO4OYETBXWfkcOL5iiLTCXglp4JqAH0v7EWM=; b=GqI7kwx5vjpQC+bHTqJULuNJN8z6f1SuTz09w3gxR9KN1p78yvClJJABfo307KLsi+1PIkRWuWzLeeRycyzyVmyQucjCDtaLB8YC1OmZQsmg8yZbL3IGag74k6qwWMt2pcWBUo3lykGuYKn4X6LDSOqM3NtA+lY9J46vf+HfduUJmtewj5h2GoWAyydzBH2zJW+rdBy9XFYnsT3S7k8xxOyopXPhTV3fqCQuxVKlJINFa6DB+Yx1T8TPs50OGea1j+iwqjeycMJZqesCpY0fOvzOn9+kuWcYbujxYWZX55LOtc282amzsAMTKb0rsXbgJlYI004vVfKmoHQsMVu+6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM8PR08MB6594.eurprd08.prod.outlook.com (2603:10a6:20b:36a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.21; Thu, 28 Sep 2023 16:16:25 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce%4]) with mapi id 15.20.6838.016; Thu, 28 Sep 2023 16:16:25 +0000 Message-ID: <74654aa1-3d9f-23ba-f233-0a3941315d4d@arm.com> Date: Thu, 28 Sep 2023 17:16:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH v2 2/2] StandaloneMmPkg: Arm: Update to use the new StandaloneMmCpu driver To: Tuan Phan , devel@edk2.groups.io Cc: ardb+tianocore@kernel.org, ray.ni@intel.com, huangming@linux.alibaba.com, sunilvl@ventanamicro.com, yong.li@intel.com, "nd@arm.com" , yeoreum.yun@arm.com References: <20230914231037.23950-1-tphan@ventanamicro.com> <20230914231037.23950-3-tphan@ventanamicro.com> From: "Sami Mujawar" In-Reply-To: <20230914231037.23950-3-tphan@ventanamicro.com> X-ClientProxiedBy: LO2P265CA0051.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::15) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|AM8PR08MB6594:EE_|AM7EUR03FT028:EE_|AM8PR08MB6562:EE_ X-MS-Office365-Filtering-Correlation-Id: d2b1280d-bf86-4a8d-38a5-08dbc03e4b74 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5+KR7ZpVDnP1N2uwpNE8UmaKiwmn7lWkkC6PijLA33nwKPv2ERaSyRR0fLG7XzKPXoOQQBAgmvDUK7ujnVE8dKKVq8/xz3OxzYxUEsfbDKEIxjJVA0x7K9CTaI+tLhTG/ia8G3Ujv1fdwNf1Uo5QBtDGEpbg9tcJCIdEB71koOOMyy8h16tLlnPb7P2Jda40iH2ljB1KmRa4LiVgy+yDHaDgBVsaJzg4a8Plz4pEh8XW8bI6GeB3JA3KdBwXIE6aV6muxYLQiwNsL0lOI6qw60a2ojI+MWux3H/mkpx86hRCNBvEGlExK2j3rYoTN76JALdOdie/vERcd7WlWJ1ZzWRGeWbiovUYx8LUH7yndQy1TflFCMB2hu38iq+GIG0iJZKt3+/zz/GbhIVcZHqJEokV0D7h1fg3CY9txDQmZVAPkgZRbPx3waa9GqnpUgLQCRyAC67ikKj4pp8Mr2kwh/Z8KNyT66eLX4gp1iDcSZaKQteekgKVKK9rRYq2vdjZHkb0R8KGTxjPkXpwmOz+F1wRro+tauyGykx2AMsXTvHSj2RwIYZDkSkM9WXmVk8OvBSSgDp6+vKIPYtIk1CvhJieYWK9Co5a/s9uy7Ccsi1pPwpR9AkWp7OjqeXUFGSB60F/a3kSF1gCN5Now00vdQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(6029001)(136003)(39860400002)(396003)(366004)(346002)(376002)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(66476007)(31686004)(53546011)(8676002)(44832011)(8936002)(15650500001)(2906002)(41300700001)(4326008)(316002)(36756003)(5660300002)(6506007)(478600001)(31696002)(66556008)(86362001)(6512007)(26005)(38100700002)(66946007)(2616005)(83380400001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6594 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7be2c49a-5f65-49b1-43ed-08dbc03e4327 X-Microsoft-Antispam-Message-Info: G//W8rY2qeusWb5D059UG35ybsU9TinS/NnYWK1Tsf/jOz8riG9OF6zZqHUX895gvKfEivtR7m2PzMou/vHC2EmPkXah2Jrt2XNYmX6Xte1ObHUWk3qVDi9Xhgli4sZkP5tLOmgql8aNwpmp4n64BYTE1qoH1WLZN2payk4pm8fhExNNFutD+qd1v6zzh0A8ZYjsfes9gjDeW9YRaZKUYMMAN2+lGse/FHMhFW+AlJ8XhqksDvUDmZSAhJaJw+NJbs+IDMtIqb0toAj9kLYLL1+8pMXtFKS7XlSmoKLdSWeU8fnJrlnT7be0Qx/hnPF1kU6vcXf3PDIP/W4Q6u4IpSnwKumdqbM/DbJdojK8XpN5qsUC09a5qGHsAODnBK2yq9rronIZp7HGZ+3cG965wF30Yc57hOQyMjsqzAvJmzctgV5AKZp/EbIMrtHkAMdKOXTHv5e9loJjYl5uQyPDg3kvPR7QfxWLMyBKZfmKBH+djcC99OsGdrZ/ZeCUkq6vXisXZlVbo5BWUtW3pK8Y915r/cle/qp0NrimfAqDgBHN4rvkYudraKhQKDf6EF5vtMc7xse5UwJTs1UYL0UYwaYKSRnkp5lxG8rlabNLoGJAcaqRFi6lnUzRTry4btOPSBtoOUAt0xZ+6L4L2k9jtPEuNN4SXXLjXhVFxpjfdOdV5Cr7O5o2l+geLh4YxsQx3pE1LwGdPpNeIVZGJ/TI5Cq/kw2mJ1NWhHqOrgrWnQyQpGaimFMtztFIygrZ2VVIVowC8VdUNrt9PssTTkC4VA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 16:16:38.8689 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d2b1280d-bf86-4a8d-38a5-08dbc03e4b74 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6562 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HrPxLfvgaegkAYrQjVcrHWEtx7686176AA= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=m7e9aW9D; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Tuan, Thank you for this patch. Please see my response inline marked [SAMI]. Regards, Sami Mujawar On 15/09/2023 12:10 am, Tuan Phan wrote: > Update entry point library for Arm to use the new platform independent [SAMI] Should this be worded as architecture independent instead of=20 platform independent? Can you also check the subject line and commit message for patch 1/2,=20 please? [/SAMI] > StandaloneMmCpu driver. > > Signed-off-by: Tuan Phan > --- > .../Library/Arm/StandaloneMmCoreEntryPoint.h | 17 ++------ > .../Arm/CreateHobList.c | 43 ++++++++++--------- > .../Arm/StandaloneMmCoreEntryPoint.c | 15 ++++++- > .../StandaloneMmCoreEntryPoint.inf | 2 +- > 4 files changed, 40 insertions(+), 37 deletions(-) > > diff --git a/StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEntryPoi= nt.h b/StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEntryPoint.h > index 41bf0f132b4f..dbb81610ff8e 100644 > --- a/StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEntryPoint.h > +++ b/StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEntryPoint.h > @@ -10,6 +10,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #ifndef __STANDALONEMMCORE_ENTRY_POINT_H__ > > #define __STANDALONEMMCORE_ENTRY_POINT_H__ > > =20 > > +#include > > #include > > #include > > =20 > > @@ -47,18 +48,6 @@ typedef struct { > EFI_SECURE_PARTITION_CPU_INFO *CpuInfo; > > } EFI_SECURE_PARTITION_BOOT_INFO; > > =20 > > -typedef > > -EFI_STATUS > > -(*PI_MM_ARM_TF_CPU_DRIVER_ENTRYPOINT) ( > > - IN UINTN EventId, > > - IN UINTN CpuNumber, > > - IN UINTN NsCommBufferAddr > > - ); > > - > > -typedef struct { > > - PI_MM_ARM_TF_CPU_DRIVER_ENTRYPOINT *ArmTfCpuDriverEpPtr; > > -} ARM_TF_CPU_DRIVER_EP_DESCRIPTOR; > > - > > typedef RETURN_STATUS (*REGION_PERMISSION_UPDATE_FUNC) ( > > IN EFI_PHYSICAL_ADDRESS BaseAddress, > > IN UINT64 Length > > @@ -145,8 +134,8 @@ LocateStandaloneMmCorePeCoffData ( > VOID * > > EFIAPI > > CreateHobListFromBootInfo ( > > - IN OUT PI_MM_ARM_TF_CPU_DRIVER_ENTRYPOINT *CpuDriverEntryPoint, > > - IN EFI_SECURE_PARTITION_BOOT_INFO *PayloadBootInfo > > + IN OUT PI_MM_CPU_DRIVER_ENTRYPOINT *CpuDriverEntryPoint, > > + IN EFI_SECURE_PARTITION_BOOT_INFO *PayloadBootInfo > > ); > > =20 > > /** > > diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/Creat= eHobList.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateH= obList.c > index 2ac2d354f06a..80ed532352af 100644 > --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobLis= t.c > +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/CreateHobLis= t.c > @@ -13,6 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include > > #include > > =20 > > +#include > > #include > > #include > > #include > > @@ -39,7 +40,7 @@ extern EFI_GUID gEfiStandaloneMmNonSecureBufferGuid; > // GUID to identify HOB where the entry point of the CPU driver will be > > // populated to allow this entry point driver to invoke it upon receipt= of an > > // event > > -extern EFI_GUID gEfiArmTfCpuDriverEpDescriptorGuid; > > +extern EFI_GUID gEfiMmCpuDriverEpDescriptorGuid; > > =20 > > /** > > Use the boot information passed by privileged firmware to populate a = HOB list > > @@ -52,22 +53,22 @@ extern EFI_GUID gEfiArmTfCpuDriverEpDescriptorGuid; > **/ > > VOID * > > CreateHobListFromBootInfo ( > > - IN OUT PI_MM_ARM_TF_CPU_DRIVER_ENTRYPOINT *CpuDriverEntryPoint, > > - IN EFI_SECURE_PARTITION_BOOT_INFO *PayloadBootInfo > > + IN OUT PI_MM_CPU_DRIVER_ENTRYPOINT *CpuDriverEntryPoint, > > + IN EFI_SECURE_PARTITION_BOOT_INFO *PayloadBootInfo > > ) > > { > > - EFI_HOB_HANDOFF_INFO_TABLE *HobStart; > > - EFI_RESOURCE_ATTRIBUTE_TYPE Attributes; > > - UINT32 Index; > > - UINT32 BufferSize; > > - UINT32 Flags; > > - EFI_MMRAM_HOB_DESCRIPTOR_BLOCK *MmramRangesHob; > > - EFI_MMRAM_DESCRIPTOR *MmramRanges; > > - EFI_MMRAM_DESCRIPTOR *NsCommBufMmramRange; > > - MP_INFORMATION_HOB_DATA *MpInformationHobData; > > - EFI_PROCESSOR_INFORMATION *ProcInfoBuffer; > > - EFI_SECURE_PARTITION_CPU_INFO *CpuInfo; > > - ARM_TF_CPU_DRIVER_EP_DESCRIPTOR *CpuDriverEntryPointDesc; > > + EFI_HOB_HANDOFF_INFO_TABLE *HobStart; > > + EFI_RESOURCE_ATTRIBUTE_TYPE Attributes; > > + UINT32 Index; > > + UINT32 BufferSize; > > + UINT32 Flags; > > + EFI_MMRAM_HOB_DESCRIPTOR_BLOCK *MmramRangesHob; > > + EFI_MMRAM_DESCRIPTOR *MmramRanges; > > + EFI_MMRAM_DESCRIPTOR *NsCommBufMmramRange; > > + MP_INFORMATION_HOB_DATA *MpInformationHobData; > > + EFI_PROCESSOR_INFORMATION *ProcInfoBuffer; > > + EFI_SECURE_PARTITION_CPU_INFO *CpuInfo; > > + MM_CPU_DRIVER_EP_DESCRIPTOR *CpuDriverEntryPointDesc; > > =20 > > // Create a hoblist with a PHIT and EOH > > HobStart =3D HobConstructor ( > > @@ -144,13 +145,13 @@ CreateHobListFromBootInfo ( > =20 > > // Create a Guided HOB to enable the ARM TF CPU driver to share its e= ntry > > // point and populate it with the address of the shared buffer > > - CpuDriverEntryPointDesc =3D (ARM_TF_CPU_DRIVER_EP_DESCRIPTOR *)BuildGu= idHob ( > > - &gEfiAr= mTfCpuDriverEpDescriptorGuid, > > - sizeof = (ARM_TF_CPU_DRIVER_EP_DESCRIPTOR) > > - ); > > + CpuDriverEntryPointDesc =3D (MM_CPU_DRIVER_EP_DESCRIPTOR *)BuildGuidHo= b ( > > + &gEfiMmCpuD= riverEpDescriptorGuid, > > + sizeof (MM_= CPU_DRIVER_EP_DESCRIPTOR) > > + ); > > =20 > > - *CpuDriverEntryPoint =3D NULL; > > - CpuDriverEntryPointDesc->ArmTfCpuDriverEpPtr =3D CpuDriverEntryPoint; > > + *CpuDriverEntryPoint =3D NULL; > > + CpuDriverEntryPointDesc->MmCpuDriverEpPtr =3D CpuDriverEntryPoint; > > =20 > > // Find the size of the GUIDed HOB with SRAM ranges > > BufferSize =3D sizeof (EFI_MMRAM_HOB_DESCRIPTOR_BLOCK); > > diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/Stand= aloneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoin= t/Arm/StandaloneMmCoreEntryPoint.c > index 96de10405af8..900e0252ef9f 100644 > --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMm= CoreEntryPoint.c > +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMm= CoreEntryPoint.c > @@ -15,6 +15,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include > > #include > > =20 > > +#include > > #include > > #include > > #include > > @@ -41,7 +42,7 @@ STATIC CONST UINT32 mSpmMinorVerFfa =3D SPM_MINOR_VERS= ION_FFA; > =20 > > #define BOOT_PAYLOAD_VERSION 1 > > =20 > > -PI_MM_ARM_TF_CPU_DRIVER_ENTRYPOINT CpuDriverEntryPoint =3D NULL; > > +PI_MM_CPU_DRIVER_ENTRYPOINT CpuDriverEntryPoint =3D NULL; > > =20 > > /** > > Retrieve a pointer to and print the boot information passed by privil= eged > > @@ -140,6 +141,18 @@ DelegatedEventLoop ( > DEBUG ((DEBUG_INFO, "X6 : 0x%x\n", (UINT32)EventCompleteSvcArgs->A= rg6)); > > DEBUG ((DEBUG_INFO, "X7 : 0x%x\n", (UINT32)EventCompleteSvcArgs->A= rg7)); > > =20 > > + // > > + // ARM TF passes SMC FID of the MM_COMMUNICATE interface as the Even= t ID upon > > + // receipt of a synchronous MM request. Use the Event ID to distingu= ish > > + // between synchronous and asynchronous events. > > + // > > + if ((ARM_SMC_ID_MM_COMMUNICATE !=3D (UINT32)EventCompleteSvcArgs->Ar= g0) && > > + (ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ !=3D (UINT32)EventCompleteSv= cArgs->Arg0)) > > + { > > + DEBUG ((DEBUG_ERROR, "UnRecognized Event - 0x%x\n", (UINT32)EventC= ompleteSvcArgs->Arg0)); > > + continue; [SAMI] I think an error needs to be returned instead of continuing=20 otherwise this changes the original behaviour. Status needs to be set to EFI_INVALID_PARAMETER here. [/SAMI] > > + } [SAMI] The code from this point needs to be enclosed in an else block=20 until before the switch statement. That way the proper error code would be returned. Can you check, please? [/SAMI] > > + > > FfaEnabled =3D FeaturePcdGet (PcdFfaEnable); > > if (FfaEnabled) { > > Status =3D CpuDriverEntryPoint ( > > diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Standalon= eMmCoreEntryPoint.inf b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/= StandaloneMmCoreEntryPoint.inf > index 75cfb98c0e75..d41d7630b614 100644 > --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCore= EntryPoint.inf > +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCore= EntryPoint.inf > @@ -49,7 +49,7 @@ > gMpInformationHobGuid > > gEfiMmPeiMmramMemoryReserveGuid > > gEfiStandaloneMmNonSecureBufferGuid > > - gEfiArmTfCpuDriverEpDescriptorGuid > > + gEfiMmCpuDriverEpDescriptorGuid > > =20 > > [FeaturePcd.ARM, FeaturePcd.AARCH64] > > gArmTokenSpaceGuid.PcdFfaEnable > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109166): https://edk2.groups.io/g/devel/message/109166 Mute This Topic: https://groups.io/mt/101369647/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-