public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chao Li" <lichao@loongson.cn>
To: devel@edk2.groups.io, qiandongyan@loongson.cn
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo
Date: Tue, 16 Jan 2024 20:11:21 +0800	[thread overview]
Message-ID: <747a22f8-8c4b-44cf-bb64-07d6a97b0175@loongson.cn> (raw)
In-Reply-To: <20240116071133.38331-1-qiandongyan@loongson.cn>

[-- Attachment #1: Type: text/plain, Size: 2070 bytes --]

Looks good to me.

Reviewed-by: Chao Li <lichao@loongson.cn>

Hi Liming,

Please help review this patch.


Thanks,
Chao
On 2024/1/16 15:11, Dongyan Qian wrote:
> This fixes messages like:
> "Image type X64 can't be loaded on <Unknown> UEFI system"
>
> Cc: Liming Gao<gaoliming@byosoft.com.cn>
> Cc: Chao Li<lichao@loongson.cn>
> Signed-off-by: Dongyan Qian<qiandongyan@loongson.cn>
> ---
>   MdeModulePkg/Core/Dxe/Image/Image.c | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/Image/Image.c
> index 6bc3a549ae..66d9840b7b 100644
> --- a/MdeModulePkg/Core/Dxe/Image/Image.c
> +++ b/MdeModulePkg/Core/Dxe/Image/Image.c
> @@ -77,12 +77,13 @@ typedef struct {
>   } MACHINE_TYPE_INFO;
>   
>   GLOBAL_REMOVE_IF_UNREFERENCED MACHINE_TYPE_INFO  mMachineTypeInfo[] = {
> -  { EFI_IMAGE_MACHINE_IA32,           L"IA32"    },
> -  { EFI_IMAGE_MACHINE_IA64,           L"IA64"    },
> -  { EFI_IMAGE_MACHINE_X64,            L"X64"     },
> -  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"     },
> -  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64" },
> -  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64" },
> +  { EFI_IMAGE_MACHINE_IA32,           L"IA32"        },
> +  { EFI_IMAGE_MACHINE_IA64,           L"IA64"        },
> +  { EFI_IMAGE_MACHINE_X64,            L"X64"         },
> +  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"         },
> +  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64"     },
> +  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64"     },
> +  { EFI_IMAGE_MACHINE_LOONGARCH64,    L"LOONGARCH64" },
>   };
>   
>   UINT16  mDxeCoreImageMachineType = 0;


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113890): https://edk2.groups.io/g/devel/message/113890
Mute This Topic: https://groups.io/mt/103757732/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 3510 bytes --]

  parent reply	other threads:[~2024-01-16 12:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-16  7:11 [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo Dongyan Qian
2024-01-16  7:11 ` [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch Dongyan Qian
2024-01-16 12:12   ` Chao Li
2024-01-22  1:34     ` Gao, Zhichao
2024-01-16 12:11 ` Chao Li [this message]
2024-01-31  7:00   ` [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo Dongyan Qian
2024-01-31  9:56 ` 回复: " gaoliming via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=747a22f8-8c4b-44cf-bb64-07d6a97b0175@loongson.cn \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox