From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 41B2AD811B0 for ; Tue, 16 Jan 2024 12:11:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QTlO1P0ZC6l/6GnE/ez+B4Wot33/ff1AHXI1II+fHOk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1705407090; v=1; b=O673gld66pqP9Fs0/0/03I1VoKWHtfbFsjwA0bc+d2SzNKitjk6fjceJuEXbZwo+7UU/wxhJ 0KspjUicLrUrO4w5WHI34+rub9E4XhWl73OO7Co/7aZ/zGwqNNhXve7dzx3B/h7YCb+f7xWNSqh dcVbCNDZKCs2Vezn1eqleg+s= X-Received: by 127.0.0.2 with SMTP id 3DIwYY7687511xyhExuUJLdt; Tue, 16 Jan 2024 04:11:30 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.11931.1705407089430219245 for ; Tue, 16 Jan 2024 04:11:30 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8Axz+tqcqZlkbEAAA--.3239S3; Tue, 16 Jan 2024 20:11:22 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Ax3c5pcqZlQAIEAA--.20748S3; Tue, 16 Jan 2024 20:11:21 +0800 (CST) Message-ID: <747a22f8-8c4b-44cf-bb64-07d6a97b0175@loongson.cn> Date: Tue, 16 Jan 2024 20:11:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo To: devel@edk2.groups.io, qiandongyan@loongson.cn Cc: Liming Gao References: <20240116071133.38331-1-qiandongyan@loongson.cn> From: "Chao Li" In-Reply-To: <20240116071133.38331-1-qiandongyan@loongson.cn> X-CM-TRANSID: AQAAf8Ax3c5pcqZlQAIEAA--.20748S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQASCGWmPl8EEAAHsq X-Coremail-Antispam: 1Uk129KBj93XoW7AF4DGryrXFyDJr4fXF15ZFc_yoW8XFyrpF 10vr98K34Iq3yYkay8Xr1DXw18AFZrXr93Xan7tw4UC3sYya4jg3yru3Zagr48Ja1DKayj v34rC34Iqw18X3cCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUyKb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67 AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1UM2AIxVAIcxkEcVAq 07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1lYx0E2Ix0cI8IcVAFwI0_Jr0_Jr 4lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCj r7xvwVCIw2I0I7xG6c02F41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUGVWUWwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r1Y6r17MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E 87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73Uj IFyTuYvjxU28nYUUUUU Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: T3IJkLG40aLgfctFK4hh1K2ax7686176AA= Content-Type: multipart/alternative; boundary="------------YJ3T8mrI40ewiBgRevvoqdjx" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=O673gld6; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none --------------YJ3T8mrI40ewiBgRevvoqdjx Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Looks good to me. Reviewed-by: Chao Li Hi Liming, Please help review this patch. Thanks, Chao On 2024/1/16 15:11, Dongyan Qian wrote: > This fixes messages like: > "Image type X64 can't be loaded on UEFI system" > > Cc: Liming Gao > Cc: Chao Li > Signed-off-by: Dongyan Qian > --- > MdeModulePkg/Core/Dxe/Image/Image.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/= Image/Image.c > index 6bc3a549ae..66d9840b7b 100644 > --- a/MdeModulePkg/Core/Dxe/Image/Image.c > +++ b/MdeModulePkg/Core/Dxe/Image/Image.c > @@ -77,12 +77,13 @@ typedef struct { > } MACHINE_TYPE_INFO; > =20 > GLOBAL_REMOVE_IF_UNREFERENCED MACHINE_TYPE_INFO mMachineTypeInfo[] =3D= { > - { EFI_IMAGE_MACHINE_IA32, L"IA32" }, > - { EFI_IMAGE_MACHINE_IA64, L"IA64" }, > - { EFI_IMAGE_MACHINE_X64, L"X64" }, > - { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM" }, > - { EFI_IMAGE_MACHINE_AARCH64, L"AARCH64" }, > - { EFI_IMAGE_MACHINE_RISCV64, L"RISCV64" }, > + { EFI_IMAGE_MACHINE_IA32, L"IA32" }, > + { EFI_IMAGE_MACHINE_IA64, L"IA64" }, > + { EFI_IMAGE_MACHINE_X64, L"X64" }, > + { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM" }, > + { EFI_IMAGE_MACHINE_AARCH64, L"AARCH64" }, > + { EFI_IMAGE_MACHINE_RISCV64, L"RISCV64" }, > + { EFI_IMAGE_MACHINE_LOONGARCH64, L"LOONGARCH64" }, > }; > =20 > UINT16 mDxeCoreImageMachineType =3D 0; -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113890): https://edk2.groups.io/g/devel/message/113890 Mute This Topic: https://groups.io/mt/103757732/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------YJ3T8mrI40ewiBgRevvoqdjx Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Looks good to me.

Reviewed-by: Chao Li <lichao@loongson.cn>

Hi Liming,

Please help review this patch.


=
Thanks,
Chao
On 2024/1/16 15:11, Dongyan Qian wrote:<= br> 
This fixes messages like:
"Image type X64 can't be loaded on <Unknown> UEFI system"

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Chao Li <lichao@loongson.cn>
Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
---
 MdeModulePkg/Core/Dxe/Image/Image.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/Im=
age/Image.c
index 6bc3a549ae..66d9840b7b 100644
--- a/MdeModulePkg/Core/Dxe/Image/Image.c
+++ b/MdeModulePkg/Core/Dxe/Image/Image.c
@@ -77,12 +77,13 @@ typedef struct {
 } MACHINE_TYPE_INFO;
=20
 GLOBAL_REMOVE_IF_UNREFERENCED MACHINE_TYPE_INFO  mMachineTypeInfo[] =3D {
-  { EFI_IMAGE_MACHINE_IA32,           L"IA32"    },
-  { EFI_IMAGE_MACHINE_IA64,           L"IA64"    },
-  { EFI_IMAGE_MACHINE_X64,            L"X64"     },
-  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"     },
-  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64" },
-  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64" },
+  { EFI_IMAGE_MACHINE_IA32,           L"IA32"        },
+  { EFI_IMAGE_MACHINE_IA64,           L"IA64"        },
+  { EFI_IMAGE_MACHINE_X64,            L"X64"         },
+  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"         },
+  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64"     },
+  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64"     },
+  { EFI_IMAGE_MACHINE_LOONGARCH64,    L"LOONGARCH64" },
 };
=20
 UINT16  mDxeCoreImageMachineType =3D 0;
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#113890) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------YJ3T8mrI40ewiBgRevvoqdjx--